feat: Creating instances now adds instance-directory property to step record

Author: Alan Christie

tests/wapi_adapter.py

@@ -377,6 +377,17 @@ def create_instance(self, *, running_workflow_step_id: str) -> dict[str, Any]:
 
         with open(_INSTANCE_PICKLE_FILE, "wb") as pickle_file:
             Pickler(pickle_file).dump(instances)
+
+        # Use the instance ID as the step's instance-directory (prefixing with '.')
+        with open(_RUNNING_WORKFLOW_STEP_PICKLE_FILE, "rb") as pickle_file:
+            running_workflow_step = Unpickler(pickle_file).load()
+        assert running_workflow_step_id in running_workflow_step
+        running_workflow_step[running_workflow_step_id][
+            "instance_directory"
+        ] = f".{instance_id}"
+        with open(_RUNNING_WORKFLOW_STEP_PICKLE_FILE, "wb") as pickle_file:
+            Pickler(pickle_file).dump(running_workflow_step)
+
         UnitTestWorkflowAPIAdapter.lock.release()
 
         return {"id": instance_id}

workflow/workflow_abc.py

@@ -334,12 +334,6 @@ def get_workflow_steps_driving_this_step(
         #       }
         #     ]
         # }
-        #
-        # Additionally, if the step has started (an instance has been created)
-        # each entry on the array of steps will contain a "instance_directory" property
-        # that is the directory within the Project that's the step's working directory.
-        #
-        #       "instance_directory": ".instance-00000000-0000-0000-0000-00000000000a",
 
     @abstractmethod
     def get_instance(self, *, instance_id: str) -> tuple[dict[str, Any], int]: