refactor: Replicate now uses variable not input

Author: Alan Christie

tests/workflow-definitions/replicate-using-undeclared-input.yaml

@@ -32,7 +32,7 @@ steps:
       value: "999"
   replicate:
     using:
-      input: y
+      variable: y
   variable-mapping:
   - variable: inputFile
     from-step:

tests/workflow-definitions/simple-python-fanout.yaml

@@ -31,7 +31,7 @@ steps:
       value: "777"
   replicate:
     using:
-      input: inputFile
+      variable: inputFile
   variable-mapping:
   - variable: inputFile
     from-step:

workflow/decoder.py

@@ -200,9 +200,9 @@ def set_step_variables(
     return result
 
 
-def get_step_replication_param(*, step: dict[str, Any]) -> str | Any:
+def get_step_replicator(*, step: dict[str, Any]) -> str | Any:
     """Return step's replication info"""
-    replicator = step.get("replicate", None)
+    replicator = step.get("replicate")
     if replicator:
         # 'using' is a dict but there can be only single value for now
         replicator = list(replicator["using"].values())[0]

workflow/workflow-schema.yaml

@@ -60,15 +60,15 @@ definitions:
     pattern: ^[a-zA-Z_][a-zA-Z0-9_]*$
 
   # A step replication control variable
-  # that is based on a step input variable
-  replicate-using-input:
+  # that is based on a step variable
+  replicate-using-variable:
     type: object
     additionalProperties: false
     properties:
-      input:
+      variable:
         $ref: '#/definitions/variable-name'
     required:
-    - input
+    - variable
 
   # A Step variable
   # (whose value is derived from a variable used in a prior step)
@@ -174,7 +174,7 @@ definitions:
         additionalProperties: false
         properties:
           using:
-            $ref: '#/definitions/replicate-using-input'
+            $ref: '#/definitions/replicate-using-variable'
       variable-mapping:
         # The map of the source of the step's variables.
         # all variables the step needs (that aren;t already in the specification)

workflow/workflow_engine.py

@@ -42,7 +42,7 @@
 
 from .decoder import (
     get_step_input_variable_names,
-    get_step_replication_param,
+    get_step_replicator,
     set_step_variables,
     workflow_step_has_outputs,
 )
@@ -595,7 +595,7 @@ def _launch(
         variables: dict[str, Any] = error_or_variables
         print("variables", variables)
         # find out if and by which parameter this step should be replicated
-        replicator = get_step_replication_param(step=step)
+        replicator = get_step_replicator(step=step)
 
         _LOGGER.info(
             "Launching step: RunningWorkflow=%s RunningWorkflowStep=%s step=%s"

workflow/workflow_validator.py

@@ -118,7 +118,7 @@ def _validate_tag_level(
             if (
                 replicate_using_input := step.get("replicate", {})
                 .get("using", {})
-                .get("input")
+                .get("variable")
             ):
                 step_name = step["name"]
                 if replicate_using_input not in get_step_input_variable_names(