feat: Adjust realise_outputs

Author: Alan Christie

tests/test_test_api_adapter.py

@@ -441,3 +441,17 @@ def test_get_running_workflow_step_by_name():
     assert response["running_workflow"]["id"] == rwf_id
     assert response["name"] == "step-2"
     assert response["id"] == rwfs_id
+
+
+def test_basic_realise():
+    # Arrange
+    utaa = UnitTestWorkflowAPIAdapter()
+
+    # Act
+    response, _ = utaa.realise_outputs(
+        running_workflow_step_id="r-workflow-step-00000000-0000-0000-0000-000000000001",
+        outputs=["a.txt"],
+    )
+
+    # Assert
+    assert not response

tests/wapi_adapter.py

@@ -381,8 +381,8 @@ def get_running_workflow_steps(self, *, running_workflow_id: str) -> dict[str, A
         return {"count": len(steps), "running_workflow_steps": steps}
 
     def realise_outputs(
-        self, *, running_workflow_step_id: str, variables: dict[str, str]
+        self, *, running_workflow_step_id: str, outputs: list[str, str]
     ) -> tuple[dict[str, Any], int]:
         del running_workflow_step_id
-        del variables
+        del outputs
         return {}, 0

workflow/workflow_abc.py

@@ -343,12 +343,11 @@ def get_job(
 
     @abstractmethod
     def realise_outputs(
-        self, *, running_workflow_step_id: str, outputs: list[tuple[str, str]]
+        self, *, running_workflow_step_id: str, outputs: list[str]
     ) -> tuple[dict[str, Any], int]:
-        """Copy (link) the step's files as outputs into the Project directory,
-        while also renaming the file. A step ID is provided, along with a list of
-        outputs (files in the instance directory) and the required counterpart file
-        in the Project directory."""
+        """Copy (link) the step's files as outputs into the Project directory.
+        A step ID is provided, along with a list of outputs
+        (files that will be in the step's instance directory)."""
         # Should return an empty map or:
         # {
         #   "error": "<error message>",