[TxFeePayment] fee payment by first authorizer : if transaction fee payer is not specified on transaction message, first authorizer of a transaction is implicitly set as transaction fee payer account [cherry-picked da05af1]

Author: bezalel

infrablockchain-bios/local_testnet_boot_bios_infrablockchain.sh

@@ -265,7 +265,7 @@ $INFRA_CLI push action ${SYS_ACCOUNT} settxfee "{\"code\":\"${SYS_ACCOUNT}\",\"a
 $INFRA_CLI get txfee list -L "${SYS_ACCOUNT}" -U "${SYS_ACCOUNT}"
 $INFRA_CLI push action ${SYS_ACCOUNT} unsettxfee "{\"code\":\"${SYS_ACCOUNT}\",\"action\":\"linkauth\"}" -p ${SYS_ACCOUNT}@active --txfee-payer ${SYS_ACCOUNT}
 $INFRA_CLI get txfee list -L "${SYS_ACCOUNT}" -U "${SYS_ACCOUNT}"
-$INFRA_CLI push action ${SYS_ACCOUNT} settxfee "{\"code\":\"${SYS_ACCOUNT}\",\"action\":\"linkauth\",\"value\":1000,\"feetype\":1}" -p ${SYS_ACCOUNT}@active --txfee-payer ${SYS_ACCOUNT}
+$INFRA_CLI push action ${SYS_ACCOUNT} settxfee "{\"code\":\"${SYS_ACCOUNT}\",\"action\":\"linkauth\",\"value\":1500,\"feetype\":1}" -p ${SYS_ACCOUNT}@active --txfee-payer ${SYS_ACCOUNT}
 
 sleep 1
 
@@ -512,6 +512,9 @@ $INFRA_CLI get token balance systoken.a useraccountc
 
 $INFRA_CLI push action systoken.a transfer '{"t":"systoken.a","from":"useraccounta","to":"useraccountb","qty":"999.5000 DUSD","tag":"transfer tag"}' -p useraccounta@active --txfee-payer useraccounta -v producer.a
 
+# first authorizer as tx fee payer
+$INFRA_CLI push action systoken.a transfer '{"t":"systoken.a","from":"useraccounta","to":"useraccountb","qty":"0.1000 DUSD","tag":"transfer tag"}' -p useraccounta@active -v producer.a
+
 $INFRA_CLI get systoken balance useraccounta
 $INFRA_CLI get systoken balance useraccountb
 $INFRA_CLI get systoken balance useraccountc

libraries/chain/transaction_context.cpp

@@ -215,13 +215,11 @@ namespace eosio { namespace chain {
             const auto& tx_fee_payer_info = itr->second.get<transaction_fee_payer_tx_ext>();
             tx_fee_payer = tx_fee_payer_info.fee_payer;
          }
-         //if (!tx_fee_payer) {
-         //   // if tx-fee-payer is not specified on transaction message, then 'bill-first-authorizer' policy is used
-         //   tx_fee_payer = trx.first_authorizer();
-         //}
-         if (tx_fee_payer) {
-            bill_to_accounts.insert(*tx_fee_payer);
+         if (!tx_fee_payer) {
+            // if tx-fee-payer is not specified on transaction message, then 'bill-first-authorizer' policy is used
+            tx_fee_payer = trx.first_authorizer();
          }
+         bill_to_accounts.insert(*tx_fee_payer);
 
          ////////////////////////////////////////////////////////////////
          /// InfraBlockchain Transaction-Extension support for Transaction-as-a-vote and Proof-of-Transaction