chore: streamManagerV2 remove getStats function - canary

Author: ThomasRalee

packages/sdk-ts/src/client/indexer/grpc_stream/index.ts

@@ -27,5 +27,5 @@ export * from './streamV2/IndexerGrpcExplorerStreamV2.js'
 export * from './streamV2/IndexerGrpcDerivativesStreamV2.js'
 export * from './streamV2/IndexerGrpcAccountPortfolioStreamV2.js'
 
-export * from './streamV2/StreamManager.js'
+export * from './streamV2/StreamManagerV2.js'
 export * from './streamV2/streamHelpersV2.js'

…pc_stream/streamV2/StreamManager.spec.ts …_stream/streamV2/StreamManagerV2.spec.tspackages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManager.spec.ts renamed to packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManagerV2.spec.ts packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManager.spec.ts renamed to packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManagerV2.spec.ts

@@ -1,6 +1,6 @@
 import { Network, getNetworkEndpoints } from '@injectivelabs/networks'
 import { it, vi, expect, describe, afterEach, beforeEach } from 'vitest'
-import { StreamManagerV2 } from './StreamManager.js'
+import { StreamManagerV2 } from './StreamManagerV2.js'
 import { StreamState, StreamDisconnectReason } from '../../../../types/index.js'
 import { IndexerGrpcDerivativesStreamV2 } from './IndexerGrpcDerivativesStreamV2.js'
 import type { Mock } from 'vitest'
@@ -52,14 +52,6 @@ describe('StreamManagerV2', () => {
 
       expect(manager.getId()).toBe('test-stream')
       expect(manager.getState()).toBe(StreamState.Idle)
-
-      const stats = manager.getStats()
-      expect(stats.state).toBe(StreamState.Idle)
-      expect(stats.connectCount).toBe(0)
-      expect(stats.disconnectCount).toBe(0)
-      expect(stats.retryCount).toBe(0)
-      expect(stats.dataReceivedCount).toBe(0)
-      expect(stats.errorCount).toBe(0)
     })
   })
 
@@ -294,7 +286,7 @@ describe('StreamManagerV2', () => {
       expect(connectEvents).toHaveLength(1)
       expect(connectEvents[0]).toEqual({
         isReconnect: false,
-        attempt: 1,
+        attempt: 0,
       })
     })
 
@@ -526,73 +518,6 @@ describe('StreamManagerV2', () => {
     })
   })
 
-  describe('statistics', () => {
-    it('should track connection statistics', () => {
-      const manager = new StreamManagerV2({
-        id: 'test-stream',
-        streamFactory,
-        onData: onDataCallback,
-      })
-
-      manager.start()
-      manager.stop()
-
-      const stats = manager.getStats()
-      expect(stats.connectCount).toBe(1)
-      expect(stats.disconnectCount).toBe(1)
-      expect(stats.connectedAt).toBeTruthy()
-      expect(stats.disconnectedAt).toBeTruthy()
-    })
-
-    it('should track data statistics', () => {
-      const manager = new StreamManagerV2({
-        id: 'test-stream',
-        streamFactory,
-        onData: onDataCallback,
-      })
-
-      manager.start()
-
-      // Simulate multiple data events using proper emit pattern
-      manager.emit('data', 'data1')
-      manager.emit('data', 'data2')
-      manager.emit('data', 'data3')
-
-      const stats = manager.getStats()
-      expect(stats.dataReceivedCount).toBe(3)
-      expect(stats.lastDataAt).toBeTruthy()
-      expect(onDataCallback).toHaveBeenCalledTimes(3)
-    })
-
-    it('should track retry statistics', () => {
-      const manager = new StreamManagerV2({
-        id: 'test-stream',
-        streamFactory,
-        onData: onDataCallback,
-        retryConfig: {
-          enabled: true,
-          maxAttempts: 2,
-          initialDelayMs: 100,
-          maxDelayMs: 1000,
-          backoffMultiplier: 2,
-          persistent: false,
-        },
-      })
-
-      // Fail first attempt
-      vi.mocked(streamFactory).mockImplementationOnce(() => {
-        throw new Error('First failure')
-      })
-
-      manager.start()
-      vi.advanceTimersByTime(100) // Trigger retry
-
-      const stats = manager.getStats()
-      expect(stats.retryCount).toBe(1)
-      expect(stats.errorCount).toBe(1)
-    })
-  })
-
   describe('edge cases', () => {
     it('should handle multiple start calls gracefully', () => {
       const manager = new StreamManagerV2({
@@ -721,15 +646,9 @@ describe('StreamManagerV2', () => {
       expect(manager.getState()).toBe(StreamState.Connected)
       expect(connectEvents).toHaveLength(1)
 
-      const stats = manager.getStats()
-      expect(stats.connectCount).toBe(1)
-      expect(stats.connectedAt).toBeTruthy()
-
       // Data may or may not be received depending on market activity
       if (result === 'data') {
         expect(dataReceived.length).toBeGreaterThan(0)
-        expect(stats.dataReceivedCount).toBeGreaterThan(0)
-        expect(stats.lastDataAt).toBeTruthy()
       }
 
       manager.stop()
@@ -794,63 +713,6 @@ describe('StreamManagerV2', () => {
       expect(disconnectEvents[0].willRetry).toBe(false)
     }, 10000)
 
-    it('should track statistics correctly with real stream', async () => {
-      const endpoints = getNetworkEndpoints(Network.MainnetSentry)
-      const derivativesStream = new IndexerGrpcDerivativesStreamV2(
-        endpoints.indexer,
-      )
-
-      let dataCount = 0
-
-      const manager = new StreamManagerV2({
-        id: 'stats-test-stream',
-        streamFactory: () =>
-          derivativesStream.streamMarkets({
-            callback: (response) => {
-              manager.emit('data', response)
-            },
-          }),
-        onData: () => {
-          dataCount++
-        },
-        retryConfig: {
-          enabled: false,
-        },
-      })
-
-      manager.start()
-
-      // Wait for connection
-      await new Promise((resolve) => {
-        const timeout = setTimeout(resolve, 3000)
-        manager.on('connect', () => {
-          clearTimeout(timeout)
-          resolve('connected')
-        })
-      })
-
-      const stats = manager.getStats()
-
-      // Connection stats should always be present
-      expect(stats.connectCount).toBe(1)
-      expect(stats.disconnectCount).toBe(0)
-      expect(stats.errorCount).toBe(0)
-      expect(stats.retryCount).toBe(0)
-      expect(stats.connectedAt).toBeTruthy()
-
-      // Data stats depend on whether market is active
-      if (stats.dataReceivedCount > 0) {
-        expect(dataCount).toBe(stats.dataReceivedCount)
-        expect(stats.lastDataAt).toBeTruthy()
-      }
-
-      manager.stop()
-
-      const finalStats = manager.getStats()
-      expect(finalStats.disconnectCount).toBe(1)
-      expect(finalStats.disconnectedAt).toBeTruthy()
-    }, 8000)
-
     it('should handle destroy() cleanup properly', async () => {
       const endpoints = getNetworkEndpoints(Network.MainnetSentry)
       const derivativesStream = new IndexerGrpcDerivativesStreamV2(

…er/grpc_stream/streamV2/StreamManager.ts …/grpc_stream/streamV2/StreamManagerV2.tspackages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManager.ts renamed to packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManagerV2.ts packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManager.ts renamed to packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/StreamManagerV2.ts

@@ -5,7 +5,6 @@ import {
   StreamDisconnectReason,
 } from '../../../../types/index.js'
 import type {
-  StreamStats,
   StreamError,
   StreamSubscription,
   StreamManagerConfig,
@@ -44,7 +43,6 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
   private state: StreamState = StreamState.Idle
   private subscription: StreamSubscription | null = null
   private retryTimeoutId: NodeJS.Timeout | null = null
-  private stats: StreamStats
   private retryAttempt: number = 0
 
   constructor(config: StreamManagerConfig<TResponse>) {
@@ -57,20 +55,6 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
       retryConfig: { ...DEFAULT_RETRY_CONFIG, ...config.retryConfig },
     }
 
-    // Initialize stream statistics
-    this.stats = {
-      state: StreamState.Idle,
-      connectCount: 0,
-      disconnectCount: 0,
-      retryCount: 0,
-      dataReceivedCount: 0,
-      errorCount: 0,
-      lastDataAt: null,
-      createdAt: Date.now(),
-      connectedAt: null,
-      disconnectedAt: null,
-    }
-
     // Override emit to intercept 'data' events for stats tracking and user callback
     const originalEmit = this.emit.bind(this)
 
@@ -104,14 +88,6 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
     return this.config.id
   }
 
-  public getState(): StreamState {
-    return this.state
-  }
-
-  public getStats(): StreamStats {
-    return { ...this.stats, state: this.state }
-  }
-
   /**
    * Destroy the stream manager and clean up all resources
    * Call this when the stream manager is no longer needed
@@ -121,11 +97,14 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
     this.removeAllListeners()
   }
 
+  public getState(): StreamState {
+    return this.state
+  }
+
   private updateState(newState: StreamState): void {
     const oldState = this.state
 
     this.state = newState
-    this.stats.state = newState
 
     this.emit(StreamEvent.StateChange, { from: oldState, to: newState })
   }
@@ -180,7 +159,6 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
 
     this.retryTimeoutId = setTimeout(() => {
       this.retryAttempt++
-      this.stats.retryCount++
 
       this.emit(StreamEvent.Retry, {
         attempt: this.retryAttempt,
@@ -202,7 +180,6 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
   private handleError(error: Error | StreamError | any): void {
     const errorInfo = this.extractErrorInfo(error)
 
-    this.stats.errorCount++
     this.emit(StreamEvent.Error, errorInfo)
 
     // Map gRPC error code to appropriate disconnect reason
@@ -229,13 +206,10 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
   }
 
   /**
-   * Handles incoming data - tracks stats and calls user callback
+   * Handles incoming data - calls user callback
    * Called automatically when user emits 'data' event from streamFactory callback
    */
   private handleData(response: TResponse): void {
-    this.stats.dataReceivedCount++
-    this.stats.lastDataAt = Date.now()
-
     try {
       this.config.onData(response)
     } catch (error) {
@@ -246,22 +220,17 @@ export class StreamManagerV2<TResponse> extends EventEmitter<
   private handleConnected(isReconnect: boolean): void {
     this.updateState(StreamState.Connected)
     this.retryAttempt = 0
-    this.stats.connectCount++
-    this.stats.connectedAt = Date.now()
 
     this.emit(StreamEvent.Connect, {
       isReconnect,
-      attempt: this.stats.connectCount,
+      attempt: 0,
     })
   }
 
   private handleDisconnect(reason: StreamDisconnectReason): void {
     this.clearSubscription()
     this.clearRetryTimeout()
 
-    this.stats.disconnectCount++
-    this.stats.disconnectedAt = Date.now()
-
     // Determine if retry should be attempted based on disconnect reason
     const willRetry =
       reason !== StreamDisconnectReason.UserStopped &&

packages/sdk-ts/src/types/stream.ts

@@ -187,19 +187,3 @@ export interface StreamManagerEvents<TResponse> {
     message: string
   }
 }
-
-/**
- * Stream statistics
- */
-export interface StreamStats {
-  state: StreamState
-  connectCount: number
-  disconnectCount: number
-  retryCount: number
-  dataReceivedCount: number
-  errorCount: number
-  lastDataAt: number | null
-  createdAt: number
-  connectedAt: number | null
-  disconnectedAt: number | null
-}

packages/ts-types/src/common.ts

@@ -1,3 +1,28 @@
+/**
+ * @deprecated Use StreamStatusResponse from @injectivelabs/sdk-ts/types instead
+ */
+export interface StreamStatusResponse {
+  details: string
+  code: number
+  metadata: any
+}
+
+/**
+ * @deprecated Use StreamOperation from @injectivelabs/sdk-ts/types instead
+ */
+export const StreamOperation = {
+  Insert: 'insert',
+  Delete: 'delete',
+  Replace: 'replace',
+  Update: 'update',
+  Invalidate: 'invalidate',
+} as const
+
+/**
+ * @deprecated Use StreamOperation from @injectivelabs/sdk-ts/types instead
+ */
+export type StreamOperation =
+  (typeof StreamOperation)[keyof typeof StreamOperation]
 export interface PaginationOption {
   key: string
   offset?: number