Skip to content

Commit 37ae922

Browse files
committed
chore: updates as per PR review/feedbacks
1 parent 7941b59 commit 37ae922

File tree

7 files changed

+6
-41
lines changed

7 files changed

+6
-41
lines changed

packages/sdk-ts/src/client/indexer/ws/GrpcWebSocketTransport.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import type {
1919
*
2020
* Handles:
2121
* - WebSocket connection lifecycle
22-
* - Automatic ping/pong to keep connection alive
2322
* - Reconnection with exponential backoff
2423
* - State management
2524
* - Binary message framing
@@ -30,7 +29,6 @@ export class GrpcWebSocketTransport {
3029
private config: ResolvedWsTransportConfig
3130
private ws: IsomorphicWebSocket | null = null
3231
private state: WsState = WsState.Idle
33-
private pingInterval: ReturnType<typeof setInterval> | null = null
3432
private connectionTimeout: ReturnType<typeof setTimeout> | null = null
3533
private reconnectTimeout: ReturnType<typeof setTimeout> | null = null
3634
private reconnectAttempts = 0
@@ -203,8 +201,6 @@ export class GrpcWebSocketTransport {
203201
const isReconnect = this.hasConnectedOnce
204202
this.hasConnectedOnce = true
205203

206-
this.startPingInterval()
207-
208204
this.emit('connect', { isReconnect })
209205
resolve()
210206
}
@@ -213,8 +209,6 @@ export class GrpcWebSocketTransport {
213209
event: CloseEvent | { code: number; reason: string },
214210
reject?: (error: Error) => void,
215211
): void {
216-
this.clearPingInterval()
217-
218212
// Handle close during connection attempt
219213
if (this.state === WsState.Connecting) {
220214
this.clearConnectionTimeout()
@@ -287,26 +281,6 @@ export class GrpcWebSocketTransport {
287281
}
288282
}
289283

290-
private startPingInterval(): void {
291-
this.clearPingInterval()
292-
293-
this.pingInterval = setInterval(() => {
294-
if (this.isConnected()) {
295-
// Send an empty ping frame - the actual ping message should be
296-
// handled by the higher-level stream classes using the codec
297-
// This is just to keep the connection alive at the transport level
298-
// The stream classes will handle the gRPC-level ping/pong
299-
}
300-
}, this.config.pingIntervalMs)
301-
}
302-
303-
private clearPingInterval(): void {
304-
if (this.pingInterval) {
305-
clearInterval(this.pingInterval)
306-
this.pingInterval = null
307-
}
308-
}
309-
310284
private clearConnectionTimeout(): void {
311285
if (this.connectionTimeout) {
312286
clearTimeout(this.connectionTimeout)
@@ -381,7 +355,6 @@ export class GrpcWebSocketTransport {
381355

382356
private cleanup(reason: WsDisconnectReason, willRetry: boolean): void {
383357
this.clearConnectionTimeout()
384-
this.clearPingInterval()
385358
this.clearReconnectTimeout()
386359

387360
if (this.ws) {
@@ -421,8 +394,6 @@ export class GrpcWebSocketTransport {
421394
return {
422395
url: config.url,
423396
protocol: config.protocol ?? DEFAULT_TRANSPORT_CONFIG.protocol,
424-
pingIntervalMs:
425-
config.pingIntervalMs ?? DEFAULT_TRANSPORT_CONFIG.pingIntervalMs,
426397
connectionTimeoutMs:
427398
config.connectionTimeoutMs ??
428399
DEFAULT_TRANSPORT_CONFIG.connectionTimeoutMs,

packages/sdk-ts/src/client/indexer/ws/rfq/IndexerWsMakerStream.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export class IndexerWsMakerStream {
3535

3636
this.transport = new GrpcWebSocketTransport({
3737
url: fullUrl,
38-
pingIntervalMs: this.pingIntervalMs,
3938
connectionTimeoutMs: config.connectionTimeoutMs,
4039
reconnect: config.reconnect,
4140
metadata: {

packages/sdk-ts/src/client/indexer/ws/rfq/IndexerWsTakerStream.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export class IndexerWsTakerStream {
3535

3636
this.transport = new GrpcWebSocketTransport({
3737
url: fullUrl,
38-
pingIntervalMs: this.pingIntervalMs,
3938
connectionTimeoutMs: config.connectionTimeoutMs,
4039
reconnect: config.reconnect,
4140
metadata: {

packages/sdk-ts/src/client/indexer/ws/types.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ export interface WsTransportConfig {
6363
url: string
6464
/** WebSocket subprotocol (default: 'grpc-ws') */
6565
protocol?: string
66-
/** Ping interval in milliseconds (default: 1000) */
67-
pingIntervalMs?: number
6866
/** Connection timeout in milliseconds (default: 10000) */
6967
connectionTimeoutMs?: number
7068
/** Reconnection configuration */
@@ -79,7 +77,6 @@ export interface WsTransportConfig {
7977
export interface ResolvedWsTransportConfig {
8078
url: string
8179
protocol: string
82-
pingIntervalMs: number
8380
connectionTimeoutMs: number
8481
reconnect: WsReconnectConfig
8582
metadata?: Record<string, string>
@@ -101,7 +98,6 @@ export const DEFAULT_RECONNECT_CONFIG: WsReconnectConfig = {
10198
*/
10299
export const DEFAULT_TRANSPORT_CONFIG = {
103100
protocol: 'grpc-ws',
104-
pingIntervalMs: 1000, // 1 second (server timeout is 2 seconds)
105101
connectionTimeoutMs: 10000, // 10 seconds
106102
}
107103

protoV2/indexer/src/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export { InjectivePortfolioRPCClient } from './generated/injective_portfolio_rpc
1616
export { InjectiveReferralRPCClient } from './generated/injective_referral_rpc_pb.client.js'
1717
export { InjectiveSpotExchangeRPCClient } from './generated/injective_spot_exchange_rpc_pb.client.js'
1818
export { InjectiveTradingRPCClient } from './generated/injective_trading_rpc_pb.client.js'
19-
export { InjectiveRfqRPCClient } from './generated/injective_rfq_rpc_pb.client.js'
19+
export { InjectiveRFQRPCClient } from './generated/injective_rfqrpc_pb.client.js'
2020

2121
export * as EventProviderApiPb from './generated/event_provider_api_pb.js'
2222
export * as HealthPb from './generated/health_pb.js'
@@ -36,4 +36,4 @@ export * as InjectivePortfolioRpcPb from './generated/injective_portfolio_rpc_pb
3636
export * as InjectiveReferralRpcPb from './generated/injective_referral_rpc_pb.js'
3737
export * as InjectiveSpotExchangeRpcPb from './generated/injective_spot_exchange_rpc_pb.js'
3838
export * as InjectiveTradingRpcPb from './generated/injective_trading_rpc_pb.js'
39-
export * as InjectiveRfqRpcPb from './generated/injective_rfq_rpc_pb.js'
39+
export * as InjectiveRFQRpcPb from './generated/injective_rfqrpc_pb.js'

protoV2/indexer/src/index.template.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export { InjectivePortfolioRPCClient } from './generated/injective_portfolio_rpc
1919
export { InjectiveReferralRPCClient } from './generated/injective_referral_rpc_pb.client.js'
2020
export { InjectiveSpotExchangeRPCClient } from './generated/injective_spot_exchange_rpc_pb.client.js'
2121
export { InjectiveTradingRPCClient } from './generated/injective_trading_rpc_pb.client.js'
22-
export { InjectiveRfqRPCClient } from './generated/injective_rfq_rpc_pb.client.js'
22+
export { InjectiveRFQRPCClient } from './generated/injective_rfqrpc_pb.client.js'
2323

2424
// Export all types as namespaces for easy import
2525
export * as EventProviderApiPb from './generated/event_provider_api_pb.js'
@@ -40,4 +40,4 @@ export * as InjectivePortfolioRpcPb from './generated/injective_portfolio_rpc_pb
4040
export * as InjectiveReferralRpcPb from './generated/injective_referral_rpc_pb.js'
4141
export * as InjectiveSpotExchangeRpcPb from './generated/injective_spot_exchange_rpc_pb.js'
4242
export * as InjectiveTradingRpcPb from './generated/injective_trading_rpc_pb.js'
43-
export * as InjectiveRfqRpcPb from './generated/injective_rfq_rpc_pb.js'
43+
export * as InjectiveRFQRpcPb from './generated/injective_rfqrpc_pb.js'

protoV2/indexer/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export { InjectivePortfolioRPCClient } from './generated/injective_portfolio_rpc
1919
export { InjectiveReferralRPCClient } from './generated/injective_referral_rpc_pb.client.js'
2020
export { InjectiveSpotExchangeRPCClient } from './generated/injective_spot_exchange_rpc_pb.client.js'
2121
export { InjectiveTradingRPCClient } from './generated/injective_trading_rpc_pb.client.js'
22-
export { InjectiveRfqRPCClient } from './generated/injective_rfq_rpc_pb.client.js'
22+
export { InjectiveRFQRPCClient } from './generated/injective_rfqrpc_pb.client.js'
2323

2424
// Export all types as namespaces for easy import
2525
export * as EventProviderApiPb from './generated/event_provider_api_pb.js'
@@ -40,4 +40,4 @@ export * as InjectivePortfolioRpcPb from './generated/injective_portfolio_rpc_pb
4040
export * as InjectiveReferralRpcPb from './generated/injective_referral_rpc_pb.js'
4141
export * as InjectiveSpotExchangeRpcPb from './generated/injective_spot_exchange_rpc_pb.js'
4242
export * as InjectiveTradingRpcPb from './generated/injective_trading_rpc_pb.js'
43-
export * as InjectiveRfqRpcPb from './generated/injective_rfq_rpc_pb.js'
43+
export * as InjectiveRFQRpcPb from './generated/injective_rfqrpc_pb.js'

0 commit comments

Comments
 (0)