packages/injective-test-tube/libinjectivetesttube/go.mod (1)

3-3: Invalid Go version directive in go.mod.

The go directive must be major.minor (e.g., 1.23). 1.23.9 is invalid and will break go tooling.

Apply this diff:

-go 1.23.9
+go 1.23

.github/workflows/unit_test.yml (3)

31-56: Add broader clippy coverage for workspace, targets, and features.

To lint everything consistently (including examples, benches, build scripts, all features), expand clippy args.

Apply this diff:

       - name: Run cargo clippy
         uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: --tests -- -D warnings
+          args: --workspace --all-targets --all-features --tests -- -D warnings

---

3-7: Run workflow on PR updates, not only when opened.

pull_request.types is limited to opened, so pushes to an existing PR won’t trigger CI. Include reopened and synchronize to cover updates.

Apply this diff:

 on:
   push:
   pull_request:
-    types: [opened]
+    types: [opened, reopened, synchronize]

---

56-56: Add newline at end of file.

YAML lint flags missing newline at EOF.

Please add a newline at the end of the file to satisfy linters.

packages/injective-test-tube/src/module/auction.rs (3)

87-127: Prevent potential underflow in time arithmetic (future-proofing).

You assert closing_time > block_time_sec, which is good. To make the increment robust even if assumptions change, use saturating ops.

Apply this diff:

-        app.increase_time(1);
+        app.increase_time(1);

         let basket_response_after_increase = auction
             .query_current_auction_basket(&QueryCurrentAuctionBasketRequest {})
             .expect("query_current_auction_basket should succeed (after)");

         assert_eq!(
             basket_response_after_increase.auction_round, round,
             "Round should not change"
         );

         assert_eq!(
             basket_response_after_increase.auction_closing_time,
             closing_time,
         );

-        app.increase_time(closing_time - block_time_sec + 1);
+        app.increase_time(closing_time.saturating_sub(block_time_sec).saturating_add(1));

---

99-102: Avoid println in tests (keep CI logs clean).

Unless needed for debugging, remove println! to reduce noise.

Apply this diff:

-        println!(
-            "[check] round={}, closing_time={}, highest_bidder={}, highest_bid_amount={}",
-            round, closing_time, highest_bidder, highest_bid
-        );

Note: If you remove this, also remove the temporary variables that are only used for printing:

-        let highest_bid = basket_res.highest_bid_amount.clone();
-        let highest_bidder = basket_res.highest_bidder.clone();

---

134-137: Stronger assertion: expect exactly one round increment.

If the auction period is fixed and you jump just past the closing time, the round should increment by 1, not just “be greater.”

Apply this diff:

-        assert!(
-            basket_response_after_increase.auction_round > round,
-            "Round should increase"
-        );
+        assert_eq!(
+            basket_response_after_increase.auction_round,
+            round + 1,
+            "Round should increase exactly by 1"
+        );

packages/test-tube/Cargo.toml (2)

12-12: Prefer workspace-managed dependency for ed25519-zebra to avoid drift.

You already declare ed25519-zebra in [workspace.dependencies] (with features = ["alloc"]). To keep consistency and avoid accidental version/feature drift, switch this crate to use the workspace-managed dependency.

Apply this diff here:

-ed25519-zebra = { version = "4.1.0", features = ["alloc"] }
+ed25519-zebra = { workspace = true }

---

15-15: Consider trimming cosmwasm-std feature set if not all are required.

Enabling multiple compatibility features ("cosmwasm_1_2", "1_3", "1_4", "2_0") plus "stargate" and "iterator" can inflate compile time and binary size. If tests don’t require older compatibility layers, narrow the set to the minimum needed.

packages/injective-test-tube/Cargo.toml (2)

14-14: Optionally reduce cosmwasm-std features.

If your tests do not span older CosmWasm compatibility, consider disabling unneeded "cosmwasm_1_x" features to reduce compilation and linkage overhead.

---

19-19: serde_json bump is fine; consider centralizing in workspace.

To avoid version skew across member crates, you can manage serde_json in [workspace.dependencies] and reference it via workspace = true.

Example change here:

-serde_json         = "1.0.140"
+serde_json         = { workspace = true }

And in the workspace Cargo.toml:

[workspace.dependencies]
serde_json = "1.0.140"

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.