Skip to content

Commit b16b234

Browse files
rrrutledgespier
andauthored
Fix Vale typos (#592)
* Update outline.md for typos * Update video-proposal.asciidoc typo * Update 03-major-benefits-are-built-into-the-innersource-process-article.asciidoc * Update 04-new-roles-and-responsibilities-article.asciidoc * Update outline.md * Update 01-introduction.asciidoc * Toggle ISC.InnerSource rule temporarily, to not alert on "Inner__Source__" --------- Co-authored-by: Sebastian Spier <[email protected]>
1 parent 02fa7c0 commit b16b234

File tree

7 files changed

+13
-9
lines changed

7 files changed

+13
-9
lines changed

contributor/02-becoming-a-contributor-article.asciidoc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,12 @@ A good Contributor can comfortably make a call for when it makes both technical
2828

2929
=== Scope of InnerSource contributions
3030

31+
pass:[<!-- vale ISC.InnerSource = NO -->]
32+
3133
So is Inner__Source__ only about __Source__Code? Of course not. If your team's business depends on an outside component, you want to make sure it's well maintained and well run. As an InnerSource Contributor, you can help the host team in multiple ways. Reporting issues you see when using the component is a valuable contribution. Creating or fixing test cases that show that the code isn't working as expected is valuable. So is improving documentation, so others spend less time using it and contributing to it. Supporting other users, helping with bug triage can be valuable contributions. Improving builds is another example of a valuable contribution.
3234

35+
pass:[<!-- vale ISC.InnerSource = YES -->]
36+
3337
To summarize no contribution is too small to contribute. Here is one that I made
3438
to https://github.com/tensorflow/models/pull/4784[tensorflow/models]. A simple label change in a graph.
3539

contributor/video-proposal.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ This section teaches the mindset, the habits, technical approaches and other det
3636
==== This video is for you because...
3737

3838
* You are a possible future Contributor to an InnerSource project and want to know what to expect
39-
* You are a host team member looking to open your work for outside contributors / inner sourcing and want to be prepared to know what being a contributor may be like
39+
* You are a host team member looking to open your work for outside contributors / InnerSource contributions and want to be prepared to know what being a contributor may be like
4040
* You are a product owner looking to support your TC or a (line) manager and want to know how the InnerSource approach is meant to work.
4141

4242
==== Prerequisites

product-owner/03-major-benefits-are-built-into-the-innersource-process-article.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ You can start to implement and plan more effectively.
1212
Often, your team's problem (or feature) may not be the highest priority for that other team.
1313
You no longer have to lean on escalations to upper management and politics to get access to that team.
1414
Instead, you have more power to determine priorities with your team and reduce your dependencies on others.
15-
Sometimes it may take longer because of the learning curves. But if it is a team that is a constant bottleneck, you can get those stories out of their backlog that've been sitting there for years.
15+
Sometimes it may take longer because of the learning curves. But if it is a team that is a constant bottleneck, you can get those stories out of their backlog that have been sitting there for years.
1616

1717
_Open planning_ - this is where everyone publishes their planning process in an open and standardized fashion.
1818
At PayPal, we have the UPE standard. It stands for Unified Product Experience.
@@ -25,7 +25,7 @@ Open planning allows for more effective negotiations between teams.
2525

2626
One of the things we work a lot on in InnerSource is _open documentation_.
2727
This includes the planning process, the standards, things of that nature.
28-
A key element of this is the findability and the fact that there's a certain amount of centralization, so that everybody knows where to go to find the documentation to figure out how to collaborate with you better.
28+
A key element of this is the discoverability and the fact that there's a certain amount of centralization, so that everybody knows where to go to find the documentation to figure out how to collaborate with you better.
2929

3030
It has a lot of benefits in regards to your success.
3131
Some of that is the open planning and the open standards, so that you can collaborate better.

product-owner/04-new-roles-and-responsibilities-article.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Once you start working with those other teams, and when you onboard new develope
3333
If your tool is one of those bottlenecks and is really important to them, they may even offer to help you do a lot of the heavy lifting in regards to the standards, because they want to integrate in with your product.
3434

3535
Lastly, internal marketing.
36-
There're some projects that everyone wants to contribute code to.
36+
There are some projects that everyone wants to contribute code to.
3737
Oftentimes, these projects are the bottlenecks.
3838
I find that people start working on InnerSource projects at first because they must get something into one of those bottleneck projects.
3939
So they can progress their own projects forward. But what if you aren't one of those projects?

project-leader/outline.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Challenges with InnerSource and agile (these challenges form the basis for the r
4343
- Common fears (like losing control) and counter measures
4444
- Same phrase - different meaning: How issue trackers and code reviews are used differently in InnerSource projects than is common in the industry.
4545
- The impact of transparency: How InnerSource depends on trust, what to avoid to keep trust alive.
46-
- written first is not to avoid verbal communication or to move everything into DMs or long winded email threads
46+
- written first is not to avoid verbal communication or to move everything into direct messages or long winded email threads
4747

4848
InnerSource and capacity planning
4949

@@ -70,7 +70,7 @@ Options for shared ownership
7070
- Implications of each level on product management
7171
- Common hurdles (line management, performance review setups)
7272
- Advantages
73-
- Commons issues wrt. operations and solutions
73+
- Commons issues with respect to operations and solutions
7474

7575

7676
Relation to open source

trusted-committer/outline.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- Different ways to become TC
88
- TC lifecycle (bringing on successors, sunsetting)
99
- Useful skills/attitude/emotional maturity
10-
- TC antipatterns
10+
- TC anti-patterns
1111
- Why is the TC role important for IS success
1212

1313
## Target Audience
@@ -26,7 +26,7 @@
2626
- Contributor/Guest
2727
- Responsible for "fitting in"/conforming to the host team and it's
2828
expectations/processes.
29-
- Product Owner (distinction btw. Guest and Host PO)
29+
- Product Owner (distinction between Guest and Host PO)
3030
- TC
3131
- TC has rights to push code closer to production than a contributor
3232
- also known as _Host_

workbook/01-introduction.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ More than one answer may be correct in some questions.
105105

106106
====== Correct answer: 1
107107

108-
Why 1 is correct: The host teams open their code base to others and put effort into vetting contributions precisely because their code end up better and more featureful than if they did all the coding themselves.
108+
Why 1 is correct: The host teams open their code base to others and put effort into vetting contributions precisely because their code end up better and with more features than if they did all the coding themselves.
109109

110110
Why 2 is incorrect: InnerSource has no impact on the definition of requirements and priorities. As with any professional software development, developers have to understand their users.
111111

0 commit comments

Comments
 (0)