Skip to content

Commit 3c8492c

Browse files
author
Nick Yeates
authored
Merge pull request #54 from paypal/contributing-revamp
README lists patterns MUCH better
2 parents d253cee + 7ba3f17 commit 3c8492c

File tree

3 files changed

+22
-32
lines changed

3 files changed

+22
-32
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Select one of the following ways to contribute, to learn our workflow:
1818

1919
# A. Writing a New Pattern
2020

21-
The below steps can be used to create a new `donut`, `idea`, or complete pattern. The use-case here is that you have a relatively thought-out idea or problem in your head and can confidently fill out the barest of pattern fields (Solution doesn't need to be known). If you are unsure your idea is ready for this, [discuss it in an issue first](#discussing-early-ideas-in-issues).
21+
The below steps can be used to create a new `donut`, `idea`, or complete pattern. The use-case here is that you have a relatively thought-out idea or problem in your head and can confidently fill out the barest of pattern fields (Solution doesn't need to be known). If you are unsure your idea is ready for this, [discuss it in an issue first](#b-discussing-early-ideas-in-issues).
2222

2323
The simplest way to create a pattern is with your browser:
2424

@@ -27,7 +27,7 @@ The simplest way to create a pattern is with your browser:
2727
3. Name the file like this example: "project-management-time-pressures.md"
2828
4. Use the [pattern template](https://raw.githubusercontent.com/paypal/InnerSourcePatterns/master/meta/pattern-template.md) to create your new [markdown](/meta/markdown-info.md) file with the description of your _idea_, _donut_, or _pattern_
2929
5. Enter a commit message
30-
* If you are asked to 'Commit directly' vs 'Create a new branch', see [branching details](#use-branches-when-creating-new-patterns).
30+
* If you are asked to 'Commit directly' vs 'Create a new branch', see [branching details](#use-branches-when-creating-new-patterns) below.
3131
6. Propose this new file and then also create a Pull Request (PR)
3232

3333
Your done! This creates a separate branch and creates a Pull Request (PR) all in one fell swoop! PR's are the mechanism we use for our multi-step Review process. See next steps in [Interacting with Pattern Reviews](#c-interacting-with-patterns-reviews).
@@ -43,7 +43,7 @@ If you are asked to 'Commit directly...' vs 'Create a new branch...'
4343

4444
* Assure you select **'Create a new branch...'** and name the branch like this example: "pattern/project-management-time-pressures".
4545
* This occurs when writing a new pattern via the web interface (section A above).
46-
* Only [Trusted Collaborators](/meta/trusted_collaborators.md) (TC's) are asked this; we are adding most contributors as TC's.
46+
* Only [Trusted Collaborators](/meta/trusted-collaborators.md) (TC's) are asked this; we are adding most contributors as TC's.
4747

4848

4949

@@ -77,6 +77,6 @@ Below are the major steps in our Review process:
7777
2. Reviewers can now use the PR features to comment on the pattern.
7878
3. In case of required rework, the author should apply the labels `Ready for Additional Review` and/or `Revised` to indicate that a 2nd review is requested.
7979
4. After reviews are complete, the reviewers or author should remove the label `Ready for Review` and label the pattern `Accepted`.
80-
5. Once a pattern is `Accepted` by the reviewers, one of the [Trusted Collaborators](/meta/trusted_collaborators.md) (most authors are by this point) can Merge the PR on Github. This places the .md file into the master branch / root directory.
80+
5. Once a pattern is `Accepted` by the reviewers, one of the [Trusted Collaborators](/meta/trusted-collaborators.md) (most authors are by this point) can Merge the PR on Github. This places the .md file into the master branch / root directory.
8181

82-
When completed patterns (reviewed and accepted) are ready to be published from this InnerSourcePatterns repo to the InnerSourcePatterns Gitbook, [see our separate PUBLISHING.md instructions](/meta/publishing.md).
82+
When completed patterns (reviewed and accepted) are ready to be published from this InnerSourcePatterns repo to a Gitbook (PDF), [see our separate Publishing instructions](/meta/publishing.md).

README.md

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
This repository serves as the collection-point, ideation hub, and process behind the [InnerSource Commons'](http://innersourcecommons.com) set of proven and reviewed InnerSource approaches (patterns). These patterns illustrate beneficial activities and behaviors found in [organizations who apply InnerSource methodologies](http://paypal.github.io/InnerSourceCommons/getting-started/).
22

3-
What are Inner Source Patterns?
4-
===============================
3+
4+
# What are Inner Source Patterns?
55

66
Patterns are a way of describing a repeatable, proven solution to a problem with a context. They follow a simple form that helps people wanting to implement the solution to understand the constraints on the problem, the forces that must be balanced and the resulting context (the situation you are left with after the solution is applied). In inner sourcing, patterns can provide a way for the InnerSource Commons participants to concisely share information with each other, improving the practice of inner sourcing. Each of the patterns are divided into Title, Problem Statement, Context, Forces, and Solutions as their main sections.
77

@@ -10,16 +10,14 @@ Patterns are a way of describing a repeatable, proven solution to a problem with
1010
* [View our InnerSource Patterns Template](meta/pattern-template.md)
1111

1212

13-
How can you use Inner Source Patterns?
14-
======================================
13+
# How can you use Inner Source Patterns?
1514

1615
Patterns must be used in a thoughtful manner. They cannot be blindly applied. In most cases, you will need to adapt the given solution to your own situation; but the information given in the pattern, defining the context (immovable constraints) and forces (constraints that can be changed and balanced against each other), should help you do this.
1716

1817
The pattern form is useful for describing proven patterns but it could also be used for *brainstorming solutions* where patterns are not yet established, since the form gives a structured way for thinking about a problem. You could also create a *donut pattern* (filling in the problem, context, forces and resulting context fields but leaving the solution blank) as a way of asking the InnerSource Commons community for help (to find a proven solution or to brainstorm things to try).
1918

2019

21-
How to Contribute?
22-
==================
20+
# How to Contribute?
2321

2422
[See our CONTRIBUTING.md for details on getting involved](CONTRIBUTING.md)
2523

@@ -28,14 +26,15 @@ We encourage beginners seeking answers to jump in by creating ''donuts'' (proble
2826
We work together via Github, Webex, Slack, etc. Do not hesitate to join the [#innersourcecommons](https://isc-inviter.herokuapp.com/) or #innersource-patterns slack channels and ask to be included in the [patterns meetings](/meta/meetings.md) (there is an email list).
2927

3028

31-
Reviewed Patterns (proven and reviewed)
32-
=======================================
29+
30+
# List of Patterns
31+
32+
#### Reviewed Patterns (proven and reviewed)
3333

3434
* [Contracted Contributor](https://github.com/paypal/InnerSourcePatterns/blob/master/contracted-contributor.md)
3535
* [Dedicated Community Leader](https://github.com/paypal/InnerSourcePatterns/blob/master/dedicated-community-leader.md)
3636

37-
Pattern Drafts (proven, not yet reviewed)
38-
=========================================
37+
#### Pattern Drafts (proven, not yet reviewed)
3938

4039
* [Common Requirements](https://github.com/paypal/InnerSourcePatterns/pull/11)
4140
* [Reluctance to receive contributions](https://docs.google.com/document/d/13QDN-BpE_BixRFVGjao32n4Ctim0ROXAHbBWMBOijb4/edit)
@@ -47,8 +46,7 @@ Pattern Drafts (proven, not yet reviewed)
4746
* [Open Source trumps InnerSource](https://github.com/paypal/InnerSourceCommons/wiki/Open-Source-trumps-InnerSource)
4847
* [Overcoming Project Management Time Pressures](https://github.com/paypal/InnerSourceCommons/wiki/Draft-Pattern---Overcoming-Project-Management-Time-Pressures)
4948

50-
Pattern Ideas (not yet proven; brainstormed)
51-
============================================
49+
#### Pattern Ideas (not yet proven; brainstormed)
5250

5351
* [Badly named piles](https://github.com/paypal/InnerSourcePatterns/blob/master/badly-named-piles.md)
5452
* [Don't bother looking](https://github.com/paypal/InnerSourcePatterns/blob/master/dont-bother-looking.md)
@@ -58,8 +56,7 @@ Pattern Ideas (not yet proven; brainstormed)
5856
* [Change the developers mindset](https://github.com/paypal/InnerSourceCommons/wiki/Pattern:-change-the-developers-mindset)
5957
* [Share Your Code to Get More Done - Likely Contributors Variant](https://github.com/paypal/InnerSourceCommons/wiki/Pattern:-Share-Your-Code-to-Get-More-Done---Likely-Contributors-Variant)
6058

61-
Pattern Donuts (needing a solution)
62-
===================================
59+
#### Pattern Donuts (needing a solution)
6360

6461
* [Donut 3: how to defeat the hierarchical constraints](https://github.com/paypal/InnerSourceCommons/wiki/Donut-3%3A-how-to-defeat-the-hierarchical-constraints)
6562
* [Donut 4: modular code (for reuse) requires extra resources](https://github.com/paypal/InnerSourceCommons/wiki/Donut-4%3A-modular-code-%28for-reuse%29-requires-extra-resources)
@@ -70,15 +67,13 @@ Pattern Donuts (needing a solution)
7067
* [Get contributions despite silo thinking](https://github.com/paypal/InnerSourcePatterns/pull/38)
7168

7269

73-
Pattern Meta Info
74-
=================
70+
# Pattern Meta Info
7571

7672
* [Pattern States](meta/pattern-states.md) - Definitions of the various states and review steps a pattern can be in
7773
* [Pattern Template](meta/pattern-template.md) - Start a new pattern with a copy of this
7874

7975

80-
Licensing
81-
=========
76+
# Licensing
8277

8378
![Creative Commons License](https://i.creativecommons.org/l/by-sa/4.0/88x31.png)
8479

meta/trusted-collaborators.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,18 @@
11
# Trusted Collaborators
22

3-
Trusted collaborators/contributors/committers (TC's) are those members of our community who we have explicitly added to our Github repository.
4-
These people have elevated rights, allowing them to send in changes directly to branches and to accept Pull Requests.
3+
Trusted collaborators/contributors/committers (TC's) are those members of our community who we have explicitly added to our Github repository. These people have elevated rights, allowing them to send in changes directly to branches and to accept Pull Requests.
54

6-
We ask that TC's still adhere to the Pull-Request mechanism, unless they are making changes to documentation where it
7-
is not realistic that anyone will review, or if there are easy typos/grammar fixes.
5+
We ask that TC's still adhere to the Pull-Request mechanism, unless they are making changes to documentation where it is not realistic that anyone will review, or if there are easy typos/grammar fixes.
86

97
## Who we add
108
We add most people who send any sizable change. We work on trust - with great privilege comes great responsibility!
119

12-
Adding people off-the-bat encourages more contributions, displays trust, allows us to easily tag each other in reviews,
13-
and ensures there is always someone around to moderate the site, move reviews along, and accept Pull Requests!
14-
If anyone goes on vacation, there are a slew of others that could step in.
10+
Adding people off-the-bat encourages more contributions, displays trust, allows us to easily tag each other in reviews, and ensures there is always someone around to moderate the site, move reviews along, and accept Pull Requests! If anyone goes on vacation, there are a slew of others that could step in.
1511

1612
If you want to become a Collaborator, @ mention one of the [Admins](#admins) in an Issue.
1713

1814
## Admins
19-
There are currently a handful of Github Admins for this repository. They hold the ability to add collaborators and modify
20-
the repositories nuclear options (delete, rename, etc).
15+
There are currently a handful of Github Admins for this repository. They hold the ability to add collaborators and modify the repositories nuclear options (delete, rename, etc).
2116

2217
* @nyeates - ask me first
2318
* @gruetter

0 commit comments

Comments
 (0)