Skip to content

Commit 693d552

Browse files
fix of HttpClient setup in PlaguBot
1 parent 247a479 commit 693d552

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## 11.1.1
44

5+
* `Bot`:
6+
* Logic of creating `HttpClient` now works even if proxy is ommited
7+
58
## 11.1.0
69

710
* `Bot`:

bot/src/main/kotlin/dev/inmo/plagubot/PlaguBot.kt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,19 @@ object PlaguBot : Plugin {
6262
*/
6363
override fun KtorRequestsExecutorBuilder.setupBotClient(scope: Scope, params: JsonObject) {
6464
val config = scope.get<Config>()
65-
if (config.proxy != null) {
65+
val clientFromHttpClientEngine = scope.getOrNull<HttpClientEngine>() ?.let {
66+
HttpClient(it)
67+
}
68+
val clientFromKoin = clientFromHttpClientEngine ?: (scope.getOrNull<HttpClientEngineFactory<*>>() ?: OkHttp).let {
69+
HttpClient(it)
70+
}
71+
this@setupBotClient.client = if (config.proxy != null) {
6672
val initialClient = config.proxy.createDefaultClient()
67-
val clientFromHttpClientEngine = scope.getOrNull<HttpClientEngine>() ?.let {
68-
HttpClient(it)
69-
}
70-
val clientFromKoin = clientFromHttpClientEngine ?: (scope.getOrNull<HttpClientEngineFactory<*>>() ?: OkHttp).let {
71-
HttpClient(it)
72-
}
73-
this@setupBotClient.client = initialClient.config {
73+
initialClient.config {
7474
install(clientFromKoin)
7575
}
76+
} else {
77+
clientFromKoin
7678
}
7779
scope.plugins.filter { it !== this@PlaguBot }.forEach {
7880
with(it) {

0 commit comments

Comments
 (0)