feat: group and study unit (#1408)

* feat: display Groups and Study Unit inputs

* fix: improve DDI pages

* fix: format code

Author: EmmanuelDemey

src/packages/modules-ddi/hooks/useCreatePhysicalInstance.ts

@@ -5,6 +5,10 @@ import { useAppContext } from "../../application/app-context";
 interface CreatePhysicalInstanceParams {
   physicalInstanceLabel: string;
   dataRelationshipName: string;
+  groupId: string;
+  groupAgency: string;
+  studyUnitId: string;
+  studyUnitAgency: string;
 }
 
 interface TopLevelReference {

src/packages/modules-ddi/hooks/useGroupDetails.ts

@@ -0,0 +1,38 @@
+import { useQuery } from "@tanstack/react-query";
+import { DDIApi } from "../../sdk";
+
+export interface StudyUnit {
+  ID: string;
+  Agency: string;
+  Version: string;
+  Citation: {
+    Title: {
+      String: {
+        "@xml:lang": string;
+        "#text": string;
+      };
+    };
+  };
+}
+
+interface GroupDetailsResponse {
+  Group: Array<{
+    ID: string;
+    Agency: string;
+    StudyUnitReference: Array<{
+      Agency: string;
+      ID: string;
+      Version: string;
+      TypeOfObject: string;
+    }>;
+  }>;
+  StudyUnit: StudyUnit[];
+}
+
+export function useGroupDetails(agencyId: string | null, groupId: string | null) {
+  return useQuery<GroupDetailsResponse>({
+    queryKey: ["group", agencyId, groupId],
+    queryFn: () => DDIApi.getGroup(agencyId!, groupId!),
+    enabled: !!agencyId && !!groupId,
+  });
+}

src/packages/modules-ddi/hooks/useGroups.ts

@@ -0,0 +1,16 @@
+import { useQuery } from "@tanstack/react-query";
+import { DDIApi } from "../../sdk";
+
+export interface Group {
+  id: string;
+  label: string;
+  versionDate: string;
+  agency: string;
+}
+
+export function useGroups() {
+  return useQuery<Group[]>({
+    queryKey: ["groups"],
+    queryFn: () => DDIApi.getGroups(),
+  });
+}

src/packages/modules-ddi/hooks/usePublishPhysicalInstance.ts

@@ -18,6 +18,11 @@ export function usePublishPhysicalInstance() {
       queryClient.invalidateQueries({
         queryKey: ["physicalInstanceById", variables.agencyId, variables.id],
       });
+      // Invalider le cache des code lists pour qu'elles soient disponibles
+      // immédiatement dans le sélecteur "Réutiliser une code list"
+      queryClient.invalidateQueries({
+        queryKey: ["codesLists"],
+      });
     },
   });
 }

src/packages/modules-ddi/hooks/useUpdatePhysicalInstance.spec.tsx

@@ -57,7 +57,7 @@ describe("useUpdatePhysicalInstance", () => {
     });
   });
 
-  it("should invalidate query cache on successful mutation", async () => {
+  it("should not invalidate query cache to preserve local variables", async () => {
     const mockPatch = vi.fn().mockResolvedValue({});
     (DDIApi.patchPhysicalInstance as any) = mockPatch;
 
@@ -78,11 +78,8 @@ describe("useUpdatePhysicalInstance", () => {
 
     await result.current.mutateAsync(testData);
 
-    await waitFor(() => {
-      expect(invalidateQueriesSpy).toHaveBeenCalledWith({
-        queryKey: ["physicalInstanceById", "test-agency-456", "test-id-123"],
-      });
-    });
+    // Le cache ne doit pas être invalidé pour préserver les variables locales non sauvegardées
+    expect(invalidateQueriesSpy).not.toHaveBeenCalled();
   });
 
   it("should handle API errors correctly", async () => {

src/packages/modules-ddi/hooks/useUpdatePhysicalInstance.ts

@@ -1,4 +1,4 @@
-import { useMutation, useQueryClient } from "@tanstack/react-query";
+import { useMutation } from "@tanstack/react-query";
 import { DDIApi } from "../../sdk";
 
 interface UpdatePhysicalInstanceParams {
@@ -7,20 +7,18 @@ interface UpdatePhysicalInstanceParams {
   data: {
     physicalInstanceLabel: string;
     dataRelationshipName: string;
+    groupId: string;
+    groupAgency: string;
+    studyUnitId: string;
+    studyUnitAgency: string;
   };
 }
 
 export function useUpdatePhysicalInstance() {
-  const queryClient = useQueryClient();
-
   return useMutation({
     mutationFn: ({ id, agencyId, data }: UpdatePhysicalInstanceParams) =>
       DDIApi.patchPhysicalInstance(agencyId, id, data),
-    onSuccess: (_, variables) => {
-      // Invalider le cache pour rafraîchir les données
-      queryClient.invalidateQueries({
-        queryKey: ["physicalInstanceById", variables.agencyId, variables.id],
-      });
-    },
+    // Ne pas invalider le cache ici car cela écraserait les variables locales
+    // non sauvegardées. Le titre est mis à jour localement via le state du composant.
   });
 }

src/packages/modules-ddi/i18n/locales/en.json

@@ -5,7 +5,11 @@
       "create": "Create",
       "errorMessage": "An error occurred during creation",
       "errorTitle": "Creation error",
+      "group": "Group",
       "label": "Label",
+      "selectGroup": "Select a group",
+      "selectStudyUnit": "Select a study unit",
+      "studyUnit": "Study Unit",
       "successMessage": "Your changes have been successfully saved",
       "successTitle": "Creation successful",
       "title": "Create a new physical instance"
@@ -132,6 +136,8 @@
       },
       "variableUpdateSuccess": "Variable updated",
       "variableUpdateSuccessDetail": "Variable successfully updated. Remember to save",
+      "previousVariable": "Previous variable",
+      "nextVariable": "Next variable",
       "totalVariables": "Total: {{count}} variable(s)",
       "unsavedChangesTitle": "Unsaved changes",
       "unsavedChangesMessage": "You have unsaved changes. Are you sure you want to leave this page?",

src/packages/modules-ddi/i18n/locales/fr.json

@@ -5,7 +5,11 @@
       "create": "Créer",
       "errorMessage": "Une erreur est survenue lors de la création",
       "errorTitle": "Erreur de création",
+      "group": "Groupe",
       "label": "Libellé",
+      "selectGroup": "Sélectionnez un groupe",
+      "selectStudyUnit": "Sélectionnez une étude",
+      "studyUnit": "Étude",
       "successMessage": "Vos modifications ont été sauvegardées avec succès",
       "successTitle": "Création réussie",
       "title": "Créer un nouveau fichier de données"
@@ -131,6 +135,8 @@
       },
       "variableUpdateSuccess": "Variable mise à jour",
       "variableUpdateSuccessDetail": "Variable mise à jour avec succès. Pensez à sauvegarder",
+      "previousVariable": "Variable précédente",
+      "nextVariable": "Variable suivante",
       "variablesTable": "Tableau des variables",
       "totalVariables": "Total : {{count}} variable(s)",
       "unsavedChangesTitle": "Modifications non sauvegardées",

src/packages/modules-ddi/physical-instances/components/CodeRepresentation/CodeListDataTable.tsx

@@ -147,6 +147,7 @@ export const CodeListDataTable = ({
         <InputText
           id="code-list-label"
           name="codeListLabel"
+          autoComplete="off"
           value={codeListLabel}
           onChange={(e) => onCodeListLabelChange(e.target.value)}
         />

src/packages/modules-ddi/physical-instances/components/CodeRepresentation/ReuseCodeListSelect.tsx

@@ -22,8 +22,8 @@ export const ReuseCodeListSelect = ({
 
   if (isLoadingCodesLists) {
     return (
-      <div className="flex align-items-center gap-2">
-        <ProgressSpinner style={{ width: "20px", height: "20px" }} strokeWidth="4" />
+      <div className="flex gap-2">
+        <ProgressSpinner style={{ width: "20px", height: "20px", margin: "0" }} strokeWidth="4" />
         <span>{t("physicalInstance.view.code.loadingCodesLists")}</span>
       </div>
     );