Merge pull request #1424 from InseeFr/fix/reset-codes-list-form

fix: reset codes list form

Author: PierreVasseur

src/packages/modules-ddi/physical-instances/components/CodeRepresentation/CodeRepresentation.reducer.spec.ts

@@ -276,6 +276,28 @@ describe("codeRepresentationReducer", () => {
       expect(result.showDataTable).toBe(false);
       expect(result.codes).toEqual([]);
     });
+
+    it("should reset showReuseSelect to false when initializing from code list", () => {
+      const stateWithReuseSelect: CodeRepresentationState = {
+        ...initialState,
+        showReuseSelect: true,
+        selectedCodeListId: "some-id",
+      };
+      const action: CodeRepresentationAction = {
+        type: "INIT_FROM_CODE_LIST",
+        payload: {
+          label: "New List",
+          codes: [],
+          showDataTable: true,
+        },
+      };
+
+      const result = codeRepresentationReducer(stateWithReuseSelect, action);
+
+      expect(result.showReuseSelect).toBe(false);
+      expect(result.selectedCodeListId).toBeNull();
+      expect(result.showDataTable).toBe(true);
+    });
   });
 
   describe("INIT_REUSED_CODE_LIST", () => {
@@ -308,16 +330,16 @@ describe("codeRepresentationReducer", () => {
       expect(result.showReuseSelect).toBe(true);
     });
 
-    it("should preserve other state properties", () => {
+    it("should reset state to initial values except for selectedCodeListId and showReuseSelect", () => {
       const action: CodeRepresentationAction = {
         type: "INIT_REUSED_CODE_LIST",
         payload: { selectedCodeListId: "agency-list-id" },
       };
 
       const result = codeRepresentationReducer(stateWithCodes, action);
 
-      expect(result.codes).toEqual(stateWithCodes.codes);
-      expect(result.codeListLabel).toBe(stateWithCodes.codeListLabel);
+      expect(result.codes).toEqual([]);
+      expect(result.codeListLabel).toBe("");
     });
   });
 

src/packages/modules-ddi/physical-instances/components/CodeRepresentation/CodeRepresentation.reducer.ts

@@ -84,18 +84,17 @@ export const codeRepresentationReducer = (
 
     case "INIT_FROM_CODE_LIST":
       return {
-        ...state,
+        ...initialState,
         codeListLabel: action.payload.label,
         codes: action.payload.codes,
         showDataTable: action.payload.showDataTable,
       };
 
     case "INIT_REUSED_CODE_LIST":
       return {
-        ...state,
+        ...initialState,
         selectedCodeListId: action.payload.selectedCodeListId,
         showReuseSelect: true,
-        showDataTable: false,
       };
 
     default:

src/packages/modules-ddi/physical-instances/components/CodeRepresentation/CodeRepresentation.tsx

@@ -44,7 +44,6 @@ export const CodeRepresentation = ({
   });
 
   const { codeListLabel, codes, showDataTable, showReuseSelect, selectedCodeListId } = state;
-
   useEffect(() => {
     if (codeList) {
       // Cas où on a une codeList complète (création ou liste existante chargée)