Merge pull request #126 from InseeFr/125-augmenter-la-couverture-de-test

feature : CodeListTest.java and FilesUtilsTest.java

Author: HugoBouttes

src/test/java/fr/insee/rmes/exceptions/RmesExceptionIOTest.java

@@ -0,0 +1,24 @@
+package fr.insee.rmes.exceptions;
+
+import org.junit.jupiter.api.Test;
+import java.util.ArrayList;
+import java.util.Arrays;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class RmesExceptionIOTest {
+
+
+    @Test
+    void shouldReturnRestMessageObjectParametersPossibilities() {
+
+        ArrayList<Integer> status = new ArrayList<>(Arrays.asList(ErrorCodes.LINK_CREATION_RIGHTS_DENIED,-1));
+        ArrayList<String> messages = new ArrayList<>(Arrays.asList("Unauthorized",null));
+        ArrayList<String> details = new ArrayList<>(Arrays.asList("Invalid password or tocken",null));
+
+        RmesExceptionIO rmesExceptionIOExampleOne= new RmesExceptionIO(status.getFirst(), messages.getFirst(), details.getFirst());
+        RmesExceptionIO rmesExceptionIOExampleTwo= new RmesExceptionIO(status.getLast(),messages.getLast(),details.getLast());
+
+        assertTrue(rmesExceptionIOExampleOne.getMessage()!=null && rmesExceptionIOExampleTwo.getMessage()==null);
+    }
+
+}

src/test/java/fr/insee/rmes/metadata/service/MetadataServiceImplTest.java

@@ -0,0 +1,19 @@
+package fr.insee.rmes.metadata.service;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
+
+class MetadataServiceImplTest {
+
+    @Test
+    void shouldReturnListOfUnits() throws Exception {
+
+        MetadataServiceImpl metadataServiceImpl = new MetadataServiceImpl();
+
+        String actual =metadataServiceImpl.getUnits().toString();
+        String expected = "[Unit [uri=http://id.insee.fr/unit/euro, label=€], Unit [uri=http://id.insee.fr/unit/keuro, label=k€], Unit [uri=http://id.insee.fr/unit/percent, label=%], Unit [uri=http://id.insee.fr/unit/heure, label=heures], Unit [uri=http://id.insee.fr/unit/jour, label=jours], Unit [uri=http://id.insee.fr/unit/semaine, label=semaines], Unit [uri=http://id.insee.fr/unit/mois, label=mois], Unit [uri=http://id.insee.fr/unit/annee, label=années], Unit [uri=http://id.insee.fr/unit/an, label=ans], Unit [uri=http://id.insee.fr/unit/watt, label=W], Unit [uri=http://id.insee.fr/unit/kilowatt, label=kW], Unit [uri=http://id.insee.fr/unit/megawatt, label=MW], Unit [uri=http://id.insee.fr/unit/megawattheurepcs, label=MWh PCS], Unit [uri=http://id.insee.fr/unit/megawattheure, label=MWh], Unit [uri=http://id.insee.fr/unit/megawattpcs, label=MW PCS], Unit [uri=http://id.insee.fr/unit/kilowattthermique, label=kWth], Unit [uri=http://id.insee.fr/unit/kg, label=kg], Unit [uri=http://id.insee.fr/unit/tonne, label=tonnes], Unit [uri=http://id.insee.fr/unit/tonnematiereseche, label=tonnes matières sèches], Unit [uri=http://id.insee.fr/unit/degrecelsius, label=°C], Unit [uri=http://id.insee.fr/unit/bar, label=bars], Unit [uri=http://id.insee.fr/unit/litre, label=litres], Unit [uri=http://id.insee.fr/unit/metre, label=mètres], Unit [uri=http://id.insee.fr/unit/centimetre, label=centimètres], Unit [uri=http://id.insee.fr/unit/metrecarre, label=mètres carrés]]";
+
+        assertEquals(expected,actual);
+    }
+
+}

src/test/java/fr/insee/rmes/model/CodeListTest.java

@@ -1,12 +1,70 @@
 package fr.insee.rmes.model;
 
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+import org.junit.jupiter.api.Test;
+import java.util.ArrayList;
+import java.util.List;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import org.junit.jupiter.api.Test;
 import java.util.List;
 import static org.junit.jupiter.api.Assertions.*;
 
 class CodeListTest {
 
     @Test
+    void testToString() throws JSONException {
+        String itemType ="itemType";
+        String agencyId ="agencyId";
+        String version ="version";
+        String identifier ="identifier";
+        String item ="item";
+        String versionDate ="versionDate";
+        String versionResponsibility ="versionResponsibility";
+        boolean isPublished =true;
+        boolean isDeprecated =true;
+        boolean isProvisional =true;
+        String itemFormat ="itemFormat";
+        JSONObject versionRationale = new JSONObject();
+        versionRationale.put("versionRationale","versionRationaleExampleOne");
+        versionRationale.put("versionRationale","versionRationaleExampleTwo");
+
+        JSONObject noteExampleOne = new JSONObject();
+        noteExampleOne.put("noteFirst", "1");
+        noteExampleOne.put("noteSecond", "2");
+
+        JSONObject noteExampleTwo = new JSONObject();
+        noteExampleTwo.put("noteFirst", "1");
+        noteExampleTwo.put("noteSecond", "2");
+
+        JSONArray notes = new JSONArray();
+        notes.put(noteExampleOne);
+        notes.put(noteExampleTwo);
+
+       boolean isUniversallyUnique = true;
+
+       Code code = new Code();
+
+        List<Code> codeList = new ArrayList<>();
+        codeList.add(code);
+
+        String response = "CodeList [codeList=" + codeList + ", isUniversallyUnique=" + isUniversallyUnique + ", itemType="
+                + itemType + ", agencyId=" + agencyId + ", version=" + version + ", identifier=" + identifier
+                + ", item=" + item + ", versionDate=" + versionDate + ", versionResponsibility=" + versionResponsibility
+                + ", isPublished=" + isPublished + ", isDeprecated=" + isDeprecated + ", isProvisional=" + isProvisional
+                + ", itemFormat=" + itemFormat + ", versionRationale=" + versionRationale + ", notes=" + notes + "]";
+
+        String expected = "CodeList [codeList=[Code [levelNumber=0, value=null, categoryReference=null, category=null, isDiscrete=false, agencyId=null, version=null, identifier=null]], isUniversallyUnique=true, itemType=itemType, agencyId=agencyId, version=version, identifier=identifier, item=item, versionDate=versionDate, versionResponsibility=versionResponsibility, isPublished=true, isDeprecated=true, isProvisional=true, itemFormat=itemFormat, versionRationale={\"versionRationale\":\"versionRationaleExampleTwo\"}, notes=[{\"noteFirst\":\"1\",\"noteSecond\":\"2\"},{\"noteFirst\":\"1\",\"noteSecond\":\"2\"}]]";
+
+        assertEquals(expected,response);
+    }
+
+
+
+
+
+
     void shouldTestToString() {
 
         Code code2025 = new Code();

src/test/java/fr/insee/rmes/tocolecticaapi/controller/ControllerUtilsTest.java

@@ -1,11 +1,32 @@
 package fr.insee.rmes.tocolecticaapi.controller;
 
 import org.junit.jupiter.api.Test;
+import org.springframework.http.ResponseEntity;
+import java.util.List;
+import java.util.Objects;
 import static org.junit.jupiter.api.Assertions.*;
 
 class ControllerUtilsTest {
 
     @Test
+    void shouldReturnResponsesForDifferentXMLEntities() {
+
+        List<String> xmlContents = List.of("<para> It's truly amazing.</para>","<para> It's \\\"\\\" truly amazing.</para>","<para> It's \" truly amazing.</para>");
+        List<ResponseEntity<String>> responseEntities = List.of(ControllerUtils.xmltoResponseEntity(xmlContents.getFirst()),ControllerUtils.xmltoResponseEntity(xmlContents.get(2)),ControllerUtils.xmltoResponseEntity(xmlContents.getLast()));
+
+        List<String> prefixActual = List.of(responseEntities.getFirst().toString().substring(0,17),responseEntities.get(1).toString().substring(0,17),responseEntities.getLast().toString().substring(0,17));
+        List<String> prefixExpected = List.of("<200 OK OK,<para>","<200 OK OK,<para>","<200 OK OK,<para>");
+
+        List<Boolean> responseEntitiesContainsSymbol = List.of(responseEntities.getFirst().toString().contains(""),responseEntities.get(1).toString().contains(""),responseEntities.getLast().toString().contains(""));
+        List<Boolean> responseEntitiesContainsSlash= List.of(responseEntities.getFirst().toString().contains("\""),responseEntities.get(1).toString().contains("\""),responseEntities.getLast().toString().contains("\""));
+
+        boolean identicalPrefix = Objects.equals(prefixActual.toString(), prefixExpected.toString());
+        boolean containsSymbol = responseEntitiesContainsSymbol.equals(List.of(false, false, false));
+        boolean containsSlash = responseEntitiesContainsSlash.equals(List.of(false,true,true));
+
+        assertTrue(identicalPrefix && containsSymbol && containsSlash);
+    }
+  
     void shouldReturnXmlToResponseEntity() {
         String sentence = "This\\\"is an \"\"example.";
         String actual = ControllerUtils.xmltoResponseEntity(sentence).toString();
@@ -18,5 +39,4 @@ void shouldReturnNullPointerExceptionWhenNullStringForXmlToResponseEntity() {
         assertTrue(exception.getMessage().contains("Cannot invoke \"String.replace(java.lang.CharSequence, java.lang.CharSequence)\" because \"xmlContent\" is null"));
     }
 
-
 }

src/test/java/fr/insee/rmes/tocolecticaapi/models/FragmentDataTest.java

@@ -1,11 +1,46 @@
 package fr.insee.rmes.tocolecticaapi.models;
 
 import org.junit.jupiter.api.Test;
+import java.util.List;
 import static org.junit.jupiter.api.Assertions.*;
 
 class FragmentDataTest {
 
     @Test
+    void shouldIndicateIfTwoFragmentDateAreIdentical() {
+        FragmentData fragmentDataExampleOne = new FragmentData("identifier","agencyId", "version");
+        FragmentData fragmentDataExampleTwo = new FragmentData("identifier","agencyId", "version");
+        FragmentData fragmentDataExampleThree = new FragmentData("example","agencyId", "version");
+        assertTrue(fragmentDataExampleOne.equals(fragmentDataExampleTwo) && ! fragmentDataExampleOne.equals(fragmentDataExampleThree));
+    }
+
+    @Test
+    void shouldReturnDifferentHashCodeForEachDifferentFragmentData() {
+
+        FragmentData fragmentDataExampleOne = new FragmentData("identifierExampleOne","identifierExampleOne", "identifierExampleOne");
+        FragmentData fragmentDataExampleTwo = new FragmentData("identifierExampleTwo","agencyIdExampleTwo", "versionExampleTwo");
+        FragmentData fragmentDataExampleThree = new FragmentData("identifierExampleThree","agencyIdExampleThree", "versionExampleThree");
+
+        boolean compareHshCodeOneAndTwo = fragmentDataExampleOne.hashCode() ==fragmentDataExampleTwo.hashCode() ;
+        boolean compareHshCodeTwoAndThree = fragmentDataExampleTwo.hashCode() ==fragmentDataExampleThree.hashCode() ;
+        boolean compareHshCodeThreeAndOne = fragmentDataExampleThree.hashCode() ==fragmentDataExampleOne.hashCode() ;
+
+        assertEquals(List.of(false,false,false),List.of(compareHshCodeOneAndTwo,compareHshCodeTwoAndThree,compareHshCodeThreeAndOne));
+    }
+
+    @Test
+    void shouldReturnSameHashCodeSameFragmentData() {
+
+        FragmentData fragmentDataExampleOne = new FragmentData("identifierExampleOne","identifierExampleOne", "identifierExampleOne");
+        FragmentData fragmentDataExampleTwo = new FragmentData("identifierExampleOne","identifierExampleOne", "identifierExampleOne");
+
+        boolean compareHshCodeOneAndTwo = fragmentDataExampleOne.hashCode() ==fragmentDataExampleTwo.hashCode() ;
+
+        assertTrue(compareHshCodeOneAndTwo);
+
+    }
+
+
     void shouldReturnBooleanWhenTestEquals() {
         FragmentData fragmentData = new FragmentData("identifier", "agencyId", "version");
         FragmentData mockFragmentDataOne = new FragmentData("identifier", "agencyId", "version");

src/test/java/fr/insee/rmes/utils/FilesUtilsTest.java

@@ -1,12 +1,37 @@
 package fr.insee.rmes.utils;
 
 import org.junit.jupiter.api.Test;
+import java.util.ArrayList;
+import java.util.List;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 import static org.junit.jupiter.api.Assertions.*;
 
 class FilesUtilsTest {
 
+    @Test
+    void shouldReduceFileNameSize() {
+        String fileName = "DDI_ACCESS_SERVICES_PROJECT.java";
+        int maxLength = 10;
+        String response = FilesUtils.reduceFileNameSize(fileName,maxLength);
+        assertEquals("DDI_ACCESS",response);
+
+    }
+
+    @Test
+    void removeAsciiCharacters() {
+        List<String> fileNames =  List.of("nœud","nŒud","ÀöBÎCčDžpEFsàGíHáIýJdK","Ddi access-SERVICE!?");
+        List<String> actual = new ArrayList<>();
+
+        for (String element : fileNames){
+            actual.add(FilesUtils.removeAsciiCharacters(element));
+        }
+        
+        List<String> expected = List.of("noeud", "nOEud", "AoBICcDzpEFsaGiHaIyJdK", "Ddi accessSERVICE");
+        assertEquals(expected,actual);
+
+    }
+
     @ParameterizedTest
     @ValueSource(ints = { 0,1,2,3,4,5,6,7,8 })
     void shouldReduceFileNameSize(int maxLength) {

src/test/java/fr/insee/rmes/utils/HttpUtilsTest.java

@@ -1,23 +1,52 @@
 package fr.insee.rmes.utils;
 
 import org.junit.jupiter.api.Test;
+import org.springframework.http.ContentDisposition;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
 import org.xmlunit.builder.DiffBuilder;
 import org.xmlunit.builder.Input;
-
 import java.io.IOException;
+import java.util.Objects;
 
 import static org.junit.jupiter.api.Assertions.*;
 
 class HttpUtilsTest {
 
+
     @Test
     void filterBOM() throws IOException {
-        var filteredContentWithBom=HttpUtils.filterBOM(HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierAvecBom.xml").readAllBytes());
-        var filteredContentWithoutBom=HttpUtils.filterBOM(HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierSansBom.xml").readAllBytes());
-        var diff=DiffBuilder.compare(Input.fromString(filteredContentWithBom))
+        var filteredContentWithBom = HttpUtils.filterBOM(HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierAvecBom.xml").readAllBytes());
+        var filteredContentWithoutBom = HttpUtils.filterBOM(HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierSansBom.xml").readAllBytes());
+        var diff = DiffBuilder.compare(Input.fromString(filteredContentWithBom))
                 .withTest(Input.fromString(filteredContentWithoutBom))
                 .ignoreWhitespace()
                 .build();
         assertFalse(diff.hasDifferences(), diff.toString());
     }
+
+
+    @Test
+    void shouldTestIfObjectsHaveBom() throws IOException {
+        byte[] filteredContentWithBom = HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierAvecBom.xml").readAllBytes();
+        byte[] filteredContentWithoutBom = HttpUtilsTest.class.getResourceAsStream("/utf8-bom/fichierSansBom.xml").readAllBytes();
+        boolean hasBomFilteredContentWithBom = filteredContentWithBom.length > 2 && filteredContentWithBom[0] == (byte) 0xEF && filteredContentWithBom[1] == (byte) 0xBB && filteredContentWithBom[2] == (byte) 0xBF;
+        boolean hasBomFilteredContentWithoutBom = filteredContentWithoutBom.length > 2 && filteredContentWithoutBom[0] == (byte) 0xEF && filteredContentWithoutBom[1] == (byte) 0xBB && filteredContentWithoutBom[2] == (byte) 0xBF;
+        assertTrue(hasBomFilteredContentWithBom && !hasBomFilteredContentWithoutBom);
+    }
+
+    @Test
+    void shouldGenerateHttpHeadersWithCorrectsComponents(){
+        HttpHeaders httpHeaders = HttpUtils.generateHttpHeaders("MyProject", FileExtension.ODT_EXTENSION, 32);
+
+        MediaType mediaTypeExpected = new MediaType("application", "vnd.oasis.opendocument.text");
+        String accessControlExposeHeadersExpected ="[Content-Disposition, X-Missing-Documents, Access-Control-Allow-Origin, Access-Control-Allow-Credentials]";
+        ContentDisposition contentDispositionExpected = ContentDisposition.builder(HttpUtils.ATTACHMENT).filename(FilesUtils.reduceFileNameSize(FilesUtils.removeAsciiCharacters("MyProject"), 32)).build();
+
+        boolean testMediaType = Objects.equals(mediaTypeExpected,httpHeaders.getContentType());
+        boolean testAccessControlExposeHeaders = Objects.equals(accessControlExposeHeadersExpected,httpHeaders.getAccessControlExposeHeaders().toString());
+        boolean testContentDisposition = Objects.equals(contentDispositionExpected,httpHeaders.getContentDisposition());
+        assertTrue(testMediaType && testAccessControlExposeHeaders && testContentDisposition);
+
+    }
 }

src/test/java/fr/insee/rmes/utils/export/ClasspathUriResolverTest.java

@@ -0,0 +1,22 @@
+package fr.insee.rmes.utils.export;
+
+import org.junit.jupiter.api.Test;
+import javax.xml.transform.Source;
+import javax.xml.transform.TransformerException;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class ClasspathUriResolverTest {
+
+    @Test
+    void shouldReturnNotNullSources() throws TransformerException {
+        ClasspathUriResolver classpathUriResolver = new ClasspathUriResolver();
+        List<Source> sources = new ArrayList<>();
+        sources.add(classpathUriResolver.resolve("../..test","anyString"));
+        sources.add(classpathUriResolver.resolve("..test","anyString"));
+        sources.add(classpathUriResolver.resolve("test","anyString"));
+        assertTrue(sources.getFirst()!=null && sources.get(1)!=null && sources.get(2)!=null);
+    } 
+}