Skip to content

Commit 0703740

Browse files
committed
Merge branch 'main' into devModeleFiliere
2 parents d4151c3 + 5399f6c commit 0703740

File tree

10 files changed

+77
-20
lines changed

10 files changed

+77
-20
lines changed

.github/workflows/create-release.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
java-version: '21'
2828

2929
- name: Checkout repo
30-
uses: actions/checkout@v5
30+
uses: actions/checkout@v6
3131
with:
3232
fetch-depth: 0
3333

@@ -70,7 +70,7 @@ jobs:
7070
java-version: '21'
7171

7272
- name: Clone BPM
73-
uses: actions/checkout@v5
73+
uses: actions/checkout@v6
7474
with:
7575
repository: InseeFr/BPM
7676
path: bpm
@@ -81,7 +81,7 @@ jobs:
8181
mvn clean install --no-transfer-progress
8282
cd ..
8383
84-
- uses: actions/checkout@v5
84+
- uses: actions/checkout@v6
8585
- name: Build app
8686
run: |
8787
git fetch origin main
@@ -99,7 +99,7 @@ jobs:
9999
if: needs.check-version.outputs.should_run_next_job == 'true'
100100
runs-on: ubuntu-latest
101101
steps:
102-
- uses: actions/checkout@v5
102+
- uses: actions/checkout@v6
103103
with:
104104
ref: ${{ github.ref }}
105105
fetch-depth: 0
@@ -162,7 +162,7 @@ jobs:
162162
needs: [ check-version, create-release ]
163163
runs-on: ubuntu-latest
164164
steps:
165-
- uses: actions/checkout@v5
165+
- uses: actions/checkout@v6
166166

167167
- name: Download uploaded jar
168168
uses: actions/download-artifact@v6

.github/workflows/docker.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
run: echo "branch=$(echo ${GITHUB_REF#refs/heads/})" >>$GITHUB_OUTPUT
1717
id: extract_branch
1818

19-
- uses: actions/checkout@v5
19+
- uses: actions/checkout@v6
2020
with:
2121
ref: ${{ steps.extract_branch.outputs.branch }}
2222

@@ -52,7 +52,7 @@ jobs:
5252
- build-snapshot
5353
runs-on: ubuntu-latest
5454
steps:
55-
- uses: actions/checkout@v5
55+
- uses: actions/checkout@v6
5656

5757
- name: Download uploaded jar
5858
uses: actions/download-artifact@v6

.github/workflows/maven.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
runs-on: ubuntu-latest
2121

2222
steps:
23-
- uses: actions/checkout@v5
23+
- uses: actions/checkout@v6
2424

2525
- name: Set up JDK 21
2626
uses: actions/setup-java@v5

.github/workflows/pr-version.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
contains(github.event.pull_request.labels.*.name, 'Version Update - Prod')
1515
steps:
1616
- name: Checkout PR branch
17-
uses: actions/checkout@v5
17+
uses: actions/checkout@v6
1818
with:
1919
ref: ${{ github.head_ref }}
2020

.github/workflows/scheduled-version-update.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: ubuntu-latest
2020
steps:
2121
- name: Checkout
22-
uses: actions/checkout@v5
22+
uses: actions/checkout@v6
2323
with:
2424
path: genesis
2525
ref: main
@@ -196,7 +196,7 @@ jobs:
196196
runs-on: ubuntu-latest
197197
needs: update-version
198198
steps:
199-
- uses: actions/checkout@v5
199+
- uses: actions/checkout@v6
200200
- name: Wait for merged version commit
201201
run: |
202202
echo "Fetching main branch..."

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
# Changelog
2+
## 1.12.2 [2025-11-06]
3+
### Fixed
4+
- Scientific notation for Doubles during raw data processing
5+
6+
### Updated
7+
- BPM 1.0.19
28
## 1.12.0 [2025-10-23]
39
- Get review indicator endpoint
410

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM eclipse-temurin:21.0.8_9-jre-alpine
1+
FROM eclipse-temurin:21.0.9_10-jre-alpine
22

33
ENV PATH_TO_JAR=/opt/app/app.jar
44
WORKDIR /opt/app/

pom.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@
44
<modelVersion>4.0.0</modelVersion>
55
<groupId>fr.insee.genesis</groupId>
66
<artifactId>genesis-api</artifactId>
7-
<version>1.12.1</version>
7+
<version>1.12.4</version>
88
<packaging>jar</packaging>
99
<name>genesis-api</name>
1010

1111
<parent>
1212
<groupId>org.springframework.boot</groupId>
1313
<artifactId>spring-boot-starter-parent</artifactId>
14-
<version>3.5.7</version>
14+
<version>3.5.8</version>
1515
</parent>
1616

1717
<properties>
1818
<java.version>21</java.version>
19-
<springdoc.version>2.8.13</springdoc.version>
19+
<springdoc.version>2.8.14</springdoc.version>
2020
<mapstruct.version>1.6.3</mapstruct.version>
21-
<cucumber.version>7.31.0</cucumber.version>
21+
<cucumber.version>7.32.0</cucumber.version>
2222
<junit-jupiter.version>5.13.4</junit-jupiter.version>
2323

2424
<!-- Proprietes sonar -->
@@ -33,10 +33,10 @@
3333
</sonar.exclusions>
3434
<skipSurefireReport>true</skipSurefireReport>
3535
<!-- Pi Test-->
36-
<pitest.version>1.21.0</pitest.version>
36+
<pitest.version>1.22.0</pitest.version>
3737
<pitest.junit.version>1.2.3</pitest.junit.version>
3838
<jackson.version>2.19.0</jackson.version>
39-
<bpm.version>1.0.18</bpm.version>
39+
<bpm.version>1.0.19</bpm.version>
4040
</properties>
4141
<dependencies>
4242
<dependency>
@@ -175,7 +175,7 @@
175175
<plugin>
176176
<groupId>org.sonarsource.scanner.maven</groupId>
177177
<artifactId>sonar-maven-plugin</artifactId>
178-
<version>5.2.0.4988</version>
178+
<version>5.3.0.6276</version>
179179
</plugin>
180180
<plugin>
181181
<groupId>org.jacoco</groupId>

src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.springframework.stereotype.Service;
3737

3838
import java.io.IOException;
39+
import java.math.BigDecimal;
3940
import java.time.Instant;
4041
import java.time.LocalDateTime;
4142
import java.util.ArrayList;
@@ -376,6 +377,10 @@ private static void convertToCollectedVar(
376377
Map<String, Object> states = JsonUtils.asMap(collectedVariable.getValue());
377378

378379
// nothing if no state
380+
if (states == null || states.isEmpty()) {
381+
continue;
382+
}
383+
379384
if (states.containsKey(stateKey)) {
380385
Object value = states.get(stateKey);
381386

@@ -388,7 +393,7 @@ private static void convertToCollectedVar(
388393
// scalaire non null ?
389394
if (value != null && !(value instanceof List<?>)) {
390395
// idem: on garde convertOneVar(entry, String, ...)
391-
convertOneVar(collectedVariable, String.valueOf(value), variablesMap, 1, dest);
396+
convertOneVar(collectedVariable, getValueString(value), variablesMap, 1, dest);
392397
}
393398
}
394399
}
@@ -461,4 +466,15 @@ public Page<LunaticJsonRawDataModel> findRawDataByCampaignIdAndDate(String campa
461466

462467
}
463468

469+
//Utils
470+
protected static String getValueString(Object value) {
471+
if (value instanceof Double || value instanceof Float) {
472+
BigDecimal bd = new BigDecimal(value.toString());
473+
return bd.stripTrailingZeros().toPlainString();
474+
}
475+
if (value instanceof Number) {
476+
return value.toString();
477+
}
478+
return String.valueOf(value);
479+
}
464480
}

src/test/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataServiceTest.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import java.util.List;
3434
import java.util.Map;
3535

36+
import static fr.insee.genesis.domain.service.rawdata.LunaticJsonRawDataService.getValueString;
3637
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
3738

3839
class LunaticJsonRawDataServiceTest {
@@ -570,4 +571,38 @@ private List<String> prepareConvertTest(int rawDataSize, String campaignId, Stri
570571
}
571572
return interrogationIdList;
572573
}
574+
575+
@Test
576+
void getValueString_null_test(){
577+
Object stringObject = null;
578+
579+
Assertions.assertThat(getValueString(stringObject)).isEqualTo("null");
580+
}
581+
582+
@Test
583+
void getValueString_string_test(){
584+
Object stringObject = "test";
585+
586+
Assertions.assertThat(getValueString(stringObject)).isEqualTo("test");
587+
}
588+
@Test
589+
void getValueString_int_test(){
590+
Object intObject = 10;
591+
592+
Assertions.assertThat(getValueString(intObject)).isEqualTo("10");
593+
}
594+
595+
@Test
596+
void getValueString_float_test(){
597+
Object floatObject = 10.111f;
598+
599+
Assertions.assertThat(getValueString(floatObject)).isEqualTo("10.111");
600+
}
601+
602+
@Test
603+
void getValueString_double_test(){
604+
Object doubleObject = 101010101010.111d;
605+
606+
Assertions.assertThat(getValueString(doubleObject)).isEqualTo("101010101010.111");
607+
}
573608
}

0 commit comments

Comments
 (0)