Skip to content

Commit 188d756

Browse files
committed
refactor: method names camel case
1 parent dcb99e2 commit 188d756

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

src/test/java/fr/insee/genesis/domain/service/rawdata/RawResponseServiceUnitTest.java

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,13 @@ void processRawResponses_byCollectionInstrumentId_validation_date_questionnaire_
8888
RawResponseDto.QuestionnaireStateEnum questionnaireState
8989
) {
9090
//GIVEN
91-
processRawResponses_given(questionnaireState);
91+
givenOkCase(questionnaireState);
9292

9393
//WHEN
9494
List<SurveyUnitModel> createdModels = whenProcessByCollectionInstrumentIdAndInterrogationIdList();
9595

9696
//THEN
97-
processRawResponses_then(questionnaireState, createdModels);
97+
processRawResponsesThen(questionnaireState, createdModels);
9898
}
9999

100100
@ParameterizedTest
@@ -105,13 +105,13 @@ void processRawResponses_byCollectionInstrumentIdAndInterrogationList_validation
105105
RawResponseDto.QuestionnaireStateEnum questionnaireState
106106
) {
107107
//GIVEN
108-
processRawResponses_given(questionnaireState);
108+
givenOkCase(questionnaireState);
109109

110110
//WHEN
111111
List<SurveyUnitModel> createdModels = whenProcessRawResponsesCollectionInstrumentId();
112112

113113
//THEN
114-
processRawResponses_then(questionnaireState, createdModels);
114+
processRawResponsesThen(questionnaireState, createdModels);
115115
}
116116

117117
//Non-blocking exception tests
@@ -121,26 +121,26 @@ void processRawResponses_byCollectionInstrumentIdAndInterrogationList_validation
121121
@SneakyThrows
122122
void processRawResponses_byCollectionInstrumentId_invalid_questionnaire_state_test() {
123123
//GIVEN
124-
processRawResponses_given_invalid_questionnaire_state();
124+
givenInvalidQuestionnaireState();
125125

126126
//WHEN
127127
List<SurveyUnitModel> createdModels = whenProcessRawResponsesCollectionInstrumentId();
128128

129129
//THEN
130-
processRawResponses_then_questionnaire_state_null(createdModels);
130+
processRawResponsesThenQuestionnaireStateNull(createdModels);
131131
}
132132
@Test
133133
@DisplayName("Invalid questionnaireState test (process by collection id and interrogation id list)")
134134
@SneakyThrows
135135
void processRawResponses_byCollectionInstrumentIdAndInterrogationList_invalid_questionnaire_state_test() {
136136
//GIVEN
137-
processRawResponses_given_invalid_questionnaire_state();
137+
givenInvalidQuestionnaireState();
138138

139139
//WHEN
140140
List<SurveyUnitModel> createdModels = whenProcessByCollectionInstrumentIdAndInterrogationIdList();
141141

142142
//THEN
143-
processRawResponses_then_questionnaire_state_null(createdModels);
143+
processRawResponsesThenQuestionnaireStateNull(createdModels);
144144
}
145145

146146
//Invalid validationDate
@@ -149,31 +149,31 @@ void processRawResponses_byCollectionInstrumentIdAndInterrogationList_invalid_qu
149149
@SneakyThrows
150150
void processRawResponses_byCollectionId_invalid_validation_date_test(){
151151
//GIVEN
152-
processRawResponses_given_invalid_validation_date();
152+
givenInvalidValidationDate();
153153

154154
//WHEN
155155
List<SurveyUnitModel> createdModels = whenProcessByCollectionInstrumentIdAndInterrogationIdList();
156156

157157
//THEN
158-
processRawResponses_then_validation_date_null(createdModels);
158+
processRawResponsesThenValidationDateNull(createdModels);
159159
}
160160
@Test
161161
@DisplayName("Invalid validationDate test (process by collection id and interrogation id list)")
162162
@SneakyThrows
163163
void processRawResponses_byCollectionIdAndInterrogationIds_invalid_validation_date_test(){
164164
//GIVEN
165-
processRawResponses_given_invalid_validation_date();
165+
givenInvalidValidationDate();
166166

167167
//WHEN
168168
List<SurveyUnitModel> createdModels = whenProcessRawResponsesCollectionInstrumentId();
169169

170170
//THEN
171-
processRawResponses_then_validation_date_null(createdModels);
171+
processRawResponsesThenValidationDateNull(createdModels);
172172
}
173173

174174
//GIVENS
175175
@SneakyThrows
176-
private void processRawResponses_given(RawResponseDto.QuestionnaireStateEnum questionnaireState){
176+
private void givenOkCase(RawResponseDto.QuestionnaireStateEnum questionnaireState){
177177
VariablesMap variablesMap = new VariablesMap();
178178
MetadataModel metadataModel = new MetadataModel();
179179
metadataModel.setVariables(variablesMap);
@@ -209,7 +209,7 @@ private void processRawResponses_given(RawResponseDto.QuestionnaireStateEnum que
209209
doReturn(rawResponses).when(rawResponsePersistencePort).findRawResponses(any(), any(), any());
210210
}
211211
@SneakyThrows
212-
private void processRawResponses_given_invalid_questionnaire_state(){
212+
private void givenInvalidQuestionnaireState(){
213213
VariablesMap variablesMap = new VariablesMap();
214214
MetadataModel metadataModel = new MetadataModel();
215215
metadataModel.setVariables(variablesMap);
@@ -243,7 +243,7 @@ private void processRawResponses_given_invalid_questionnaire_state(){
243243
doReturn(rawResponses).when(rawResponsePersistencePort).findRawResponses(any(), any(), any());
244244
}
245245
@SneakyThrows
246-
private void processRawResponses_given_invalid_validation_date(){
246+
private void givenInvalidValidationDate(){
247247
VariablesMap variablesMap = new VariablesMap();
248248
MetadataModel metadataModel = new MetadataModel();
249249
metadataModel.setVariables(variablesMap);
@@ -294,21 +294,21 @@ private List<SurveyUnitModel> whenProcessRawResponsesCollectionInstrumentId() th
294294
}
295295

296296
//THENS
297-
private void processRawResponses_then(RawResponseDto.QuestionnaireStateEnum questionnaireState,
298-
List<SurveyUnitModel> createdModels) {
297+
private void processRawResponsesThen(RawResponseDto.QuestionnaireStateEnum questionnaireState,
298+
List<SurveyUnitModel> createdModels) {
299299
Assertions.assertThat(createdModels).hasSize(1);
300300
Assertions.assertThat(createdModels.getFirst().getValidationDate()).isEqualTo(
301301
LocalDateTime.parse(TEST_VALIDATION_DATE, DateTimeFormatter.ISO_OFFSET_DATE_TIME)
302302
);
303303
Assertions.assertThat(createdModels.getFirst().getQuestionnaireState()).isEqualTo(questionnaireState);
304304
}
305-
private void processRawResponses_then_validation_date_null(
305+
private void processRawResponsesThenValidationDateNull(
306306
List<SurveyUnitModel> createdModels
307307
){
308308
Assertions.assertThat(createdModels).hasSize(1);
309309
Assertions.assertThat(createdModels.getFirst().getValidationDate()).isNull();
310310
}
311-
private void processRawResponses_then_questionnaire_state_null(List<SurveyUnitModel> createdModels){
311+
private void processRawResponsesThenQuestionnaireStateNull(List<SurveyUnitModel> createdModels){
312312
Assertions.assertThat(createdModels).hasSize(1);
313313
Assertions.assertThat(createdModels.getFirst().getQuestionnaireState()).isNull();
314314
}

0 commit comments

Comments
 (0)