chore: sonar

Author: loichenninger

src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java

@@ -195,7 +195,6 @@ public List<SurveyUnitModel> convertRawData(List<LunaticJsonRawDataModel> rawDat
                 RawDataModelType rawDataModelType = getRawDataModelType(rawData);
 
                 //Get optional fields
-                String contextualId = getContextualId(rawData);
                 Boolean isCapturedIndirectly = getIsCapturedIndirectly(rawData);
                 LocalDateTime validationDate = getValidationDate(rawData);
 
@@ -265,15 +264,6 @@ private static Boolean getIsCapturedIndirectly(LunaticJsonRawDataModel rawData)
 
     }
 
-    private static String getContextualId(LunaticJsonRawDataModel rawData) {
-        try{
-            return rawData.data().get("contextualId") == null ? null : rawData.data().get("contextualId").toString();
-        }catch(Exception e){
-            log.warn("Exception when parsing contextual id : {}}",e.toString());
-            return null;
-        }
-    }
-
     @Override
     public List<LunaticJsonRawDataUnprocessedDto> getUnprocessedDataIds() {
         List<LunaticJsonRawDataUnprocessedDto> dtos = new ArrayList<>();

src/main/java/fr/insee/genesis/infrastructure/adapter/SurveyUnitMongoAdapter.java

@@ -207,7 +207,7 @@ public Set<String> findDistinctQuestionnaireIds() {
 		Set<String> questionnaireIds = new HashSet<>();
 		// Id selection is executed by mongoDB
 		MongoCollection<Document> collection = mongoTemplate.getCollection(Constants.MONGODB_RESPONSE_COLLECTION_NAME);
-		collection.distinct("questionnaireId", String.class).into(questionnaireIds);
+		collection.distinct(QUESTIONNAIRE_ID, String.class).into(questionnaireIds);
 		collection.distinct("collectionInstrumentId", String.class).into(questionnaireIds);
 		questionnaireIds.remove(null);
 		return questionnaireIds;

src/test/java/cucumber/functional_tests/RawDataDefinitions.java

@@ -100,7 +100,7 @@ public class RawDataDefinitions {
     RawResponseInputRepository rawResponseInputRepositoryStub = new RawResponseInputRepository(null, null) {
         @Override
         public void saveAsRawJson(RawResponseDto dto) {
-            // Ne rien faire — stub pour les tests
+            // Do nothing - stub for test
         }
     };
 
@@ -122,9 +122,10 @@ public List<SurveyUnitModel> convertRawResponse(List<RawResponse> rawResponses,
 
         @Override
         public void updateProcessDates(List<SurveyUnitModel> surveyUnitModels) {
-
+            // Do nothing - stub for test
         }
     };
+
     RawResponseController rawResponseController = new RawResponseController(
             lunaticJsonRawDataService, rawResponseApiPortStub, rawResponseInputRepositoryStub
     );