Skip to content

Commit 9338007

Browse files
add Stub implementation definition (TODO impl)
1 parent 5fec1ca commit 9338007

File tree

3 files changed

+33
-4
lines changed

3 files changed

+33
-4
lines changed

src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ public ResponseEntity<List<SurveyUnitSimplified>> getLatestForInterrogationListV
334334

335335
List<SurveyUnitSimplified> results = new ArrayList<>();
336336

337-
//!!!WARNING!!! : FOR PERFORMANCES PURPOSES, WE DONT'MAKE REQUESTS ON INDIVIDUAL ELEMENTS ANYMORE? BUT ON A SUBLIST OF THE INPUTLIST
337+
//!!!WARNING!!! : FOR PERFORMANCES PURPOSES, WE DONT'MAKE REQUESTS ON INDIVIDUAL ELEMENTS ANYMORE, BUT ON A SUBLIST OF THE INPUTLIST
338338
final int SUBBLOCK_SIZE = 100;
339339
int offset = 0;
340340
List<InterrogationId> interrogationIdsSubList = null;
@@ -362,8 +362,6 @@ public ResponseEntity<List<SurveyUnitSimplified>> getLatestForInterrogationListV
362362
}
363363
});
364364

365-
366-
367365
offset = offset + SUBBLOCK_SIZE;
368366
}
369367
long modeLoopEndTimeStamp = System.currentTimeMillis();

src/main/java/fr/insee/genesis/infrastructure/repository/SurveyUnitMongoDBRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public interface SurveyUnitMongoDBRepository extends MongoRepository<SurveyUnitD
3434
* @author Adrien Marchal
3535
*/
3636
@Query(value = "{ 'questionnaireId' : ?0}", count = true)
37-
long countInterrogationIdsByQuestionnaireId(String campaignId);
37+
long countInterrogationIdsByQuestionnaireId(String questionnaireId);
3838

3939

4040
/**

src/test/java/fr/insee/genesis/stubs/SurveyUnitPersistencePortStub.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,17 @@ public List<SurveyUnitModel> findByIds(String interrogationId, String questionna
3030
return surveyUnitModelList;
3131
}
3232

33+
//========= OPTIMISATIONS PERFS (START) ==========
34+
/**
35+
* @author Adrien Marchal
36+
*/
37+
public List<SurveyUnitModel> findBySetOfIdsAndQuestionnaireIdAndMode(String questionnaireId, String mode, List<String> interrogationIdSet) {
38+
//TODO : TO BE IMPLEMENTED
39+
return new ArrayList<SurveyUnitModel>();
40+
}
41+
//========= OPTIMISATIONS PERFS (START) ==========
42+
43+
3344
@Override
3445
public List<SurveyUnitModel> findByInterrogationId(String interrogationId) {
3546
List<SurveyUnitModel> surveyUnitModelList = new ArrayList<>();
@@ -78,6 +89,26 @@ public List<SurveyUnitModel> findInterrogationIdsByQuestionnaireId(String questi
7889
return surveyUnitModelList;
7990
}
8091

92+
93+
//======== OPTIMISATIONS PERFS (START) ========
94+
/**
95+
* @author Adrien Marchal
96+
*/
97+
public long countInterrogationIdsByQuestionnaireId(String questionnaireId) {
98+
//TODO : TO BE IMPLEMENTED
99+
return 0L;
100+
}
101+
102+
/**
103+
* @author Adrien Marchal
104+
*/
105+
public List<SurveyUnitModel> findPageableInterrogationIdsByQuestionnaireId(String questionnaireId, Long skip, Long limit) {
106+
//TODO : TO BE IMPLEMENTED
107+
return new ArrayList<SurveyUnitModel>();
108+
}
109+
//======= OPTIMISATIONS PERFS (END) =========
110+
111+
81112
@Override
82113
public List<SurveyUnitModel> findInterrogationIdsByCampaignId(String campaignId) {
83114
List<SurveyUnitModel> surveyUnitModelList = new ArrayList<>();

0 commit comments

Comments
 (0)