Merge pull request #311 from InseeFr/devGetReview

Get review indicator (for NOQUAL Perret)

Author: alexisszmundy

CHANGELOG.md

@@ -1,4 +1,6 @@
 # Changelog
+## 1.12.0 [TODO]
+- Get review indicator endpoint
 
 ## 1.11.0 [2025-10-20]
 ### Added

src/main/java/fr/insee/genesis/controller/rest/DataProcessingContextController.java

@@ -46,11 +46,11 @@ public class DataProcessingContextController {
 
     @Operation(summary = "Create or update a data processing context")
     @PutMapping(path = "/review")
-    @PreAuthorize("hasAnyRole('USER_BACK_OFFICE','SCHEDULER')")
+    @PreAuthorize("hasAnyRole('USER_PLATINE', 'USER_BACK_OFFICE', 'SCHEDULER')")
     public ResponseEntity<Object> saveContext(
             @Parameter(description = "Identifier of the partition", required = true) @RequestParam("partitionId") String partitionId,
             @Parameter(description = "Allow reviewing") @RequestParam(value = "withReview", defaultValue = "false") Boolean withReview
-    ) {
+    ){
         try {
             withReview = withReview != null && withReview; //False if null
             dataProcessingContextApiPort.saveContext(partitionId, withReview);
@@ -60,6 +60,20 @@ public ResponseEntity<Object> saveContext(
         return ResponseEntity.ok().build();
     }
 
+    @Operation(summary = "Returns partition review indicator")
+    @GetMapping(path = "/review")
+    @PreAuthorize("hasAnyRole('USER_BACK_OFFICE','SCHEDULER','USER_PLATINE')")
+    public ResponseEntity<Object> getReviewIndicator(
+            @Parameter(description = "Identifier of the partition", required = true) @RequestParam("partitionId") String partitionId
+    ){
+        try {
+            boolean withReview = dataProcessingContextApiPort.getReviewByPartitionId(partitionId);
+            return ResponseEntity.ok(withReview);
+        }catch (GenesisException e){
+            return new ResponseEntity<>(e.getMessage(), HttpStatusCode.valueOf(e.getStatus()));
+        }
+    }
+
     @Operation(summary = "Schedule a Kraftwerk execution")
     @PutMapping(path = "/schedules")
     @PreAuthorize("hasRole('USER_KRAFTWERK')")

src/main/java/fr/insee/genesis/domain/ports/api/DataProcessingContextApiPort.java

@@ -33,4 +33,11 @@ void saveKraftwerkExecutionSchedule(String partitionId,
     DataProcessingContextModel getContext(String interrogationId) throws GenesisException;
     DataProcessingContextModel getContextByPartitionId(String partitionId) throws GenesisException;
     List<String> getPartitionIds(boolean withReview);
+
+    /**
+     * Gets the review indicator for a partition
+     * @param partitionId id of the partition
+     * @return the review indicator stored in genesis
+     */
+    boolean getReviewByPartitionId(String partitionId) throws GenesisException;
 }

src/main/java/fr/insee/genesis/domain/service/context/DataProcessingContextService.java

@@ -10,6 +10,7 @@
 import fr.insee.genesis.domain.ports.spi.DataProcessingContextPersistancePort;
 import fr.insee.genesis.domain.ports.spi.SurveyUnitPersistencePort;
 import fr.insee.genesis.exceptions.GenesisException;
+import fr.insee.genesis.infrastructure.document.context.DataProcessingContextDocument;
 import fr.insee.genesis.infrastructure.mappers.DataProcessingContextMapper;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -168,7 +169,7 @@ public DataProcessingContextModel getContext(String interrogationId) throws Gene
 
     @Override
     public DataProcessingContextModel getContextByPartitionId(String partitionId){
-        return  DataProcessingContextMapper.INSTANCE.documentToModel(
+        return DataProcessingContextMapper.INSTANCE.documentToModel(
                 dataProcessingContextPersistancePort.findByPartitionId(partitionId)
         );
     }
@@ -184,4 +185,16 @@ public List<String> getPartitionIds(boolean withReview){
         }
         return partitionIds;
     }
+
+    @Override
+    public boolean getReviewByPartitionId(String partitionId) throws GenesisException {
+        DataProcessingContextDocument dataProcessingContextDocument =
+                dataProcessingContextPersistancePort.findByPartitionId(partitionId);
+        if(dataProcessingContextDocument == null){
+            throw new GenesisException(404, "Data processing context not found");
+        }
+        return DataProcessingContextMapper.INSTANCE.documentToModel(
+                dataProcessingContextPersistancePort.findByPartitionId(partitionId)
+        ).isWithReview();
+    }
 }

src/test/java/fr/insee/genesis/controller/rest/DataProcessingContextControllerTest.java

@@ -17,6 +17,8 @@
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.springframework.http.ResponseEntity;
 
 import java.io.IOException;
@@ -442,6 +444,41 @@ void deleteExpiredScheduleTest_appendLog() throws IOException, GenesisException
                 .toFile()).exists().content().isNotEmpty().contains("2000","2001");
     }
 
+    @ParameterizedTest
+    @ValueSource(booleans = {false, true})
+    void getReview_test(boolean withReview){
+        //GIVEN
+        String partitionId = "TESTPARTITION";
+        dataProcessingContextPersistancePortStub.getMongoStub().add(
+                new DataProcessingContextDocument(
+                        "TESTPARTITION",
+                        new ArrayList<>(),
+                        withReview
+                )
+        );
+
+        //WHEN
+        ResponseEntity<Object> response = dataProcessingContextController.getReviewIndicator(partitionId);
+
+        //THEN
+        Assertions.assertThat(response.getStatusCode().value()).isEqualTo(200);
+        Assertions.assertThat(response.getBody().getClass()).isEqualTo(Boolean.class);
+        Assertions.assertThat((Boolean) response.getBody()).isEqualTo(withReview);
+    }
+
+    @Test
+    void getReview_no_context_test(){
+        //WHEN
+        ResponseEntity<Object> response = dataProcessingContextController.getReviewIndicator(
+                "TESTPARTITIONIDNOCONTEXT"
+        );
+
+        //THEN
+        Assertions.assertThat(response.getStatusCode().value()).isEqualTo(404);
+    }
+
+
+    //UTILITY
     private void addNewDocumentToStub() {
         DataProcessingContextDocument dataProcessingContextDocumentTest = new DataProcessingContextDocument(
                 "TESTSURVEY",