Add exception management + fix after mongo tests

Author: alexisszmundy

src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java

@@ -234,40 +234,44 @@ public ResponseEntity<Object> processJsonRawData(
             @RequestParam("campaignName") String campaignName,
             @RequestParam("questionnaireId") String questionnaireId,
             @RequestBody List<String> idUEList
-    ) throws GenesisException {
+    ){
         log.info("Try to get process raw JSON datas for campaign {} and {} idUEs", campaignName, idUEList.size());
 
         int dataCount = 0;
         List<GenesisError> errors = new ArrayList<>();
 
-        List<Mode> modesList = controllerUtils.getModesList(campaignName, null);
-        for(Mode mode: modesList){
-            //Load and save metadatas into database, throw exception if none
-            VariablesMap variablesMap = readMetadatas(campaignName, mode, errors, true);
-            if(variablesMap == null){
-                throw new GenesisException(400,
-                        "Error during metadata parsing for mode %s :%n%s"
-                                .formatted(mode, errors.getLast().toString())
+        try {
+            List<Mode> modesList = controllerUtils.getModesList(campaignName, null);
+            for (Mode mode : modesList) {
+                //Load and save metadatas into database, throw exception if none
+                VariablesMap variablesMap = readMetadatas(campaignName, mode, errors, true);
+                if (variablesMap == null) {
+                    throw new GenesisException(400,
+                            "Error during metadata parsing for mode %s :%n%s"
+                                    .formatted(mode, errors.getLast().getMessage())
+                    );
+                }
+
+                //Save converted data
+                List<SurveyUnitModel> surveyUnitModels = lunaticJsonRawDataApiPort.parseRawData(
+                        campaignName,
+                        mode,
+                        idUEList,
+                        variablesMap
                 );
-            }
+                surveyUnitService.saveSurveyUnits(surveyUnitModels);
 
-            //Save converted data
-            List<SurveyUnitModel> surveyUnitModels = lunaticJsonRawDataApiPort.parseRawData(
-                    campaignName,
-                    mode,
-                    idUEList,
-                    variablesMap
-            );
-            surveyUnitService.saveSurveyUnits(surveyUnitModels);
-
-            //Update process dates
-            lunaticJsonRawDataApiPort.updateProcessDates(surveyUnitModels);
-
-            //Save metadatas
-            variableTypeApiPort.saveMetadatas(campaignName, questionnaireId, mode, variablesMap);
-            dataCount += surveyUnitModels.size();
+                //Update process dates
+                lunaticJsonRawDataApiPort.updateProcessDates(surveyUnitModels);
+
+                //Save metadatas
+                variableTypeApiPort.saveMetadatas(campaignName, questionnaireId, mode, variablesMap);
+                dataCount += surveyUnitModels.size();
+            }
+            return ResponseEntity.ok("%d document(s) processed".formatted(dataCount));
+        }catch (GenesisException e){ //TODO replace with spring exception handler
+            return ResponseEntity.status(e.getStatus()).body(e.getMessage());
         }
-        return ResponseEntity.ok("%d document(s) processed".formatted(dataCount));
     }
 
 

src/main/java/fr/insee/genesis/controller/utils/ControllerUtils.java

@@ -24,7 +24,7 @@ public ControllerUtils(FileUtils fileUtils) {
 	public List<Mode> getModesList(String campaign, Mode modeSpecified) throws GenesisException {
 		// If a mode is specified, we treat only this mode.
 		// If no mode is specified, we treat all modes in the campaign.
-		// If no node is specified and no specs are found, we return an error
+		// If no mode is specified and no specs are found, we return an error
 		if (modeSpecified != null){
 			return Collections.singletonList(modeSpecified);
 		}

src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java

@@ -5,6 +5,7 @@
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import fr.insee.bpm.metadata.model.VariablesMap;
+import fr.insee.genesis.Constants;
 import fr.insee.genesis.controller.dto.rawdata.LunaticJsonRawDataUnprocessedDto;
 import fr.insee.genesis.domain.model.surveyunit.CollectedVariable;
 import fr.insee.genesis.domain.model.surveyunit.DataState;
@@ -96,7 +97,9 @@ public List<SurveyUnitModel> parseRawData(
                 CollectedVariable collectedVariable = CollectedVariable.collectedVariableBuilder()
                         .idVar(variableName)
                         .values(new ArrayList<>())
-                        .idLoop(variablesMap.getVariable(variableName).getGroupName())
+                        .idLoop(variablesMap.getVariable(variableName) == null ?
+                                Constants.ROOT_GROUP_NAME : //TODO What do we do if null ? Exception ?
+                                variablesMap.getVariable(variableName).getGroupName())
                         .idParent(LoopIdentifier.getRelatedVariableName(variableName, variablesMap))
                         .build();
 

src/main/java/fr/insee/genesis/domain/service/variabletype/VariableTypeService.java

@@ -10,7 +10,6 @@
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.stereotype.Service;
 
-import java.util.HashMap;
 import java.util.LinkedHashMap;
 
 @Service