Skip to content

Commit d325142

Browse files
committed
refactor: Removed response body in logs
1 parent 1ecd681 commit d325142

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

src/main/java/fr/insee/genesis/configuration/LogRequestFilter.java

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,11 @@ public class LogRequestFilter extends OncePerRequestFilter {
2626
"CALL {} {} - "
2727
// + "Content-Type : {} \n "
2828
// + "Headers : {} \n "
29-
+ "Params : {} - "
30-
+ "Body : {} \n ";
29+
+ "Params : {}";
3130

3231
private static final String RESPONSE_MESSAGE_FORMAT =
3332
"END {} {} - "
34-
+ "Status : {} - "
35-
// + "Content-Type : {} \n "
36-
// + "Headers : {} \n "
37-
+ "Body : {} \n";
38-
private static final int MAX_RESPONSE_SIZE = 10000;
33+
+ "Status : {} - ";
3934

4035
@Override
4136
protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain)
@@ -46,28 +41,25 @@ protected void doFilterInternal(HttpServletRequest request, HttpServletResponse
4641
ContentCachingResponseWrapper resp = new ContentCachingResponseWrapper(response);
4742

4843
log.info(REQUEST_MESSAGE_FORMAT,
49-
req.getMethod(), req.getRequestURI(),
44+
req.getMethod(), req.getRequestURI(),
5045
// req.getContentType(),
5146
// new ServletServerHttpRequest(req).getHeaders(), //Headers
52-
request.getQueryString(),//Params
53-
new String(req.getContentAsByteArray(), StandardCharsets.UTF_8));//Body
47+
request.getQueryString());//Params
5448

5549

5650
// Execution request chain
5751
filterChain.doFilter(req, resp);
5852

5953

6054
log.info(RESPONSE_MESSAGE_FORMAT,
61-
req.getMethod(), req.getRequestURI(),
62-
resp.getStatus(),
63-
getResponseBody(req, resp)); //Body
55+
req.getMethod(), req.getRequestURI(),
56+
resp.getStatus()); //Body
6457

6558
// Finally remember to respond to the client with the cached data.
6659
resp.copyBodyToResponse();
6760
}
6861

6962
private String getResponseBody(ContentCachingRequestWrapper req, ContentCachingResponseWrapper resp) {
70-
if(req.getContentAsByteArray().length >= MAX_RESPONSE_SIZE) return "Swagger response too long";
7163
if (req.getRequestURI().contains("swagger-ui") ||req.getRequestURI().contains("api-docs")) return "Hidden Swagger response";
7264
return new String(resp.getContentAsByteArray(), StandardCharsets.UTF_8);
7365
}

0 commit comments

Comments
 (0)