Skip to content

Commit ef1204f

Browse files
committed
feat: WIP modelefiliere add last extraction date
1 parent 95b7a83 commit ef1204f

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

src/main/java/fr/insee/genesis/controller/rest/JsonExtractionController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ public class JsonExtractionController {
3030
@PutMapping(path = "/json")
3131
@PreAuthorize("hasAnyRole('USER_KRAFTWERK','SCHEDULER')")
3232
public ResponseEntity<String> saveLastJsonExtractionDate(
33-
@RequestParam("questionnaireId") String questionnaireId,
33+
@RequestParam("collectionInstrumentId") String collectionInstrumentId,
3434
@RequestParam(value = "mode", required = false) Mode mode){
3535
LocalDateTime extractDate = LocalDateTime.now();
3636
LastJsonExtractionModel extract = LastJsonExtractionModel.builder()
37-
.questionnaireModelId(questionnaireId)
37+
.collectionInstrumentId(collectionInstrumentId)
3838
.mode(mode)
3939
.lastExtractionDate(extractDate)
4040
.build();
@@ -46,10 +46,10 @@ public ResponseEntity<String> saveLastJsonExtractionDate(
4646
@GetMapping(path = "/json")
4747
@PreAuthorize("hasAnyRole('USER_KRAFTWERK','SCHEDULER')")
4848
public ResponseEntity<LastExtractionResponseDto> getLastJsonExtractionDate(
49-
@RequestParam("questionnaireId") String questionnaireId,
49+
@RequestParam("collectionInstrumentId") String collectionInstrumentId,
5050
@RequestParam(value = "mode", required = false) Mode mode){
5151
try{
52-
LastJsonExtractionModel lastJsonExtraction = lastJsonExtractionApiPort.getLastExtractionDate(questionnaireId,mode);
52+
LastJsonExtractionModel lastJsonExtraction = lastJsonExtractionApiPort.getLastExtractionDate(collectionInstrumentId,mode);
5353
return ResponseEntity.ok(new LastExtractionResponseDto(lastJsonExtraction.getLastExtractionDate()));
5454
} catch (GenesisException e){
5555
return ResponseEntity.notFound().build();

src/main/java/fr/insee/genesis/domain/model/extraction/json/LastJsonExtractionModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
public class LastJsonExtractionModel {
1717
@Id
1818
private String id; //Used to remove warning
19-
String questionnaireModelId;
19+
String collectionInstrumentId;
2020
Mode mode;
2121
LocalDateTime lastExtractionDate;
2222
}

src/main/java/fr/insee/genesis/domain/ports/api/LastJsonExtractionApiPort.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
public interface LastJsonExtractionApiPort {
88
void recordDate(LastJsonExtractionModel extraction);
99

10-
LastJsonExtractionModel getLastExtractionDate(String questionnaireModelId, Mode mode) throws GenesisException;
10+
LastJsonExtractionModel getLastExtractionDate(String collectionInstrumentId, Mode mode) throws GenesisException;
1111
}

src/main/java/fr/insee/genesis/domain/ports/spi/LastJsonExtractionPersistencePort.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66

77
public interface LastJsonExtractionPersistencePort {
88
void save(LastJsonExtractionModel extraction);
9-
LastJsonExtractionModel getLastExecutionDate(String questionnaireModelId, Mode mode) throws GenesisException;
9+
LastJsonExtractionModel getLastExecutionDate(String collectionInstrumentId, Mode mode) throws GenesisException;
1010
}

src/main/java/fr/insee/genesis/domain/service/extraction/LastJsonExtractionService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ public LastJsonExtractionService(LastJsonExtractionPersistencePort extractionPer
2525
@Override
2626
public void recordDate(LastJsonExtractionModel extraction) {
2727
// Create a unique ID based on the questionnaire and the mode.
28-
extraction.setId(String.format("%s_%s",extraction.getQuestionnaireModelId(),extraction.getMode()));
28+
extraction.setId(String.format("%s_%s",extraction.getCollectionInstrumentId(),extraction.getMode()));
2929

3030
// save() does an insert if the id doesn't exist, otherwise an update
3131
extractionPersistencePort.save(extraction);
3232
}
3333

3434
@Override
35-
public LastJsonExtractionModel getLastExtractionDate(String questionnaireModelId, Mode mode) throws GenesisException {
36-
return extractionPersistencePort.getLastExecutionDate(questionnaireModelId,mode);
35+
public LastJsonExtractionModel getLastExtractionDate(String collectionInstrumentId, Mode mode) throws GenesisException {
36+
return extractionPersistencePort.getLastExecutionDate(collectionInstrumentId,mode);
3737
}
3838

3939

src/main/java/fr/insee/genesis/infrastructure/adapter/LastJsonExtractionMongoAdapter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ public void save(LastJsonExtractionModel extraction) {
3232
}
3333

3434
@Override
35-
public LastJsonExtractionModel getLastExecutionDate(String questionnaireModelId, Mode mode) throws GenesisException {
36-
String id = String.format("%s_%s",questionnaireModelId, mode);
35+
public LastJsonExtractionModel getLastExecutionDate(String collectionInstrumentId, Mode mode) throws GenesisException {
36+
String id = String.format("%s_%s",collectionInstrumentId, mode);
3737
Optional<LastJsonExtractionDocument> extraction = extractionRepository.findById(id);
3838
if (extraction.isPresent()) {
3939
return LastJsonExtractionDocumentMapper.INSTANCE.documentToModel(extraction.get());
4040
} else {
41-
String message = String.format("No extraction date found for questionnaire %s and mode %s",questionnaireModelId,mode==null?null:mode.getModeName());
41+
String message = String.format("No extraction date found for collection instrument %s and mode %s",collectionInstrumentId,mode==null?null:mode.getModeName());
4242
throw new GenesisException(404,message);
4343
}
4444
}

src/main/java/fr/insee/genesis/infrastructure/document/extraction/json/LastJsonExtractionDocument.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class LastJsonExtractionDocument {
1414

1515
@Id
1616
private String id;
17-
private String questionnaireModelId;
17+
private String collectionInstrumentId;
1818
private Mode mode;
1919
private LocalDateTime lastExtractionDate;
2020

0 commit comments

Comments
 (0)