fix: review adjustments

Author: noahboerger

pom.xml

@@ -163,9 +163,7 @@
                 <configuration>
                     <!-- Sets the VM argument line used when unit tests are run. -->
                     <!-- Suppress UnresolvedMavenProperty. -->
-                    <argLine>-Xms1g -Xmx2g --add-opens fr.insee.vtl.engine/fr.insee.vtl.engine.utils.dag=ALL-UNNAMED
-                        @{surefireArgLine}
-                    </argLine>
+                    <argLine>-Xms1g -Xmx2g @{surefireArgLine}</argLine>
                     <useSystemClassLoader>false</useSystemClassLoader>
                     <forkedProcessExitTimeoutInSeconds>180</forkedProcessExitTimeoutInSeconds>
                     <forkCount>1</forkCount>

vtl-engine/src/main/java/fr/insee/vtl/engine/VtlSyntaxPreprocessor.java

@@ -93,8 +93,8 @@ public void checkForMultipleAssignments() throws VtlScriptException {
             .toList();
 
     if (!multiProducedExceptions.isEmpty()) {
-      throw VtlMultiErrorScriptException.usingTheFirstMainPositionExceptionAsCause(
-          multiProducedExceptions);
+      throw VtlMultiErrorScriptException.of(
+          multiProducedExceptions.toArray(new VtlScriptException[] {}));
     }
   }
 

vtl-engine/src/main/java/fr/insee/vtl/engine/utils/dag/DAGBuilder.java

@@ -96,7 +96,7 @@ private VtlScriptException buildVTLScriptExceptionForCycles(List<Set<DAGStatemen
                         startContext))
             .toList();
 
-    return VtlMultiErrorScriptException.usingTheFirstMainPositionExceptionAsCause(cycleExceptions);
+    return VtlMultiErrorScriptException.of(cycleExceptions.toArray(new VtlScriptException[] {}));
   }
 
   private String buildAssignmentChain(Set<DAGStatement> cycle) {

vtl-model/src/main/java/fr/insee/vtl/model/Positioned.java

@@ -1,6 +1,7 @@
 package fr.insee.vtl.model;
 
 import java.io.Serializable;
+import java.util.Comparator;
 
 public interface Positioned {
 
@@ -10,26 +11,12 @@ record Position(Integer startLine, Integer endLine, Integer startColumn, Integer
       implements Serializable, Comparable<Position> {
     @Override
     public int compareTo(Position other) {
-      if (this.startLine != null && other.startLine != null) {
-        int cmp = this.startLine.compareTo(other.startLine);
-        if (cmp != 0) return cmp;
-      }
-
-      if (this.endLine != null && other.endLine != null) {
-        int cmp = this.endLine.compareTo(other.endLine);
-        if (cmp != 0) return cmp;
-      }
-
-      if (this.startColumn != null && other.startColumn != null) {
-        int cmp = this.startColumn.compareTo(other.startColumn);
-        if (cmp != 0) return cmp;
-      }
-
-      if (this.endColumn != null && other.endColumn != null) {
-        return this.endColumn.compareTo(other.endColumn);
-      }
-
-      return 0;
+      return Comparator.nullsLast(
+              Comparator.comparing(Position::startLine)
+                  .thenComparing(Position::endLine)
+                  .thenComparing(Position::startColumn)
+                  .thenComparing(Position::endColumn))
+          .compare(this, other);
     }
   }
 }

vtl-model/src/main/java/fr/insee/vtl/model/exceptions/VtlMultiErrorScriptException.java

@@ -19,10 +19,9 @@ public class VtlMultiErrorScriptException extends VtlScriptException {
    * @param main The main-Exception that is getting the role of being the Exception cause.
    * @param others The other VtlScriptExceptions, that also occurred.
    */
-  public VtlMultiErrorScriptException(
-      VtlScriptException main, Collection<? extends VtlScriptException> others) {
+  public VtlMultiErrorScriptException(VtlScriptException main, VtlScriptException... others) {
     super(main, main.getPosition());
-    this.others = others;
+    this.others = List.of(others);
   }
 
   /**
@@ -34,24 +33,24 @@ public VtlMultiErrorScriptException(
    *     VtlMultiErrorScriptException using the one with first Position as cause
    * @throws IllegalArgumentException when the occurred Exceptions are empty
    */
-  public static VtlScriptException usingTheFirstMainPositionExceptionAsCause(
-      List<? extends VtlScriptException> allOccurred) {
-    if (allOccurred.size() == 1) {
-      return allOccurred.get(0);
+  public static VtlScriptException of(VtlScriptException... allOccurred) {
+    if (allOccurred.length == 1) {
+      return allOccurred[0];
     }
 
     final VtlScriptException firstOccurred =
-        allOccurred.stream()
+        Arrays.stream(allOccurred)
             .min(Comparator.comparing(VtlScriptException::getPosition))
             .orElseThrow(
                 () ->
                     new IllegalArgumentException(
                         "Can not build a VTLMultiErrorScriptException without any VTLScriptException as cause"));
 
-    Set<VtlScriptException> rest = new HashSet<>(allOccurred);
+    Set<VtlScriptException> rest = new HashSet<>(Arrays.asList(allOccurred));
     rest.remove(firstOccurred);
 
-    return new VtlMultiErrorScriptException(firstOccurred, rest);
+    return new VtlMultiErrorScriptException(
+        firstOccurred, rest.toArray(new VtlScriptException[] {}));
   }
 
   /**