Skip to content

Commit 2f5197b

Browse files
authored
fix: avoid useless data update & display correctly welcome modal (#45)
* fix: avoid useless data update & display correctly welcome modal * docs: update changelog
1 parent c3c1e79 commit 2f5197b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- Welcome modal is now displayed correctly.
13+
1014
## [1.0.0](https://github.com/InseeFr/walking-papers/releases/tag/0.1.0) - 2026-01-16
1115

1216
### Added

src/features/orchestrator/Orchestrator.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,7 @@ export default function Orchestrator(props: OrchestratorProps) {
150150
}, [currentPage, pageTag])
151151

152152
useEffect(() => {
153-
return () => {
154-
triggerDataAndStateUpdate()
155-
setOpenModal(shouldDisplayWelcomeModal(initialState, initialCurrentPage))
156-
}
153+
setOpenModal(shouldDisplayWelcomeModal(initialState, initialCurrentPage))
157154
}, [])
158155

159156
const triggerDataAndStateUpdate = async (isLogout: boolean = false) => {

0 commit comments

Comments
 (0)