Skip to content

Commit 5562bf2

Browse files
committed
[chromadb] Fix and properly defaults subchart fullNameOverride
1 parent 369a96d commit 5562bf2

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

charts/chromadb/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sources:
1212
- https://github.com/chroma-core/chroma
1313
- https://github.com/amikos-tech/chromadb-chart/
1414
type: application
15-
version: 1.0.7
15+
version: 1.0.8
1616
appVersion: "0.6.3"
1717
dependencies:
1818
- name: chromadb

charts/chromadb/templates/cleanup-job.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@ spec:
6161
- -c
6262
- |
6363
kubectl delete secret {{ .Values.chromadb.chromadb.auth.existingSecret | default "chromadb-auth" | quote }} --ignore-not-found --wait=false
64-
{{- if not .Values.savePersistentVolume }}
64+
{{- if not .Values.chromadb.savePersistentVolume }}
6565
kubectl delete pvc {{ printf "data-%s-0" (include "chart.fullname" .Subcharts.chromadb) | quote }} --ignore-not-found --wait=false
6666
{{- end }}

charts/chromadb/values.schema.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,25 @@
22
"$schema": "http://json-schema.org/draft-07/schema",
33
"type": "object",
44
"properties": {
5-
"fullnameOverride": {
6-
"title": "Name of the ChromaDB service",
7-
"description": "Will reuse data from a previous ChromaDB service with the same name",
8-
"type": "string",
9-
"default": "ChromaDB"
10-
},
11-
"savePersistentVolume": {
12-
"title": "Save your data on service deletion",
13-
"type": "boolean",
14-
"default": true,
15-
"hidden": {
16-
"value": "",
17-
"path": "fullnameOverride"
18-
}
19-
},
205
"chromadb": {
216
"title": "ChromaDB",
227
"type": "object",
238
"properties": {
9+
"fullnameOverride": {
10+
"title": "Name of the ChromaDB service",
11+
"description": "Will reuse data from a previous ChromaDB service with the same name",
12+
"type": "string",
13+
"default": "chromadb"
14+
},
15+
"savePersistentVolume": {
16+
"title": "Save your data on service deletion",
17+
"type": "boolean",
18+
"default": true,
19+
"hidden": {
20+
"value": "",
21+
"path": "fullnameOverride"
22+
}
23+
},
2424
"image": {
2525
"title": "Docker image",
2626
"type": "object",

charts/chromadb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
chromadb:
2+
fullnameOverride: "chromadb"
3+
savePersistentVolume: true
24
replicaCount: 1
35
image:
46
repository: ghcr.io/chroma-core/chroma
@@ -52,7 +54,3 @@ discovery:
5254

5355
userPreferences:
5456
language: "en"
55-
56-
nameOverride: ""
57-
fullnameOverride: "ChromaDB"
58-
savePersistentVolume: true

0 commit comments

Comments
 (0)