[ALL] Add a pre-commit default configuration (#143)

Author: Gaspi

.github/workflows/realease.yml

@@ -47,4 +47,4 @@ jobs:
       - name: Run chart-releaser
         uses: helm/[email protected]
         env:
-          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

.pre-commit-config.yaml

@@ -0,0 +1,40 @@
+repos:
+- repo: https://github.com/Gaspi/pre-commit-hooks
+  rev: v0.3
+  hooks:
+  # Validate schemas using the jsonschema.validators package
+  - id: validate-json-schemas
+    args:
+    # Forbid legacy https://json-schema.org/draft/2020-12/schema schema validator and suggest Draft 7 instead
+    - --forbid-legacy
+  # Ensure technically facultative attribute (such as `type`) are systematically specified
+  - id: missing-attributes-schemas
+    args:
+    # Also require `items` to be systematically specified for arrays
+    - --check-items
+    # Also require `properties` to be systematically specified for object
+    - --check-properties
+    # Also require `properties` to be systematically specified for object
+    - --check-defaults
+  - id: version-bump
+    args:
+    - --branch
+    - main
+
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v5.0.0
+  hooks:
+  # Check yaml files except for Helm templates
+  - id: check-yaml
+    exclude: "/(templates|tests)/"
+  # Check empty new line before EOF (ignore generated charts)
+  - id: end-of-file-fixer
+  # Check trailing whitespaces (ignore generated charts)
+  - id: trailing-whitespace
+
+# Run `helm lint` on all (modified) charts: this may require a manual `helm dep update`:
+# ls charts | xargs -i{} bash -c "cd charts/{} && helm dep update"
+- repo: https://github.com/gruntwork-io/pre-commit
+  rev: v0.1.15
+  hooks:
+  - id: helmlint

README.md

@@ -2,14 +2,14 @@
 
 This collection of Helm Charts is tailored for datascientists !
 Most of this helm-charts are based on the [bitnami charts](https://github.com/bitnami/charts).
-It is primarly designed to work with [Onyxia](https://github.com/inseefrlab/onyxia) and we recommand you to use those from bitnami if you don't use Onyxia.  
-See the other repository ([Helm charts](https://github.com/inseefrlab/helm-charts-interactive-services)) for interactive focused charts.  
+It is primarly designed to work with [Onyxia](https://github.com/inseefrlab/onyxia) and we recommand you to use those from bitnami if you don't use Onyxia.
+See the other repository ([Helm charts](https://github.com/inseefrlab/helm-charts-interactive-services)) for interactive focused charts.
 
 To use the repo on helm (version 3+) :
 ```
 helm repo add inseefrlab-datascience https://inseefrlab.github.io/helm-charts-databases
-```  
+```
 
 The repo is also browsable directly https://inseefrlab.github.io/helm-charts-databases/index.yaml
 
-Contributions are welcome, feel free to open issues or submit pull requests :) 
+Contributions are welcome, feel free to open issues or submit pull requests :)

charts/cloudbeaver-chart/Chart.yaml

@@ -22,7 +22,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.0.5
+version: 2.0.6
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

charts/cloudbeaver-chart/templates/configmap-cb.yaml

@@ -30,7 +30,7 @@ data:
             password : {{ .Values.postgresql.auth.password }} ,
             initialDataConfiguration: "conf/initial-data.conf",
             pool: {
-                minIdleConnections: 4, 
+                minIdleConnections: 4,
                 maxIdleConnections: 10,
                 maxConnections: 100,
                 validationQuery: "SELECT 1"
@@ -68,4 +68,4 @@ data:
 
     }
 
-    }
+    }

charts/cloudbeaver-chart/templates/configmap-product.yaml

@@ -33,4 +33,4 @@ data:
             disabled: false
         },
         sql.proposals.insert.table.alias: true
-    }
+    }

charts/cloudbeaver-chart/templates/deployment.yaml

@@ -72,10 +72,10 @@ spec:
               port: http
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
-      
+
       volumes:
         - name: cb-config
-          configMap: 
+          configMap:
             name: {{ include "library-chart.fullname" . }}-cb-config
         - name: product-config
           configMap:
@@ -97,12 +97,12 @@ spec:
               until printf "." && nc -z -w 2 {{ .Values.postgresql.fullnameOverride }} 5432; do
                   sleep 2;
               done;
-              echo 'PostgreSQL OK ✓'  
+              echo 'PostgreSQL OK ✓'
           resources:
             requests:
               cpu: "0.05"
               memory: "128Mi"
-      {{- with .Values.nodeSelector }} 
+      {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}
       {{- end }}

charts/cloudbeaver-chart/templates/ingress.yaml

@@ -1 +1 @@
-{{ include "library-chart.ingress" . }}
+{{ include "library-chart.ingress" . }}

charts/cloudbeaver-chart/templates/networkpolicy-ingress.yaml

@@ -1 +1 @@
-{{ include "library-chart.networkPolicyIngress" . }}
+{{ include "library-chart.networkPolicyIngress" . }}

charts/cloudbeaver-chart/templates/networkpolicy.yaml

@@ -1 +1 @@
-{{ include "library-chart.networkPolicy" . }}
+{{ include "library-chart.networkPolicy" . }}