Skip to content

Commit 4ee66e3

Browse files
committed
New linting pre-commit script
1 parent b090e8d commit 4ee66e3

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

.pre-commit-config.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
repos:
22
- repo: https://github.com/Gaspi/pre-commit-hooks
3-
rev: v0.3
3+
rev: v0.4
44
hooks:
55
# Validate schemas using the jsonschema.validators package
66
- id: validate-json-schemas
@@ -21,13 +21,16 @@ repos:
2121
# Just fail if any modification occurs to files in the charts/ folder
2222
# other than jupyter-py{spark,thon}, rstudio[-sparkr] or vscode-py{thon,spark}
2323
- id: just-fail
24-
files: "charts/(?!(library-chart|(jupyter-py(spark|thon)/.*)|(rstudio(-sparkr)?/.*)|(vscode-py(thon|spark)/.*)))"
24+
exclude: "^((?!charts/)|(charts/(library-chart|jupyter-python|jupyter-pyspark|rstudio|rstudio-sparkr|vscode-python|vscode-pyspark)/)).*$"
2525
# Ensure that the Chart.yaml version is bumped in all charts with staged modifications *in the `main` branch only*
2626
- id: version-bump
2727
exclude: "charts/(?!(library-chart|(jupyter-py(spark|thon)/.*)|(rstudio(-sparkr)?/.*)|(vscode-py(thon|spark)/.*)))"
2828
args:
2929
- --branch
3030
- main
31+
# Run `helm dependency update` then `helm lint` on all (modified) charts
32+
- id: helmlint
33+
exclude: "charts/(?!(library-chart|(jupyter-py(spark|thon)/.*)|(rstudio(-sparkr)?/.*)|(vscode-py(thon|spark)/.*)))"
3134

3235
- repo: https://github.com/pre-commit/pre-commit-hooks
3336
rev: v5.0.0
@@ -42,13 +45,6 @@ repos:
4245
- id: trailing-whitespace
4346
exclude: "charts/(?!(library-chart|(jupyter-py(spark|thon)/.*)|(rstudio(-sparkr)?/.*)|(vscode-py(thon|spark)/.*)))"
4447

45-
# Run `helm lint` on all (modified) charts: this may require a manual `helm dep update`
46-
- repo: https://github.com/gruntwork-io/pre-commit
47-
rev: v0.1.15
48-
hooks:
49-
- id: helmlint
50-
exclude: "charts/(?!(library-chart|(jupyter-py(spark|thon)/.*)|(rstudio(-sparkr)?/.*)|(vscode-py(thon|spark)/.*)))"
51-
5248
# Warn the user if `library-chart` is updated and its new version simulatenously reused in other charts
5349
- repo: local
5450
hooks:

0 commit comments

Comments
 (0)