Skip to content

Commit 57a7f12

Browse files
committed
TODO removal
1 parent 0e162b2 commit 57a7f12

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

controllers/user_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,8 +406,6 @@ func (r *S3UserReconciler) getUserSecret(ctx context.Context, userResource *s3v1
406406
userSecret := corev1.Secret{}
407407

408408
err := r.List(ctx, secretsList, client.InNamespace(userResource.Namespace))
409-
// TODO : check if the errors.IsNotFound makes sense for r.List
410-
// if err != nil && (errors.IsNotFound(err) || len(secretsList.Items) == 0) {
411409
if err != nil {
412410
logger.Error(err, "An error occurred while listing the secrets in user's namespace")
413411
return userSecret, fmt.Errorf("SecretListingFailed")
@@ -526,6 +524,7 @@ func (r *S3UserReconciler) finalizeS3User(userResource *s3v1alpha1.S3User) error
526524
func (r *S3UserReconciler) newSecretForCR(ctx context.Context, userResource *s3v1alpha1.S3User, data map[string][]byte) (*corev1.Secret, error) {
527525
logger := log.FromContext(ctx)
528526

527+
// Reusing the S3User's labels and annotations
529528
labels := map[string]string{}
530529
for k, v := range userResource.ObjectMeta.Labels {
531530
labels[k] = v

0 commit comments

Comments
 (0)