Skip to content

Commit 6ffa3c1

Browse files
graindcafeDonatien26
authored andcommitted
fix and enhance logging message on policy deletion
1 parent e8489f1 commit 6ffa3c1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/controller/user/reconcile.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ func (r *S3UserReconciler) handleUpdate(
377377
policyFound := slices.Contains(userResource.Spec.Policies, policy)
378378
if !policyFound {
379379
logger.Info(
380-
fmt.Sprintf("S3User policy definition doesn't contain policy %s", policy),
380+
fmt.Sprintf("S3User has unexpected policy not in definition: %s", policy),
381381
"userResource",
382382
userResource.Name,
383383
"NamespacedName",
@@ -391,7 +391,7 @@ func (r *S3UserReconciler) handleUpdate(
391391
policyFound := slices.Contains(userPolicies, policy)
392392
if !policyFound {
393393
logger.Info(
394-
fmt.Sprintf("S3User policy definition must contain policy %s", policy),
394+
fmt.Sprintf("S3User is missing policy from definition: %s", policy),
395395
"userResource",
396396
userResource.Name,
397397
"NamespacedName",

internal/s3/client/impl/minioS3Client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ func (minioS3Client *MinioS3Client) RemovePoliciesFromUser(
539539
}
540540
s3Logger.Error(
541541
err,
542-
"an error occurred when attaching a policy to the user",
542+
"an error occurred when detaching a policy to the user",
543543
"code",
544544
errAsResp.Code,
545545
)

0 commit comments

Comments
 (0)