Skip to content

Commit 831b09b

Browse files
phlgphlg
committed
doc: changed README (resource deletion)
1 parent 2058167 commit 831b09b

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

‎README.md‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This Operator SDK based tool aims at managing S3 related resources (buckets, pol
1111

1212
This operator has been successfully tested with :
1313

14-
- Kubernetes : 1.25, 1.26, 1.27
14+
- Kubernetes : 1.25, 1.26, 1.27 (v0.7.0), 1.28 (v0.7.0 and v0.8.0)
1515
- MinIO : 2023-05-27T05:56:19Z (up to v0.3.0 included), 2023-11-20T22-40-07Z (from v0.4.0 onwards)
1616

1717
## Description
@@ -33,11 +33,11 @@ Each custom resource based on these CRDs on Kubernetes is to be matched with a r
3333
Two important caveats :
3434

3535
- It is one-way - if something happens on the S3 side directly (instead of going through the CRs), the operator has no way of reacting. At best, the next trigger will overwrite the S3 state with the declared state in the k8s custom resource.
36-
- For now, the operator won't delete any resource on S3 - if a CR is removed, its matching resource on S3 will still be present. This behavior was primarily picked to avoid data loss for bucket, but also applied to policies.
36+
- Originally, the operator did not manage resource deletion. This has changed in release v0.8.0 (see #40), but it still isn't a focus, and the implementation is simple. For instance, bucket deletion will simply fail if bucket is not empty - no logic was added to opt-in a "forced" deletion of everything inside the bucket.
3737

3838
## Installation
3939

40-
The S3 operator is provided either in source form through this repositoy, or already built as a Docker image available on [Docker Hub](https://hub.docker.com/r/inseefrlab/s3-operator).
40+
The S3 operator is provided either in source form through this repository, or already built as a Docker image available on [Docker Hub](https://hub.docker.com/r/inseefrlab/s3-operator).
4141

4242
### Helm
4343

@@ -70,22 +70,22 @@ The operator exposes a few parameters, meant to be set as arguments, though it's
7070

7171
The parameters are summarized in the table below :
7272

73-
| Flag name | Default | Environment variable | Multiple values allowed | Description |
74-
|---------------------------------|------------------|----------------------|-------------------------|-------------|
75-
| `health-probe-bind-address` | `:8081` | - | no | The address the probe endpoint binds to. Comes from Operator SDK.
76-
| `leader-elect` | `false` | - | no | Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager. Comes from Operator SDK.
77-
| `metrics-bind-address` | `:8080` | - | no | The address the metric endpoint binds to. Comes from Operator SDK.
78-
| `region` | `us-east-1` | - | no | The region to configure for the S3 client.
79-
| `s3-access-key` | - | `S3_ACCESS_KEY` | no | The access key used to interact with the S3 server.
80-
| `s3-ca-certificate-base64` | - | - | yes | (Optional) Base64 encoded, PEM format CA certificate, for https requests to the S3 server.
81-
| `s3-ca-certificate-bundle-path` | - | - | no | (Optional) Path to a CA certificates bundle file, for https requests to the S3 server.
82-
| `s3-endpoint-url` | `localhost:9000` | - | no | Hostname (or hostname:port) of the S3 server.
83-
| `s3-provider` | `minio` | - | no | S3 provider (possible values : `minio`, `mockedS3Provider`)
84-
| `s3-secret-key` | - | `S3_SECRET_KEY` | no | The secret key used to interact with the S3 server.
85-
| `useSsl` | true | - | no | Use of SSL/TLS to connect to the S3 server
86-
| `bucket-deletion` | false | - | no | Trigger bucket deletion on the S3 backend upon CR deletion. Will fail if bucket is not empty.
87-
| `policy-deletion` | false | - | no | Trigger policy deletion on the S3 backend upon CR deletion
88-
| `path-deletion` | false | - | no | Trigger path deletion on the S3 backend upon CR deletion. Limited to deleting the `.keep` files used by the operator.
73+
| Flag name | Default | Environment variable | Multiple values allowed | Description |
74+
| ------------------------------- | ---------------- | -------------------- | ----------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
75+
| `health-probe-bind-address` | `:8081` | - | no | The address the probe endpoint binds to. Comes from Operator SDK. |
76+
| `leader-elect` | `false` | - | no | Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager. Comes from Operator SDK. |
77+
| `metrics-bind-address` | `:8080` | - | no | The address the metric endpoint binds to. Comes from Operator SDK. |
78+
| `region` | `us-east-1` | - | no | The region to configure for the S3 client. |
79+
| `s3-access-key` | - | `S3_ACCESS_KEY` | no | The access key used to interact with the S3 server. |
80+
| `s3-ca-certificate-base64` | - | - | yes | (Optional) Base64 encoded, PEM format CA certificate, for https requests to the S3 server. |
81+
| `s3-ca-certificate-bundle-path` | - | - | no | (Optional) Path to a CA certificates bundle file, for https requests to the S3 server. |
82+
| `s3-endpoint-url` | `localhost:9000` | - | no | Hostname (or hostname:port) of the S3 server. |
83+
| `s3-provider` | `minio` | - | no | S3 provider (possible values : `minio`, `mockedS3Provider`) |
84+
| `s3-secret-key` | - | `S3_SECRET_KEY` | no | The secret key used to interact with the S3 server. |
85+
| `useSsl` | true | - | no | Use of SSL/TLS to connect to the S3 server |
86+
| `bucket-deletion` | false | - | no | Trigger bucket deletion on the S3 backend upon CR deletion. Will fail if bucket is not empty. |
87+
| `policy-deletion` | false | - | no | Trigger policy deletion on the S3 backend upon CR deletion |
88+
| `path-deletion` | false | - | no | Trigger path deletion on the S3 backend upon CR deletion. Limited to deleting the `.keep` files used by the operator. |
8989

9090

9191
## Usage
@@ -216,11 +216,11 @@ kubectl apply -f config/samples/
216216
```
217217

218218
2. Build and push your image to the location specified by `IMG`:
219-
219+
220220
```sh
221221
make docker-build docker-push IMG=<some-registry>/s3-operator:tag
222222
```
223-
223+
224224
3. Deploy the controller to the cluster with the image specified by `IMG`:
225225

226226
```sh

0 commit comments

Comments
 (0)