Skip to content

Commit d23fc04

Browse files
Eneman DonatienEneman Donatien
authored andcommitted
[BUG] 🐛 fix invalid ci for chart
1 parent 83190a4 commit d23fc04

File tree

3 files changed

+39
-22
lines changed

3 files changed

+39
-22
lines changed

.github/workflows/ci-chart.yaml

Lines changed: 36 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,37 +5,54 @@ on:
55
branches:
66
- "**"
77
paths-ignore:
8-
- 'docs/**'
8+
- "docs/**"
99
tags:
1010
- "*"
1111
pull_request:
12-
paths-ignore:
13-
- 'docs/**'
12+
paths:
13+
- "deploy/charts/**"
1414

1515
jobs:
16-
17-
helm-lint:
16+
helm-lint-test:
1817
runs-on: ubuntu-latest
1918
steps:
2019
- name: Checkout
21-
uses: actions/checkout@v4
20+
uses: actions/checkout@v3
21+
with:
22+
fetch-depth: 0
2223

23-
- name: Install Helm on Runner
24+
- name: Set up Helm
2425
uses: azure/[email protected]
26+
with:
27+
version: v3.17.0
2528

26-
- name: Lint Chart
27-
run: helm lint .
28-
29-
helm-unitest:
30-
steps:
31-
- name: Checkout
32-
uses: actions/checkout@v4
29+
- uses: actions/[email protected]
30+
with:
31+
python-version: "3.x"
32+
check-latest: true
3333

34-
- name: Install Helm on Runner
35-
uses: azure/[email protected]
34+
- name: Set up chart-testing
35+
uses: helm/[email protected]
36+
37+
- name: Run chart-testing (list-changed)
38+
id: list-changed
39+
run: |
40+
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
41+
if [[ -n "$changed" ]]; then
42+
echo "changed=true" >> "$GITHUB_OUTPUT"
43+
fi
44+
45+
- name: Run chart-testing (lint)
46+
if: steps.list-changed.outputs.changed == 'true'
47+
run: ct lint --target-branch ${{ github.event.repository.default_branch }}
48+
49+
- name: Create kind cluster
50+
if: steps.list-changed.outputs.changed == 'true'
51+
uses: helm/[email protected]
3652

37-
- name: Lint Chart
38-
run: echo "TODO"
53+
- name: Run chart-testing (install)
54+
if: steps.list-changed.outputs.changed == 'true'
55+
run: ct install --target-branch ${{ github.event.repository.default_branch }}
3956

4057
release_helm:
4158
runs-on: ubuntu-latest
@@ -57,4 +74,4 @@ jobs:
5774
charts_dir: deploy/charts
5875
skip_existing: true
5976
env:
60-
CR_TOKEN: "${{ secrets.CR_TOKEN }}"
77+
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

deploy/charts/s3-operator/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ type: application
1313
# This is the chart version. This version number should be incremented each time you make changes
1414
# to the chart and its templates, including the app version.
1515
# Versions are expected to follow Semantic Versioning (https://semver.org/)
16-
version: 0.6.0
16+
version: 0.7.0
1717
# This is the version number of the application being deployed. This version number should be
1818
# incremented each time you make changes to the application. Versions are not expected to
1919
# follow Semantic Versioning. They should reflect the version the application is using.
2020
# It is recommended to use it with quotes.
21-
appVersion: "1.0.0"
21+
appVersion: "v0.12.0"

deploy/charts/s3-operator/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ s3:
4545
# allowedNamespaces: ""
4646
# Should the operator try to delete the resource from the S3 backend upon CR deletion ?
4747
deletion:
48-
bucket: false
48+
bucket: true
4949
path: false
5050
policy: false
5151
s3user: false

0 commit comments

Comments
 (0)