Transitive Koin Modules are not aggregated

[af-jul]

Describe the bug
Assume I have a Gradle module structure like the following where I have my app module which only depends on ui and data modules. These ui and data modules then depend on domain.

The culprit in the end is just a simple transitive Gradle module dependency :app --> :ui --> :domain.
The :data module mentioned here is just to showcase a related issue with KOIN_CONFIG_CHECK

:app
 |--> :ui ----\
 |             |--> domain
 |--> :data --/

The @KoinApplication in :app correctly aggregates the Koin module from :ui into the generated configurationModules. However it does not transitively include the Koin module from :domain. If I have a look at the generated code of the :ui Koin module, it does not include the :domain Koin module at all.

This leads to missing definitions and runtime crashes.

Interestingly, I am able to build the app even with ksp { arg("KOIN_CONFIG_CHECK","true") } enabled. It still crashes at runtime. I have KOIN_CONFIG_CHECK only enabled in my :app module. Due to the strict layer separation and dependency direction (ui --> domain <-- data) I cannot enable it in every module, because only when the app module aggregates everything, it can fulfill all dependencies.

To Reproduce
My Koin setup looks like the following

:app module:

@KoinApplication
object MyApp

// Koin generated
public  val abc.MyApp.configurationModules : List<Module> get() = listOf(abc.ui.UiModule.module,
    abc.data.DataModule.module)

:ui module:

@Module
@Configuration
@ComponentScan
object UiModule

// Koin generated
public val abc_ui_UiModule : Module get() = module {
   viewModel() { _ -> abc.ui.MyViewModel(myUseCase=get() }
}

:domain module:

@Module
@Configuration
@ComponentScan
object DomainModule

// Koin generated
public val abc_domain_DomainModule : Module get() = module {
	factory() { _ -> abc.domain.MyUseCase(myRepository=get())}
}

:data module:

@Module
@Configuration
@ComponentScan
object DataModule

// Koin generated
public val abc_data_DataModule : Module get() = module {
	single() { _ -> abc.data.MyRepositoryImpl()} bind(abc.domain.MyRepository::class)
}

Expected behavior
I would expect

• the @Module / @ComponentScan annotation to aggregate other Gradle modules Koin modules just like @KoinApplication does. Or I would expect@KoinApplication to discover all transitive Koin modules.
• KOIN_CONFIG_CHECK to work as expected when working with transitive modules

I do not want to add an explicit dependency to :domain into my :app module just to achieve auto-aggregation.

Koin project used and used version (please complete the following information):

• koin-bom version 4.1.1
• koin-annotations-bom version 2.3.1

[lotosbin]

use @module(includes = [DomainModule::class]) and ksp1

2.3.1 has issue with ksp2, Koin ksp cannot scan other project module's Koin module

[lotosbin]

#317

[af-jul]

@lotosbin Thanks for the hint. However as far as I know, the issue that you mentioned, originated from another issue from a colleague of mine: #310

These issues do not seem to be directly related to my issue because:

1. KSP2 is breaking Koin Annotations KMP app scanning #317 mentions it only happens in a KMP project. I am in a plain Android project, which reportedly should work
2. I additionally tried the suggested workaround of KSP1 and koin-annotations = "2.2.0" & ksp = "2.1.20-1.0.31" from KSP2 is breaking Koin Annotations KMP app scanning #317
3. For me it can discover other Gradle modules Koin modules, but in a structure of transitive modules A -> B -> C the module A only aggregates the definitions from B and not from C

[alexandrucaraus]

@af-jul do you include the :domain module in the deps of :app module, or only the :ui and :data?
Because I am working on a KMP project and android part works, but I include all modules :domain :ui and :data.

My issue is on iOS. I have a bunch of feature modules with koin modules defined as @configuration, so it has to be added to the @KoinApplication object AppDi.

On Android it works as expected.
On Ios the other modules are not aggregated.

So on Android the generated KoinMeta looks like this (which is fine):

package org.koin.ksp.generated

import org.koin.meta.annotations.*
@MetaApplication("eu.caraus.kmp.samplearch.AppDi", configurations=["eu.caraus.kmp.notes.ui.NoteUiDiModule","eu.caraus.kmp.database.DatabaseDiModule","eu.caraus.kmp.notes.domain.NoteDiModule","eu.caraus.kmp.notes.data.NoteDataDiModule"])
public class _KSP_EuCarausKmpSamplearchAppDi

On iOS is generated like that :( :

package org.koin.ksp.generated

import org.koin.meta.annotations.*
@MetaApplication("eu.caraus.kmp.samplearch.AppDi")
public class _KSP_EuCarausKmpSamplearchAppDi

It is generating it properly on iOS only when I do the following aka indicate all the modules, which is manual labor I want to avoid :

@KoinApplication
(
    modules = [
        DatabaseDiModule::class,
        NoteDataDiModule::class,
        NoteDiModule::class,
        NoteUiDiModule::class
    ]
)
object AppDi

@arnaudgiuliani do you have any idea about this? This was the closest issue similar to my problem. I can open a new one if needed.

Edit: My bad there is an issue related to KSP2 -> root cause https://youtrack.jetbrains.com/issue/KT-83388/Analysis-API-properly-support-KMP-in-KotlinPackageProvider
and
317