Merge pull request #1418 from ruanwenfeng/patch-inputs-order

thewtex · web-flow · commit ee18b901eaea · 2025-07-18T09:02:26.000-04:00
fix(dicom): image reading error when singleSortedSeries is true
diff --git a/packages/dicom/typescript/src/read-image-dicom-file-series.ts b/packages/dicom/typescript/src/read-image-dicom-file-series.ts
@@ -27,19 +27,17 @@ async function readImageDicomFileSeries(
     workerPool = new WorkerPool(numberOfWorkers, readImageDicomFileSeriesWorkerFunction)
   }
 
-  const inputs: Array<BinaryFile> = [
-  ]
   if(options.inputImages.length < 1) {
     throw new Error('"input-images" option must have a length > 1')
   }
 
-  await Promise.all(options.inputImages.map(async (value) => {
+  const inputs: Array<BinaryFile> = await Promise.all(options.inputImages.map(async (value) => {
     let valueFile = value
     if (value instanceof File) {
       const valueBuffer = await value.arrayBuffer()
       valueFile = { path: value.name, data: new Uint8Array(valueBuffer) }
     }
-    inputs.push(valueFile as BinaryFile)
+    return valueFile as BinaryFile
   }))
 
   if (options.singleSortedSeries) {

Original file line number	Diff line number	Diff line change
`@@ -27,19 +27,17 @@ async function readImageDicomFileSeries(`
`27`	`27`	`workerPool = new WorkerPool(numberOfWorkers, readImageDicomFileSeriesWorkerFunction)`
`28`	`28`	`}`
`29`	`29`
`30`		`- const inputs: Array<BinaryFile> = [`
`31`		`- ]`
`32`	`30`	`if(options.inputImages.length < 1) {`
`33`	`31`	`throw new Error('"input-images" option must have a length > 1')`
`34`	`32`	`}`
`35`	`33`
`36`		`- await Promise.all(options.inputImages.map(async (value) => {`
	`34`	`+ const inputs: Array<BinaryFile> = await Promise.all(options.inputImages.map(async (value) => {`
`37`	`35`	`let valueFile = value`
`38`	`36`	`if (value instanceof File) {`
`39`	`37`	`const valueBuffer = await value.arrayBuffer()`
`40`	`38`	`valueFile = { path: value.name, data: new Uint8Array(valueBuffer) }`
`41`	`39`	`}`
`42`		`- inputs.push(valueFile as BinaryFile)`
	`40`	`+ return valueFile as BinaryFile`
`43`	`41`	`}))`
`44`	`42`
`45`	`43`	`if (options.singleSortedSeries) {`