STYLE: Prefer explicit const designation

Implements detection of local variables which could be declared as const but
are not. Declaring variables as const is recommended by many coding
guidelines, such as: ES.25 from the C++ Core Guidelines.

cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,misc-const-correctness -header-filter=.* -fix

Author: hjmjohnson

Examples/DataRepresentation/Image/Image2.cxx

@@ -137,7 +137,7 @@ main(int, char * argv[])
   // Software Guide : EndLatex
 
   // Software Guide : BeginCodeSnippet
-  ImageType::Pointer image = reader->GetOutput();
+  const ImageType::Pointer image = reader->GetOutput();
   // Software Guide : EndCodeSnippet
 
   // Software Guide : BeginLatex

Examples/DataRepresentation/Image/Image3.cxx

@@ -99,7 +99,7 @@ main(int, char *[])
   // Software Guide : EndLatex
 
   // Software Guide : BeginCodeSnippet
-  ImageType::PixelType pixelValue = image->GetPixel(pixelIndex);
+  const ImageType::PixelType pixelValue = image->GetPixel(pixelIndex);
   // Software Guide : EndCodeSnippet
 
   // Software Guide : BeginLatex

Examples/DataRepresentation/Image/Image4.cxx

@@ -459,7 +459,7 @@ main(int, char *[])
   LeftEyeIndexVector[1] = LeftEyeIndex[1];
   LeftEyeIndexVector[2] = LeftEyeIndex[2];
 
-  ImageType::PointType LeftEyePointByHand =
+  const ImageType::PointType LeftEyePointByHand =
     ImageOrigin + ImageDirectionCosines * SpacingMatrix * LeftEyeIndexVector;
   // Software Guide : EndCodeSnippet
 

Examples/DataRepresentation/Image/ImageAdaptor1.cxx

@@ -162,7 +162,7 @@ main(int argc, char * argv[])
   it.GoToBegin();
   while (!it.IsAtEnd())
   {
-    float value = it.Get();
+    const float value = it.Get();
     sum += value;
     ++it;
   }

Examples/DataRepresentation/Image/RGBImage.cxx

@@ -88,7 +88,7 @@ main(int, char * argv[])
   reader->SetFileName(filename);
   reader->Update();
 
-  ImageType::Pointer         image = reader->GetOutput();
+  const ImageType::Pointer   image = reader->GetOutput();
   const ImageType::IndexType pixelIndex = { { 25, 35, 0 } };
 
   // Software Guide : BeginLatex

Examples/DataRepresentation/Image/VectorImage.cxx

@@ -127,7 +127,7 @@ main(int, char *[])
 
   // The GetPixel method can also be used to read Vectors
   // pixels from the image
-  ImageType::PixelType value = image->GetPixel(pixelIndex);
+  const ImageType::PixelType value = image->GetPixel(pixelIndex);
 
   std::cout << value << std::endl;
 

Examples/DataRepresentation/Mesh/AutomaticMesh.cxx

@@ -200,7 +200,7 @@ main(int, char *[])
   //
   //  Software Guide : EndLatex
 
-  MeshType::Pointer mesh = meshSource->GetOutput();
+  const MeshType::Pointer mesh = meshSource->GetOutput();
   std::cout << mesh << std::endl;
 
   //  Software Guide : BeginLatex

Examples/DataRepresentation/Mesh/Mesh1.cxx

@@ -218,12 +218,12 @@ main(int, char *[])
   //  Software Guide : EndLatex
 
   // Software Guide : BeginCodeSnippet
-  PointsIterator end = mesh->GetPoints()->End();
+  const PointsIterator end = mesh->GetPoints()->End();
   while (pointIterator != end)
   {
-    MeshType::PointType p = pointIterator.Value(); // access the point
-    std::cout << p << std::endl;                   // print the point
-    ++pointIterator;                               // advance to next point
+    const MeshType::PointType p = pointIterator.Value(); // access the point
+    std::cout << p << std::endl;                         // print the point
+    ++pointIterator; // advance to next point
   }
   // Software Guide : EndCodeSnippet
 

Examples/DataRepresentation/Mesh/Mesh2.cxx

@@ -294,8 +294,8 @@ main(int, char *[])
   //  Software Guide : EndLatex
 
   // Software Guide : BeginCodeSnippet
-  CellIterator cellIterator = mesh->GetCells()->Begin();
-  CellIterator end = mesh->GetCells()->End();
+  CellIterator       cellIterator = mesh->GetCells()->Begin();
+  const CellIterator end = mesh->GetCells()->End();
   // Software Guide : EndCodeSnippet
 
 

Examples/DataRepresentation/Mesh/Mesh3.cxx

@@ -218,8 +218,8 @@ main(int, char *[])
   //  Software Guide : EndLatex
 
   // Software Guide : BeginCodeSnippet
-  CellDataIterator cellDataIterator = mesh->GetCellData()->Begin();
-  CellDataIterator end = mesh->GetCellData()->End();
+  CellDataIterator       cellDataIterator = mesh->GetCellData()->Begin();
+  const CellDataIterator end = mesh->GetCellData()->End();
   // Software Guide : EndCodeSnippet
 
 
@@ -238,7 +238,7 @@ main(int, char *[])
   // Software Guide : BeginCodeSnippet
   while (cellDataIterator != end)
   {
-    PixelType cellValue = cellDataIterator.Value();
+    const PixelType cellValue = cellDataIterator.Value();
     std::cout << cellValue << std::endl;
     ++cellDataIterator;
   }