Merge pull request #5350 from N-Dekker/Fix-random-number-RGBGibbsPriorFilter

thewtex · web-flow · commit 43ea92d9e8d8 · 2025-05-15T11:16:40.000-04:00
BUG: Fix random number in `RGBGibbsPriorFilter::GibbsTotalEnergy`
diff --git a/Modules/Segmentation/MarkovRandomFieldsClassifiers/include/itkRGBGibbsPriorFilter.hxx b/Modules/Segmentation/MarkovRandomFieldsClassifiers/include/itkRGBGibbsPriorFilter.hxx
@@ -289,7 +289,7 @@ RGBGibbsPriorFilter<TInputImage, TClassifiedImage>::GibbsTotalEnergy(int i)
     if (changeflag)
     {
       difenergy = energy[label] - energy[1 - label];
-      const double rand_num{ rand() / 32768.0 };
+      const double rand_num{ rand() / (RAND_MAX + 1.0) };
       double       energy_num{ std::exp(static_cast<double>(difenergy * 0.5 * size / (2 * size - m_Temp))) };
       if (rand_num < energy_num)
       {

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ RGBGibbsPriorFilter<TInputImage, TClassifiedImage>::GibbsTotalEnergy(int i)`
`289`	`289`	`if (changeflag)`
`290`	`290`	`{`
`291`	`291`	`difenergy = energy[label] - energy[1 - label];`
`292`		`- const double rand_num{ rand() / 32768.0 };`
	`292`	`+ const double rand_num{ rand() / (RAND_MAX + 1.0) };`
`293`	`293`	`double energy_num{ std::exp(static_cast<double>(difenergy * 0.5 * size / (2 * size - m_Temp))) };`
`294`	`294`	`if (rand_num < energy_num)`
`295`	`295`	`{`