ENH: Add Unit test for reading short rescaled into ushort

PtiLuky · hjmjohnson · commit c69a657425b0 · 2025-05-17T11:13:23.000-05:00
diff --git a/Modules/IO/GDCM/src/itkGDCMImageIO.cxx b/Modules/IO/GDCM/src/itkGDCMImageIO.cxx
@@ -537,7 +537,7 @@ GDCMImageIO::InternalReadImageInformation()
     switch (outputpt)
     {
       // Default comparison uses the > operator and the order in ScalarType enum
-      // INT types needs to be adjusted so signed input is allowed to produce unsigned output
+      // INT types need to be adjusted so signed input is allowed to produce unsigned output
       case gdcm::PixelFormat::UINT8:
         ptLarger = pixeltype > gdcm::PixelFormat::INT8;
         break;
diff --git a/Modules/IO/GDCM/test/Baseline/itkGDCMImageIOTestIntToUint.mha.cid b/Modules/IO/GDCM/test/Baseline/itkGDCMImageIOTestIntToUint.mha.cid
@@ -0,0 +1 @@
+bafkreifqaycilgy52jjjytkjbfrfaioc57bfjnfhfuuynozr3g3xmv6apu
diff --git a/Modules/IO/GDCM/test/CMakeLists.txt b/Modules/IO/GDCM/test/CMakeLists.txt
@@ -250,6 +250,19 @@ itk_add_test(
   itkGDCMImageIONoPreambleTest
   DATA{Input/preamble.dcm})
 
+itk_add_test(
+  NAME
+  itkGDCMImageIOIntToUintTest
+  COMMAND
+  ITKIOGDCMTestDriver
+  --compare
+  DATA{Baseline/itkGDCMImageIOTestIntToUint.mha}
+  ${ITK_TEST_OUTPUT_DIR}/itkGDCMImageIOTestIntToUint.mha
+  itkGDCMImageReadWriteTest
+  DATA{Input/030658_001.dcm}
+  ${ITK_TEST_OUTPUT_DIR}/itkGDCMImageIOTestIntToUint.mha
+  scalar)
+
 itk_add_test(
   NAME
   itkGDCMImageIO32bitsStoredTest
diff --git a/Modules/IO/GDCM/test/Input/030658_001.dcm.cid b/Modules/IO/GDCM/test/Input/030658_001.dcm.cid
@@ -0,0 +1 @@
+bafkreieyej3y53xaqg6dcedbv5pa6y5m25rdrg42wdqm43oh4ijjrlpl4a

Original file line number	Diff line number	Diff line change
`@@ -537,7 +537,7 @@ GDCMImageIO::InternalReadImageInformation()`
`537`	`537`	`switch (outputpt)`
`538`	`538`	`{`
`539`	`539`	`// Default comparison uses the > operator and the order in ScalarType enum`
`540`		`- // INT types needs to be adjusted so signed input is allowed to produce unsigned output`
	`540`	`+ // INT types need to be adjusted so signed input is allowed to produce unsigned output`
`541`	`541`	`case gdcm::PixelFormat::UINT8:`
`542`	`542`	`ptLarger = pixeltype > gdcm::PixelFormat::INT8;`
`543`	`543`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+bafkreifqaycilgy52jjjytkjbfrfaioc57bfjnfhfuuynozr3g3xmv6apu`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+bafkreieyej3y53xaqg6dcedbv5pa6y5m25rdrg42wdqm43oh4ijjrlpl4a`