ENH: Let tests interpret IOComponent::CHAR as signed char

N-Dekker · hjmjohnson · commit d7126b61e5b1 · 2025-07-10T07:04:42.000-05:00
Let both HashTestImage (itkTestDriverInclude) and itkTIFFImageIOCompressionTest
interpret `IOComponent::CHAR` as `signed char`
diff --git a/Modules/Core/TestKernel/src/itkTestDriverInclude.cxx b/Modules/Core/TestKernel/src/itkTestDriverInclude.cxx
@@ -828,7 +828,7 @@ HashTestImage(const char * testImageFilename, const std::vector<std::string> & b
   switch (componentType)
   {
     case itk::IOComponentEnum::CHAR:
-      testMD5 = ComputeHash<itk::VectorImage<char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);
+      testMD5 = ComputeHash<itk::VectorImage<signed char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);
       break;
     case itk::IOComponentEnum::UCHAR:
       testMD5 = ComputeHash<itk::VectorImage<unsigned char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);
diff --git a/Modules/IO/TIFF/test/itkTIFFImageIOCompressionTest.cxx b/Modules/IO/TIFF/test/itkTIFFImageIOCompressionTest.cxx
@@ -200,7 +200,7 @@ itkTIFFImageIOCompressionTest(int argc, char * argv[])
         }
         case itk::IOComponentEnum::CHAR:
         {
-          using PixelType = char;
+          using PixelType = signed char;
           return itkTIFFImageIOCompressionTestHelper<itk::Image<PixelType, 2>>(argc, argv, JPEGQuality);
         }
         case itk::IOComponentEnum::USHORT:

Original file line number	Diff line number	Diff line change
`@@ -828,7 +828,7 @@ HashTestImage(const char * testImageFilename, const std::vector<std::string> & b`
`828`	`828`	`switch (componentType)`
`829`	`829`	`{`
`830`	`830`	`case itk::IOComponentEnum::CHAR:`
`831`		`- testMD5 = ComputeHash<itk::VectorImage<char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);`
	`831`	`+ testMD5 = ComputeHash<itk::VectorImage<signed char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);`
`832`	`832`	`break;`
`833`	`833`	`case itk::IOComponentEnum::UCHAR:`
`834`	`834`	`testMD5 = ComputeHash<itk::VectorImage<unsigned char, ITK_TEST_DIMENSION_MAX>>(testImageFilename);`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ itkTIFFImageIOCompressionTest(int argc, char * argv[])`
`200`	`200`	`}`
`201`	`201`	`case itk::IOComponentEnum::CHAR:`
`202`	`202`	`{`
`203`		`- using PixelType = char;`
	`203`	`+ using PixelType = signed char;`
`204`	`204`	`return itkTIFFImageIOCompressionTestHelper<itk::Image<PixelType, 2>>(argc, argv, JPEGQuality);`
`205`	`205`	`}`
`206`	`206`	`case itk::IOComponentEnum::USHORT:`