From ec1c8c8478364ce0042d6a33d4b74ace4d43bdac Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Sun, 26 Jan 2025 08:58:25 -0600 Subject: [PATCH] STYLE: Add itkVirtualGetNameOfClassMacro + itkOverrideGetNameOfClassMacro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66cb04d410e555656828e8892107add38ccb, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337 --- include/itkFDFImageIO.h | 2 +- include/itkFDFImageIOFactory.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/itkFDFImageIO.h b/include/itkFDFImageIO.h index 30a6fb1..11f161c 100644 --- a/include/itkFDFImageIO.h +++ b/include/itkFDFImageIO.h @@ -45,7 +45,7 @@ class IOFDF_EXPORT FDFImageIO : public ImageIOBase itkNewMacro(Self); /** Run-time type information (and related methods). */ - itkTypeMacro(FDFImageIO, ImageIOBase); + itkOverrideGetNameOfClassMacro(FDFImageIO); bool SupportsDimension(unsigned long dim) override diff --git a/include/itkFDFImageIOFactory.h b/include/itkFDFImageIOFactory.h index 3788c18..d676e17 100644 --- a/include/itkFDFImageIOFactory.h +++ b/include/itkFDFImageIOFactory.h @@ -48,7 +48,7 @@ class IOFDF_EXPORT FDFImageIOFactory : public ObjectFactoryBase itkFactorylessNewMacro(Self); /** Run-time type information (and related methods). */ - itkTypeMacro(FDFImageIOFactory, ObjectFactoryBase); + itkOverrideGetNameOfClassMacro(FDFImageIOFactory); /** Register one factory of this type */ static void