Squashed commit of the following:

STYLE: documentation and style fixes

BUG: fix pixel and physical dimension population for writing
- have metadata dictionary populate and save dimension values

BUG: fix microsoft-specific errors and register scancoio for use in test for aim writing

WIP: Have write convert back to Scanco units

Merge changes from incorporate aimio:

    WIP: Move header reading/writing to completely depend on subclass ScancoHeaderIO

    WIP: Have ISQ write all metadata as read in

    WIP: Use AimIO method for reading ISQ

    This method defines header structures and reads header bytes directly into them for access

    - add test for reader update in conversion test

    WIP: Complete reading extended header from data struct

    - add documentation and style fixes

    WIP: have aim reader use struct header datatype

    WIP: switch reading to scancoheaderio class

    WIP: add class files for header reader and writers

    WIP: add class files and definitions for separating header reading and
    writing

Merge changes from main:

    BUG: fix creation date output in header write

    STYLE: Move unrelated data manipulation functions out of main class

    STYLE: Add and update doxygen comments for functions

    STYLE: fix spacing for ITK style checks
    BUG: fix CI and compiler warnings and errors
    BUG: remove depreciated sprintf

Author: ebald19

include/itkScancoDataManipulation.h

@@ -68,11 +68,11 @@ struct itkScancoHeaderData
   itkScancoPixelData    m_PixelData; // Pixel data information
 };
 
-#define GetConstMacro(name, type)                                        \
+#define ScancoGetConstMacro(name, type)                                  \
   virtual type Get##name() const { return this->m_HeaderData.m_##name; } \
   ITK_MACROEND_NOOP_STATEMENT
 
-#define SetMacro(name, type)                         \
+#define ScancoSetMacro(name, type)                   \
   virtual void Set##name(type _arg)                  \
   {                                                  \
     itkDebugMacro("setting " #name " to " << _arg);  \

include/itkScancoImageIO.h

@@ -195,20 +195,20 @@ class IOScanco_EXPORT ScancoImageIO : public ImageIOBase
     this->Modified();
   }
 
-  GetConstMacro(PatientIndex, int);
-  SetMacro(PatientIndex, int);
+  ScancoGetConstMacro(PatientIndex, int);
+  ScancoSetMacro(PatientIndex, int);
 
-  GetConstMacro(ScannerID, int);
-  SetMacro(ScannerID, int);
+  ScancoGetConstMacro(ScannerID, int);
+  ScancoSetMacro(ScannerID, int);
 
-  GetConstMacro(SliceThickness, double);
-  SetMacro(SliceThickness, double);
+  ScancoGetConstMacro(SliceThickness, double);
+  ScancoSetMacro(SliceThickness, double);
 
-  GetConstMacro(SliceIncrement, double);
-  SetMacro(SliceIncrement, double);
+  ScancoGetConstMacro(SliceIncrement, double);
+  ScancoSetMacro(SliceIncrement, double);
 
-  GetConstMacro(StartPosition, double);
-  SetMacro(StartPosition, double);
+  ScancoGetConstMacro(StartPosition, double);
+  ScancoSetMacro(StartPosition, double);
 
   /** Set / Get the minimum and maximum values */
   const double *
@@ -232,47 +232,47 @@ class IOScanco_EXPORT ScancoImageIO : public ImageIOBase
     }
   }
 
-  GetConstMacro(MuScaling, double);
-  SetMacro(MuScaling, double);
+  ScancoGetConstMacro(MuScaling, double);
+  ScancoSetMacro(MuScaling, double);
 
-  GetConstMacro(MuWater, double);
-  SetMacro(MuWater, double);
+  ScancoGetConstMacro(MuWater, double);
+  ScancoSetMacro(MuWater, double);
 
-  GetConstMacro(RescaleType, int);
-  SetMacro(RescaleType, int);
+  ScancoGetConstMacro(RescaleType, int);
+  ScancoSetMacro(RescaleType, int);
 
-  GetConstMacro(RescaleSlope, double);
-  SetMacro(RescaleSlope, double);
+  ScancoGetConstMacro(RescaleSlope, double);
+  ScancoSetMacro(RescaleSlope, double);
 
-  GetConstMacro(RescaleIntercept, double);
-  SetMacro(RescaleIntercept, double);
+  ScancoGetConstMacro(RescaleIntercept, double);
+  ScancoSetMacro(RescaleIntercept, double);
 
-  GetConstMacro(NumberOfSamples, int);
-  SetMacro(NumberOfSamples, int);
+  ScancoGetConstMacro(NumberOfSamples, int);
+  ScancoSetMacro(NumberOfSamples, int);
 
-  GetConstMacro(NumberOfProjections, int);
-  SetMacro(NumberOfProjections, int);
+  ScancoGetConstMacro(NumberOfProjections, int);
+  ScancoSetMacro(NumberOfProjections, int);
 
-  GetConstMacro(ScanDistance, double);
-  SetMacro(ScanDistance, double);
+  ScancoGetConstMacro(ScanDistance, double);
+  ScancoSetMacro(ScanDistance, double);
 
-  GetConstMacro(ScannerType, int);
-  SetMacro(ScannerType, int);
+  ScancoGetConstMacro(ScannerType, int);
+  ScancoSetMacro(ScannerType, int);
 
-  GetConstMacro(SampleTime, double);
-  SetMacro(SampleTime, double);
+  ScancoGetConstMacro(SampleTime, double);
+  ScancoSetMacro(SampleTime, double);
 
-  GetConstMacro(MeasurementIndex, int);
-  SetMacro(MeasurementIndex, int);
+  ScancoGetConstMacro(MeasurementIndex, int);
+  ScancoSetMacro(MeasurementIndex, int);
 
-  GetConstMacro(Site, int);
-  SetMacro(Site, int);
+  ScancoGetConstMacro(Site, int);
+  ScancoSetMacro(Site, int);
 
-  GetConstMacro(ReferenceLine, int);
-  SetMacro(ReferenceLine, int);
+  ScancoGetConstMacro(ReferenceLine, int);
+  ScancoSetMacro(ReferenceLine, int);
 
-  GetConstMacro(ReconstructionAlg, int);
-  SetMacro(ReconstructionAlg, int);
+  ScancoGetConstMacro(ReconstructionAlg, int);
+  ScancoSetMacro(ReconstructionAlg, int);
 
   /** Get a string that states patient name.
    * Max size: 40 characters. */
@@ -312,11 +312,11 @@ class IOScanco_EXPORT ScancoImageIO : public ImageIOBase
     this->Modified();
   }
 
-  GetConstMacro(Energy, double);
-  SetMacro(Energy, double);
+  ScancoGetConstMacro(Energy, double);
+  ScancoSetMacro(Energy, double);
 
-  GetConstMacro(Intensity, double);
-  SetMacro(Intensity, double);
+  ScancoGetConstMacro(Intensity, double);
+  ScancoSetMacro(Intensity, double);
 
 protected:
   ScancoImageIO();

src/itkScancoImageIO.cxx

@@ -286,6 +286,7 @@ ScancoImageIO::ReadImageInformation()
   }
   else
   {
+    this->SetPixelType(IOPixelEnum::SCALAR);
     this->SetComponentType(IOComponentEnum::SHORT);
     this->m_Compression = 0;
   }

test/itkScancoImageIOTest.cxx

@@ -37,6 +37,12 @@ itkScancoImageIOTest(int argc, char * argv[])
   }
   const char * inputFileName = argv[1];
   const char * outputFileName = argv[2];
+  bool         expectFailure = false;
+  if (argc > 3)
+  {
+    expectFailure = true;
+    std::cout << "Expecting failure for this test." << std::endl;
+  }
 
   // ATTENTION THIS IS THE PIXEL TYPE FOR
   // THE RESULTING IMAGE
@@ -73,7 +79,7 @@ itkScancoImageIOTest(int argc, char * argv[])
   {
     std::cerr << "Exception in the file reader " << std::endl;
     std::cerr << error << std::endl;
-    if (argc == 3) // should fail
+    if (expectFailure)
     {
       return EXIT_SUCCESS;
     }