Merge pull request #21 from jcfr/fix-sign-comp-warnings

thewtex · thewtex · commit c9cdc87db021 · 2016-02-18T11:05:21.000-05:00
Fix sign comparison warnings in SingleImageCostFunction
diff --git a/include/itkSingleImageCostFunction.hxx b/include/itkSingleImageCostFunction.hxx
@@ -88,7 +88,7 @@ SingleImageCostFunction<TImage>
 {
   // Convert parameters to point
   PointType point;
-  for (int i=0; i<ImageDimension; i++)
+  for (unsigned int i=0; i<ImageDimension; i++)
     {
     point[i] = static_cast<typename PointType::ValueType>( parameters[i] );
     }
@@ -137,7 +137,7 @@ SingleImageCostFunction<TImage>
 
   // Convert the image function output to the cost function derivative
   const typename DerivativeType::ValueType DerivativeThreshold = 15.0;
-  for (int i=0; i<ImageDimension; i++)
+  for (unsigned int i=0; i<ImageDimension; i++)
     {
     derivative[i] = static_cast<typename DerivativeType::ValueType>( output[i] );
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ SingleImageCostFunction<TImage>`
`88`	`88`	`{`
`89`	`89`	`// Convert parameters to point`
`90`	`90`	`PointType point;`
`91`		`- for (int i=0; i<ImageDimension; i++)`
	`91`	`+ for (unsigned int i=0; i<ImageDimension; i++)`
`92`	`92`	`{`
`93`	`93`	`point[i] = static_cast<typename PointType::ValueType>( parameters[i] );`
`94`	`94`	`}`
`@@ -137,7 +137,7 @@ SingleImageCostFunction<TImage>`
`137`	`137`
`138`	`138`	`// Convert the image function output to the cost function derivative`
`139`	`139`	`const typename DerivativeType::ValueType DerivativeThreshold = 15.0;`
`140`		`- for (int i=0; i<ImageDimension; i++)`
	`140`	`+ for (unsigned int i=0; i<ImageDimension; i++)`
`141`	`141`	`{`
`142`	`142`	`derivative[i] = static_cast<typename DerivativeType::ValueType>( output[i] );`
`143`	`143`