COMP: Fix compiler warning about lifetime extension

hjmjohnson · hjmjohnson · commit 3762d5642f56 · 2025-11-11T06:03:16.000-06:00
Montage/include/itkPhaseCorrelationOptimizer.h: In static member
function ‘static const
std::initializer_list&lt;itk::PhaseCorrelationOptimizerEnums::PeakInterpolationMethod&gt;
itk::PhaseCorrelationOptimizerEnums::AllPeakInterpolationMethods()’:
Montage/include/itkPhaseCorrelationOptimizer.h:64:12: warning: returning
local ‘initializer_list’ variable ‘methods’ does not extend the lifetime
of the underlying array [-Winit-list-lifetime]
   64 |     return methods;
      |            ^~~~~~~
Montage/include/itkPhaseCorrelationOptimizer.h:57:58: note: declared
here 57 |     const std::initializer_list&lt;PeakInterpolationMethod&gt;
methods{
      |                                                          ^~~~~~~
diff --git a/include/itkPhaseCorrelationOptimizer.h b/include/itkPhaseCorrelationOptimizer.h
@@ -54,7 +54,7 @@ class PhaseCorrelationOptimizerEnums
   static const std::initializer_list<PeakInterpolationMethod>
   AllPeakInterpolationMethods()
   {
-    const std::initializer_list<PeakInterpolationMethod> methods{
+    static constexpr std::initializer_list<PeakInterpolationMethod> methods{
       PeakInterpolationMethod::None,
       PeakInterpolationMethod::Parabolic,
       PeakInterpolationMethod::Cosine,

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ class PhaseCorrelationOptimizerEnums`
`54`	`54`	`static const std::initializer_list<PeakInterpolationMethod>`
`55`	`55`	`AllPeakInterpolationMethods()`
`56`	`56`	`{`
`57`		`- const std::initializer_list<PeakInterpolationMethod> methods{`
	`57`	`+ static constexpr std::initializer_list<PeakInterpolationMethod> methods{`
`58`	`58`	`PeakInterpolationMethod::None,`
`59`	`59`	`PeakInterpolationMethod::Parabolic,`
`60`	`60`	`PeakInterpolationMethod::Cosine,`