COMP: Remove compiler warnings

hjmjohnson · hjmjohnson · commit c27ffb928fe7 · 2025-01-28T08:47:57.000-06:00
diff --git a/test/itkHighPriorityRealTimeProbeTest.cxx b/test/itkHighPriorityRealTimeProbeTest.cxx
@@ -68,12 +68,17 @@ itkHighPriorityRealTimeProbeTest(int, char *[])
     localTimer.Start();
 
     double sum = 0.0;
-    for (unsigned int i = 0; i < 1e6; ++i)
+    constexpr unsigned int big_stopping_criteria=1e6;
+    for (unsigned int i = 0; i < big_stopping_criteria; ++i)
     {
       sum += i;
     }
 
     localTimer.Stop();
+    // Need to use the variable sum to ensure that it is not optimized away.
+    std::cout << "     Time for simple addition summing loop with " 
+	      << big_stopping_criteria << " iterations: " 
+	      <<  localTimer.GetMean() << " sum = (" << sum << ")\n";
   }
 
   if (!CheckTimeProbe(localTimer))
diff --git a/test/itkHighPriorityRealTimeProbesCollectorTest.cxx b/test/itkHighPriorityRealTimeProbesCollectorTest.cxx
@@ -63,11 +63,13 @@ TestTransformPhysicalPointToIndex(T * image)
       for (int i = 0; i < 1000; i++)
       {
         point3D[0] = static_cast<typename itk::NumericTraits<typename T::PointType>::ValueType>(i);
-        image->TransformPhysicalPointToIndex(point3D, index3D);
+        index3D = image->TransformPhysicalPointToIndex(point3D);
       }
     }
     if (k == 5)
-      std::cout << point3D << std::endl;
+    {
+      std::cout << point3D << " at " << index3D << std::endl;
+    }
   }
 }
 //-------------------------
diff --git a/test/itkTimeProbeTest2.cxx b/test/itkTimeProbeTest2.cxx
@@ -70,12 +70,16 @@ itkTimeProbeTest2(int, char *[])
     localTimer.Start();
 
     double sum = 0.0;
-    for (unsigned int i = 0; i < 1e6; ++i)
+    constexpr unsigned int big_stopping_criteria=1e6;
+    for (unsigned int i = 0; i < big_stopping_criteria; ++i)
     {
       sum += i;
     }
-
     localTimer.Stop();
+    // Need to use the variable sum to ensure that it is not optimized away.
+    std::cout << "     Time for simple addition summing loop with "
+	      << big_stopping_criteria << " iterations: "
+	      <<  localTimer.GetMean() << " sum = (" << sum << ")\n";
   }
 
   if (!CheckTimeProbe(localTimer))
diff --git a/test/itkTimeProbesTest2.cxx b/test/itkTimeProbesTest2.cxx
@@ -62,11 +62,13 @@ TestTransformPhysicalPointToIndex(T * image)
       for (int i = 0; i < 1000; i++)
       {
         point3D[0] = static_cast<typename itk::NumericTraits<typename T::PointType>::ValueType>(i);
-        image->TransformPhysicalPointToIndex(point3D, index3D);
+        index3D = image->TransformPhysicalPointToIndex(point3D);
       }
     }
     if (k == 5)
-      std::cout << point3D << std::endl;
+    {
+      std::cout << point3D << " at " << index3D << std::endl;
+    }
   }
 }
 //-------------------------

Original file line number	Diff line number	Diff line change
`@@ -68,12 +68,17 @@ itkHighPriorityRealTimeProbeTest(int, char *[])`
`68`	`68`	`localTimer.Start();`
`69`	`69`
`70`	`70`	`double sum = 0.0;`
`71`		`- for (unsigned int i = 0; i < 1e6; ++i)`
	`71`	`+ constexpr unsigned int big_stopping_criteria=1e6;`
	`72`	`+ for (unsigned int i = 0; i < big_stopping_criteria; ++i)`
`72`	`73`	`{`
`73`	`74`	`sum += i;`
`74`	`75`	`}`
`75`	`76`
`76`	`77`	`localTimer.Stop();`
	`78`	`+ // Need to use the variable sum to ensure that it is not optimized away.`
	`79`	`+ std::cout << " Time for simple addition summing loop with "`
	`80`	`+ << big_stopping_criteria << " iterations: "`
	`81`	`+ << localTimer.GetMean() << " sum = (" << sum << ")\n";`
`77`	`82`	`}`
`78`	`83`
`79`	`84`	`if (!CheckTimeProbe(localTimer))`
Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,13 @@ TestTransformPhysicalPointToIndex(T * image)`
`63`	`63`	`for (int i = 0; i < 1000; i++)`
`64`	`64`	`{`
`65`	`65`	`point3D[0] = static_cast<typename itk::NumericTraits<typename T::PointType>::ValueType>(i);`
`66`		`- image->TransformPhysicalPointToIndex(point3D, index3D);`
	`66`	`+ index3D = image->TransformPhysicalPointToIndex(point3D);`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`if (k == 5)`
`70`		`- std::cout << point3D << std::endl;`
	`70`	`+ {`
	`71`	`+ std::cout << point3D << " at " << index3D << std::endl;`
	`72`	`+ }`
`71`	`73`	`}`
`72`	`74`	`}`
`73`	`75`	`//-------------------------`
Original file line number	Diff line number	Diff line change
`@@ -70,12 +70,16 @@ itkTimeProbeTest2(int, char *[])`
`70`	`70`	`localTimer.Start();`
`71`	`71`
`72`	`72`	`double sum = 0.0;`
`73`		`- for (unsigned int i = 0; i < 1e6; ++i)`
	`73`	`+ constexpr unsigned int big_stopping_criteria=1e6;`
	`74`	`+ for (unsigned int i = 0; i < big_stopping_criteria; ++i)`
`74`	`75`	`{`
`75`	`76`	`sum += i;`
`76`	`77`	`}`
`77`		`-`
`78`	`78`	`localTimer.Stop();`
	`79`	`+ // Need to use the variable sum to ensure that it is not optimized away.`
	`80`	`+ std::cout << " Time for simple addition summing loop with "`
	`81`	`+ << big_stopping_criteria << " iterations: "`
	`82`	`+ << localTimer.GetMean() << " sum = (" << sum << ")\n";`
`79`	`83`	`}`
`80`	`84`
`81`	`85`	`if (!CheckTimeProbe(localTimer))`
Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,13 @@ TestTransformPhysicalPointToIndex(T * image)`
`62`	`62`	`for (int i = 0; i < 1000; i++)`
`63`	`63`	`{`
`64`	`64`	`point3D[0] = static_cast<typename itk::NumericTraits<typename T::PointType>::ValueType>(i);`
`65`		`- image->TransformPhysicalPointToIndex(point3D, index3D);`
	`65`	`+ index3D = image->TransformPhysicalPointToIndex(point3D);`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`	`if (k == 5)`
`69`		`- std::cout << point3D << std::endl;`
	`69`	`+ {`
	`70`	`+ std::cout << point3D << " at " << index3D << std::endl;`
	`71`	`+ }`
`70`	`72`	`}`
`71`	`73`	`}`
`72`	`74`	`//-------------------------`