Skip to content

Commit fb711db

Browse files
committed
linux: Build with -O2 optimization
Tradeoff between size and speed.
1 parent 4da0807 commit fb711db

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

scripts/internal/manylinux-build-wheels.sh

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ for PYBIN in "${PYBINARIES[@]}"; do
3838
# Install dependencies
3939
${PYBIN}/pip install --upgrade -r /work/requirements-dev.txt
4040

41-
build_type=MinSizeRel
41+
build_type=""
42+
compile_flags="-O2 -DNDEBUG"
4243
source_path=/work/ITK-source/ITK
4344
build_path=/work/ITK-$(basename $(dirname ${PYBIN}))-manylinux1_${ARCH}
4445
SETUP_PY_CONFIGURE="${script_dir}/../setup_py_configure.py"
@@ -56,14 +57,17 @@ for PYBIN in "${PYBINARIES[@]}"; do
5657
# Configure setup.py
5758
${PYBIN}/python ${SETUP_PY_CONFIGURE} "itk"
5859
# Generate wheel
59-
${PYBIN}/python setup.py bdist_wheel --build-type ${build_type} -G Ninja -- \
60+
${PYBIN}/python setup.py bdist_wheel -G Ninja -- \
6061
-DITK_SOURCE_DIR:PATH=${source_path} \
6162
-DITK_BINARY_DIR:PATH=${build_path} \
6263
-DITKPythonPackage_ITK_BINARY_REUSE:BOOL=OFF \
6364
-DITKPythonPackage_WHEEL_NAME:STRING="itk" \
6465
-DITK_WRAP_unsigned_short:BOOL=ON \
6566
-DITK_WRAP_double:BOOL=ON \
6667
-DCMAKE_CXX_COMPILER_TARGET:STRING=$(uname -p)-linux-gnu \
68+
-DCMAKE_CXX_FLAGS:STRING="$compile_flags" \
69+
-DCMAKE_C_FLAGS:STRING="$compile_flags" \
70+
-DCMAKE_BUILD_TYPE:STRING="${build_type}" \
6771
-DPython3_EXECUTABLE:FILEPATH=${Python3_EXECUTABLE} \
6872
-DPython3_INCLUDE_DIR:PATH=${Python3_INCLUDE_DIR} \
6973
-DITK_WRAP_DOC:BOOL=ON \
@@ -89,6 +93,9 @@ for PYBIN in "${PYBINARIES[@]}"; do
8993
-DPython3_EXECUTABLE:FILEPATH=${Python3_EXECUTABLE} \
9094
-DPython3_INCLUDE_DIR:PATH=${Python3_INCLUDE_DIR} \
9195
-DCMAKE_CXX_COMPILER_TARGET:STRING=$(uname -p)-linux-gnu \
96+
-DCMAKE_CXX_FLAGS:STRING="$compile_flags" \
97+
-DCMAKE_C_FLAGS:STRING="$compile_flags" \
98+
-DCMAKE_BUILD_TYPE:STRING="${build_type}" \
9299
-DWRAP_ITK_INSTALL_COMPONENT_IDENTIFIER:STRING=PythonWheel \
93100
-DWRAP_ITK_INSTALL_COMPONENT_PER_MODULE:BOOL=ON \
94101
-DITK_WRAP_unsigned_short:BOOL=ON \
@@ -109,7 +116,7 @@ for PYBIN in "${PYBINARIES[@]}"; do
109116
# Configure setup.py
110117
${PYBIN}/python ${SETUP_PY_CONFIGURE} ${wheel_name}
111118
# Generate wheel
112-
${PYBIN}/python setup.py bdist_wheel --build-type ${build_type} -G Ninja -- \
119+
${PYBIN}/python setup.py bdist_wheel -G Ninja -- \
113120
-DITK_SOURCE_DIR:PATH=${source_path} \
114121
-DITK_BINARY_DIR:PATH=${build_path} \
115122
-DITKPythonPackage_ITK_BINARY_REUSE:BOOL=ON \
@@ -118,6 +125,9 @@ for PYBIN in "${PYBINARIES[@]}"; do
118125
-DITK_WRAP_double:BOOL=ON \
119126
-DPython3_EXECUTABLE:FILEPATH=${Python3_EXECUTABLE} \
120127
-DPython3_INCLUDE_DIR:PATH=${Python3_INCLUDE_DIR} \
128+
-DCMAKE_BUILD_TYPE:STRING="${build_type}" \
129+
-DCMAKE_CXX_FLAGS:STRING="${compile_flags}" \
130+
-DCMAKE_C_FLAGS:STRING="${compile_flags}" \
121131
-DITK_WRAP_DOC:BOOL=ON \
122132
-DDOXYGEN_EXECUTABLE:FILEPATH=/work/tools/doxygen-1.8.11/bin/doxygen \
123133
|| exit 1

0 commit comments

Comments
 (0)