Skip to content

Commit fbc4de3

Browse files
committed
BUG: macos arm64 requires OSX target 11.0, correct x86_64 target
$(arch) is i386, not x86_64.
1 parent d92656f commit fbc4de3

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

scripts/macpython-build-module-wheels.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@ for VENV in "${VENVS[@]}"; do
3939
if [[ $(arch) == "arm64" ]]; then
4040
plat_name="macosx-11.0-arm64"
4141
osx_target="11.0"
42-
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_x86_64"
42+
osx_arch="arm64"
43+
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_arm64"
4344
else
4445
plat_name="macosx-10.9-x86_64"
4546
osx_target="10.9"
46-
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_arm64"
47+
osx_arch="x86_64"
48+
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_x86_64"
4749
fi
4850

4951
if [[ -e $PWD/requirements-dev.txt ]]; then
@@ -57,7 +59,7 @@ for VENV in "${VENVS[@]}"; do
5759
-DWRAP_ITK_INSTALL_COMPONENT_IDENTIFIER:STRING=PythonWheel \
5860
-DSWIG_EXECUTABLE:FILEPATH=${itk_build_path}/Wrapping/Generators/SwigInterface/swig/bin/swig \
5961
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${osx_target} \
60-
-DCMAKE_OSX_ARCHITECTURES:STRING=$(arch) \
62+
-DCMAKE_OSX_ARCHITECTURES:STRING=${osx_arch} \
6163
-DBUILD_TESTING:BOOL=OFF \
6264
-DPython3_EXECUTABLE:FILEPATH=${Python3_EXECUTABLE} \
6365
-DPython3_INCLUDE_DIR:PATH=${Python3_INCLUDE_DIR} \

scripts/macpython-build-wheels.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,13 @@ for VENV in "${VENVS[@]}"; do
6767
build_type="Release"
6868
if [[ $(arch) == "arm64" ]]; then
6969
plat_name="macosx-11.0-arm64"
70-
osx_target="10.0"
70+
osx_target="11.0"
71+
osx_arch="arm64"
7172
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_x86_64"
7273
else
7374
plat_name="macosx-10.9-x86_64"
7475
osx_target="10.9"
76+
osx_arch="x86_64"
7577
build_path="${SCRIPT_DIR}/../ITK-${py_mm}-macosx_arm64"
7678
fi
7779
source_path=${SCRIPT_DIR}/../ITK-source/ITK
@@ -94,7 +96,7 @@ for VENV in "${VENVS[@]}"; do
9496
-DITK_SOURCE_DIR:PATH= ${source_path} \
9597
-DITK_BINARY_DIR:PATH=${build_path} \
9698
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${osx_target} \
97-
-DCMAKE_OSX_ARCHITECTURES:STRING=$(arch) \
99+
-DCMAKE_OSX_ARCHITECTURES:STRING=${osx_arch} \
98100
-DITK_WRAP_unsigned_short:BOOL=ON \
99101
-DITK_WRAP_double:BOOL=ON \
100102
-DITK_WRAP_complex_double:BOOL=ON \
@@ -121,7 +123,7 @@ for VENV in "${VENVS[@]}"; do
121123
-DITK_BINARY_DIR:PATH=${build_path} \
122124
-DBUILD_TESTING:BOOL=OFF \
123125
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${osx_target} \
124-
-DCMAKE_OSX_ARCHITECTURES:STRING=$(arch) \
126+
-DCMAKE_OSX_ARCHITECTURES:STRING=${osx_arch} \
125127
-DITK_WRAP_unsigned_short:BOOL=ON \
126128
-DITK_WRAP_double:BOOL=ON \
127129
-DITK_WRAP_complex_double:BOOL=ON \
@@ -149,7 +151,7 @@ for VENV in "${VENVS[@]}"; do
149151
-DITK_SOURCE_DIR:PATH=${source_path} \
150152
-DITK_BINARY_DIR:PATH=${build_path} \
151153
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${osx_target} \
152-
-DCMAKE_OSX_ARCHITECTURES:STRING=$(arch) \
154+
-DCMAKE_OSX_ARCHITECTURES:STRING=${osx_arch} \
153155
-DITKPythonPackage_ITK_BINARY_REUSE:BOOL=ON \
154156
-DITKPythonPackage_WHEEL_NAME:STRING=${wheel_name} \
155157
-DITK_WRAP_unsigned_short:BOOL=ON \

0 commit comments

Comments
 (0)