Skip to content

Commit fdce0b6

Browse files
committed
ENH: Clean up gerrit code review system leftovers
Clean up `gerrit` code review system leftovers: `gerrit` was substituted by `GitHub` early 2018, e.g. #45 Enough time has elapsed so that all developers have updated their local configuration.
1 parent 600e811 commit fdce0b6

File tree

4 files changed

+0
-95
lines changed

4 files changed

+0
-95
lines changed

Utilities/GitSetup/config.sample

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,3 @@
1414
[stage]
1515
#url = git://public.kitware.com/stage/Project.git
1616
#pushurl = [email protected]:stage/Project.git
17-
18-
[gerrit]
19-
#project = Project
20-
site = https://review.source.kitware.com
21-
# pushurl placeholder "$username" is literal
22-
pushurl = [email protected]:Project

Utilities/GitSetup/git-gerrit-push

Lines changed: 0 additions & 73 deletions
This file was deleted.

Utilities/GitSetup/setup-git-aliases

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ git config alias.pr-clean '!git checkout master ; git for-each-ref refs/heads/pr
88
# Alias to push the current topic branch to GitHub
99
git config alias.review-push "!bash Utilities/GitSetup/git-review-push"
1010

11-
git config alias.gerrit-push \
12-
"!bash -c 'echo \\\"git gerrit-push\\\" is deprecated. Please use \\\"git review-push\\\" instead.'"
13-
1411
# Useful alias to see what commits are on the current branch with respect to
1512
# upstream/master
1613
git config alias.prepush 'log --graph --stat upstream/master..'

Utilities/SetupForDevelopment.sh

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,6 @@ git config branch.master.rebase true
3636
git config rebase.stat true
3737
git config branch.master.rebase true
3838

39-
# Disable old Gerrit hooks
40-
hook=$(git config --get hooks.GerritId) &&
41-
if "$hook"; then
42-
echo '
43-
ITK has migrated from Gerrit to GitHub for code reviews.
44-
45-
Disabling the GerritId hook that adds a "Change-Id" footer to commit
46-
messages for interaction with Gerrit. Also, removing the "gerrit" remote.' &&
47-
git config hooks.GerritId false
48-
git config --get remote.gerrit.url > /dev/null && \
49-
git remote remove gerrit
50-
fi
51-
5239
# Record the version of this setup so Hooks/pre-commit can check it.
5340
SetupForDevelopment_VERSION=1
5441
git config hooks.SetupForDevelopment ${SetupForDevelopment_VERSION}

0 commit comments

Comments
 (0)