Skip to content

DOC: Add or update example visuals #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

DOC: Add or update example visuals #440

merged 2 commits into from
Mar 11, 2025

Conversation

@jph6366
Copy link
Contributor

@jph6366 jph6366 commented Mar 8, 2025 •
edited
Loading

#359

  • Updated and Added visuals to the examples listed below
  • Added a WebAssembly html code sample in Read A PointSet and ITK/VTK Viewer reading in a vtk file fetched from external data cid

Apply A Filter Only To A Specified Region Of An Image

Convert Array To Image

Apply Custom Operation To Each Pixel In Image

Bounding Box Of A Point Set

Bresenham Line

Create Derivative Kernel

Create Gaussian Kernel

Create Vector Image

Crop Image By Specifying Region

Image Region Intersection

Make Part of an Image Transparent

Mini Pipeline

Read a PointSet

  • Resources that were quite helpful in the comprehension of ITK process objects and data objects

The Architecture of Open Source Applications (Volume 2) ITK and of course the ITK Software Guide Books 1 & 2

jph6366 and others added 2 commits March 1, 2025 14:28
@jph6366
Added ApplyAFiilterOnlyToASpecifiedRegionOfAnImage.drawio
e8585c3
@jph6366
DOC: Add or update example visuals InsightSoftwareConsortium#359
ed7c181 
my first issue: contributed updates to visuals and just a single webassembly version with xtk-viewer included.

 I could finish this out or leave it up for other first issues for new contributors.
 But I would certainly like feedback on my spoofed diagrams and applied example visuals
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Data Changes to example data (usually displayed images) type:Documentation Documentation improvement or change labels Mar 8, 2025
@jph6366
Copy link
Contributor Author

jph6366 commented Mar 10, 2025 •
edited
Loading

For the Apply A Filter Only To A Specified Region Of An Image Example

I also spoofed a sequence diagram from architecture of open source applications (vol 2) ITK.
I was unsure that something like this would be more compelling for comparing input and output, rather than the simplified real-world data visuals.
Sequence

@dzenanz dzenanz requested review from N-Dekker and hjmjohnson March 10, 2025 13:10
@jph6366 jph6366 changed the title DOC: Add or update example visuals WIP: Add or update example visuals Mar 11, 2025
@jph6366 jph6366 changed the title WIP: Add or update example visuals DOC: Add or update example visuals Mar 11, 2025
@jph6366
Copy link
Contributor Author

jph6366 commented Mar 11, 2025 •
edited
Loading

The ITK/VTK Viewer implemented is just the default viewer, Kaibu provides the ability to run the example and edit the code. I should implement something of this before closing. Here is an example also of Sokol's visualization examples, perhaps a version of this would also be compelling to modify the existing cascading list page to display examples with existing images and/or itk/vtk viewers.

Should I make separate PR for work involved with setting up the ITK/VTK Viewer (with proper user interactivty) and then also updating the cascading list display?

@thewtex
Copy link
Member

thewtex commented Mar 11, 2025 •
edited
Loading

@jph6366 thanks for the contribution.

Should I make separate PR for work involved with setting up the ITK/VTK Viewer (with proper user interactivty) and then also updating the cascading list display?

No, ITK/VTK Viewer is no longer developed.

After infrastructure has been updated to fix builds, deployment, cascading list display, ITK-Wasm, there will be opportunities to contribute further.

@thewtex thewtex merged commit 6b7cec5 into InsightSoftwareConsortium:master Mar 11, 2025
3 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@N-Dekker N-Dekker Awaiting requested review from N-Dekker

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module type:Data Changes to example data (usually displayed images) type:Documentation Documentation improvement or change type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jph6366 @thewtex