BUG: Manually create pixel of proper length

Use the generalized NumericTraits::SetLength method to create a output
pixel type of the proper length.

The prior approach was producing a segmentation fault with the RLE
filter when used with VectorImages and an image with dimension 64x64x1
due to the neighborhood operator exceeding the size of the image in
the z-direction.

Additionally, this usage in complicated with the C++11 implementation
using a "move" assignment/constructor, where the vector may be
pointing to the same pixel in the output buffer for the duration of
the method.

Author: blowekamp

include/itkCoocurrenceTextureFeaturesImageFilter.hxx

@@ -141,6 +141,7 @@ CoocurrenceTextureFeaturesImageFilter<TInputImage, TOutputImage, TMaskImage>
 
   // Creation of the output pixel type
   typename TOutputImage::PixelType outputPixel;
+  NumericTraits<typename TOutputImage::PixelType>::SetLength(outputPixel, outputPtr->GetNumberOfComponentsPerPixel());
 
   // Separation of the non-boundary region that will be processed in a different way
   NeighborhoodAlgorithm::ImageBoundaryFacesCalculator< DigitizedImageType > boundaryFacesCalculator;
@@ -150,12 +151,6 @@ CoocurrenceTextureFeaturesImageFilter<TInputImage, TOutputImage, TMaskImage>
 
   // Declaration of the variables useful to iterate over the all image region
   bool isInImage;
-  IndexType firstIndex;
-  for ( unsigned int i = 0; i < this->m_NeighborhoodRadius.Dimension; ++i )
-    {
-    firstIndex[i] = 0;
-    }
-  outputPixel = outputPtr->GetPixel(firstIndex);
   typename OffsetVector::ConstIterator offsets;
 
   // Declaration of the variables useful to iterate over the all the offsets

include/itkRunLengthTextureFeaturesImageFilter.hxx

@@ -145,6 +145,7 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage, TMaskImage>
 
   // Creation of the output pixel type
   typename TOutputImage::PixelType outputPixel;
+  NumericTraits<typename TOutputImage::PixelType>::SetLength(outputPixel, outputPtr->GetNumberOfComponentsPerPixel());
 
   // Creation of a region with the same size as the neighborhood. This region
   // will be used to check if each voxel has already been visited.
@@ -174,7 +175,6 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage, TMaskImage>
 
   // Declaration of the variables useful to iterate over the all image region
   bool isInImage;
-  outputPixel = outputPtr->GetPixel(boolCurentInNeighborhoodIndex);
   typename OffsetVector::ConstIterator offsets;
 
   // Declaration of the variables useful to iterate over the all the offsets