BUG: Address RunLengthTextureFeatures histogram memory leak

Author: thewtex

include/itkRunLengthTextureFeaturesImageFilter.hxx

@@ -171,10 +171,10 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
   // Declaration of the variables useful to iterate over the all the offsets
   OffsetType offset;
   unsigned int totalNumberOfRuns;
-  unsigned int **hist =  new unsigned int*[m_NumberOfBinsPerAxis];
-  for(unsigned int a= 0; a < m_NumberOfBinsPerAxis; a++)
+  unsigned int **histogram =  new unsigned int*[m_NumberOfBinsPerAxis];
+  for(unsigned int axis = 0; axis < m_NumberOfBinsPerAxis; ++axis)
     {
-    hist[a] = new unsigned int[m_NumberOfBinsPerAxis];
+    histogram[axis] = new unsigned int[m_NumberOfBinsPerAxis];
     }
 
   // Declaration of the variables useful to iterate over the all neighborhood region
@@ -210,7 +210,7 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
         {
         for(unsigned int b = 0; b < m_NumberOfBinsPerAxis; b++)
           {
-          hist[a][b] = 0;
+          histogram[a][b] = 0;
           }
         }
       totalNumberOfRuns = 0;
@@ -266,20 +266,26 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
               }
             }
           // Increase the corresponding bin in the histogram
-          this->IncreaseHistogram(hist, totalNumberOfRuns,
+          this->IncreaseHistogram(histogram, totalNumberOfRuns,
                                    curentInNeighborhoodPixelIntensity,
                                    offset, pixelDistance);
           }
         }
       // Compute the run length features
-      this->ComputeFeatures( hist, totalNumberOfRuns, outputPixel);
+      this->ComputeFeatures( histogram, totalNumberOfRuns, outputPixel);
       outputIt.Set(outputPixel);
 
       progress.CompletedPixel();
       ++inputNIt;
       ++outputIt;
       }
     }
+
+  for(unsigned int axis = 0; axis < m_NumberOfBinsPerAxis; ++axis)
+    {
+    delete histogram[axis];
+    }
+  delete histogram;
 }
 
 template<typename TInputImage, typename TOutputImage>
@@ -389,7 +395,7 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
 template<typename TInputImage, typename TOutputImage>
 void
 RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
-::IncreaseHistogram(unsigned int **hist, unsigned int &totalNumberOfRuns,
+::IncreaseHistogram(unsigned int **histogram, unsigned int &totalNumberOfRuns,
                      const PixelType &curentInNeighborhoodPixelIntensity,
                      const OffsetType &offset, const unsigned int &pixelDistance)
 {
@@ -406,14 +412,14 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
   if (offsetDistanceBin < static_cast< int >( m_NumberOfBinsPerAxis ))
     {
     totalNumberOfRuns++;
-    hist[curentInNeighborhoodPixelIntensity][offsetDistanceBin]++;
+    histogram[curentInNeighborhoodPixelIntensity][offsetDistanceBin]++;
     }
 }
 
 template<typename TInputImage, typename TOutputImage>
 void
 RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
-::ComputeFeatures( unsigned int **hist,const unsigned int &totalNumberOfRuns,
+::ComputeFeatures( unsigned int **histogram,const unsigned int &totalNumberOfRuns,
                    typename TOutputImage::PixelType &outputPixel)
 {
   OutputRealType shortRunEmphasis = NumericTraits<OutputRealType>::ZeroValue();
@@ -436,7 +442,7 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
     {
     for(unsigned int b = 0; b < m_NumberOfBinsPerAxis; b++)
       {
-      OutputRealType frequency = hist[a][b];
+      OutputRealType frequency = histogram[a][b];
       if ( Math::ExactlyEquals(frequency, NumericTraits<OutputRealType>::ZeroValue()) )
         {
         continue;