COMP: RunLength signed / unsigned comparison

thewtex · thewtex · commit a9a48e131f24 · 2017-07-25T09:50:08.000-04:00
To address:

 c:\jenkins\workspace\itkgerritwindows\itk-src\modules\remote\texturefeatures\include\itkRunLengthTextureFeaturesImageFilter.hxx(404):
 warning C4018: '&lt;': signed/unsigned mismatch
diff --git a/include/itkRunLengthTextureFeaturesImageFilter.hxx b/include/itkRunLengthTextureFeaturesImageFilter.hxx
@@ -398,10 +398,10 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>
     }
   offsetDistance = std::sqrt(offsetDistance);
 
-  int offsetDistanceBin = (int)(( offsetDistance*pixelDistance - m_MinDistance)/
+  int offsetDistanceBin = static_cast< int>(( offsetDistance*pixelDistance - m_MinDistance)/
           ( (m_MaxDistance - m_MinDistance) / (float)m_NumberOfBinsPerAxis ));
 
-  if (offsetDistanceBin < m_NumberOfBinsPerAxis)
+  if (offsetDistanceBin < static_cast< int >( m_NumberOfBinsPerAxis ))
     {
     totalNumberOfRuns++;
     hist[curentInNeighborhoodPixelIntensity][offsetDistanceBin]++;

Original file line number	Diff line number	Diff line change
`@@ -398,10 +398,10 @@ RunLengthTextureFeaturesImageFilter<TInputImage, TOutputImage>`
`398`	`398`	`}`
`399`	`399`	`offsetDistance = std::sqrt(offsetDistance);`
`400`	`400`
`401`		`- int offsetDistanceBin = (int)(( offsetDistance*pixelDistance - m_MinDistance)/`
	`401`	`+ int offsetDistanceBin = static_cast< int>(( offsetDistance*pixelDistance - m_MinDistance)/`
`402`	`402`	`( (m_MaxDistance - m_MinDistance) / (float)m_NumberOfBinsPerAxis ));`
`403`	`403`
`404`		`- if (offsetDistanceBin < m_NumberOfBinsPerAxis)`
	`404`	`+ if (offsetDistanceBin < static_cast< int >( m_NumberOfBinsPerAxis ))`
`405`	`405`	`{`
`406`	`406`	`totalNumberOfRuns++;`
`407`	`407`	`hist[curentInNeighborhoodPixelIntensity][offsetDistanceBin]++;`