Skip to content

Commit 1e96b33

Browse files
committed
COMP: Workaround Colab/Jupyter tornado dependency conflict for [all]
To make `pip install itkwidgets[all]` work in more situations out-of-the-box, only install the Jupyter related dependencies with Python version greater than 3.7 as a proxy for Google Colab. This works with the tools we have for dependency requirements and environments: - https://hatch.pypa.io/latest/config/dependency/ - https://peps.python.org/pep-0508/ Google Colab has Python 3.7, not many other environments have it because it is deprecated. The google-colab package requires tornado~=5.1.0, jupyter requires tornado>=6.2. 6.2 gets installed in Colab, and colab does not work. This should be coupled with some ongoing work by @bnmajor to detect the running environment and throw an error if the required package dependencies are not installed for the case of Python 3.7 + Jupyter.
1 parent fc4730d commit 1e96b33

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ Source = "https://github.com/InsightSoftwareConsortium/itkwidgets"
5959

6060
[project.optional-dependencies]
6161
all = [
62-
"imjoy-jupyterlab-extension >=0.1.13",
63-
"imjoy-elfinder[jupyter]",
64-
"imjoy-jupyter-extension >=0.3.0"
62+
"imjoy-jupyterlab-extension >=0.1.13 ; python_version > '3.7'",
63+
"imjoy-elfinder[jupyter] ; python_version > '3.7'",
64+
"imjoy-jupyter-extension >=0.3.0 ; python_version > '3.7'"
6565
]
6666
lab = [
6767
"imjoy-jupyterlab-extension >=0.1.13",

0 commit comments

Comments
 (0)