Merge pull request #10 from Instabug/fix/8.0.1

🐛 fix setCommentFieldRequired removed instead of deprecated

Author: salmamali

src/android/IBGPlugin.java

@@ -242,7 +242,8 @@ public boolean execute(final String action, JSONArray args, final CallbackContex
             setEmailFieldRequiredForFeatureRequests(callbackContext, args.optBoolean(0), args.optJSONArray(1));
         } else if ("showWelcomeMessage".equals(action)) {
             showWelcomeMessage(callbackContext, args.optString(0));
-
+        } else if ("setCommentFieldRequired".equals(action)) {
+            setCommentFieldRequired(callbackContext, args.optBoolean(0));
         } else {
             // Method not found.
             return false;
@@ -266,6 +267,16 @@ private void activate(final CallbackContext callbackContext, JSONArray args) {
         callbackContext.success();
     }
 
+    /**
+     * @deprecated since version 8.0.0.
+     * @param callbackContext
+     * @param required
+     */
+    public void setCommentFieldRequired(final CallbackContext callbackContext, boolean required) {
+        Instabug.setCommentFieldRequired(required);
+        callbackContext.success();
+    }
+
     /**
      * Sets the invocation options used when invoke Instabug SDK
      *

src/ios/IBGPlugin.m

@@ -811,6 +811,23 @@ - (void) setExtendedBugReportMode:(CDVInvokedUrlCommand*)command
     [self.commandDelegate sendPluginResult:result callbackId:[command callbackId]];
 }
 
+-(void) setCommentFieldRequired:(CDVInvokedUrlCommand*)command
+{
+    CDVPluginResult* result;
+    
+    BOOL isRequired = [command argumentAtIndex:0];
+    
+    if (isRequired) {
+        [Instabug setCommentFieldRequired:[[command argumentAtIndex:0] boolValue]];
+        result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
+    } else {
+        result = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR
+                                   messageAsString:@"A boolean value must be provided."];
+    }
+    
+    [self.commandDelegate sendPluginResult:result callbackId:[command callbackId]];
+}
+
 /**
  * Convenience method for setting whether the email
  * field is validated or not.
@@ -832,13 +849,14 @@ - (void) setEmailFieldRequired:(NSString*)required
  * @param {NSString*} required
  *        NSString representation of boolean required
  */
-- (void) setCommentFieldRequired:(NSString*)required
+- (void) setCommentRequired:(NSString*)required
 {
     if ([required length] > 0) {
-        [Instabug setCommentFieldRequired:[required boolValue]];
+        [Instabug setCommentFieldRequired:true];
     }
 }
 
+
 /**
  * Convenience method for setting the default SDK
  * mode upon invocation.
@@ -1299,7 +1317,7 @@ - (void) setShouldShowSurveysWelcomeScreen:(CDVInvokedUrlCommand*)command
 - (void) applyOptions:(NSDictionary*)options
 {
     [self setEmailFieldRequired:[[options objectForKey:@"emailRequired"] stringValue]];
-    [self setCommentFieldRequired:[[options objectForKey:@"commentRequired"] stringValue]];
+    [self setCommentRequired:[[options objectForKey:@"commentRequired"] stringValue]];
     [self setDefaultInvocationMode:[options objectForKey:@"defaultInvocationMode"]];
     [self setShakingThresholdForIPhone:[options objectForKey:@"shakingThresholdIPhone"]
                                forIPad:[options objectForKey:@"shakingThresholdIPad"]];

www/instabug.js

@@ -492,4 +492,11 @@ Instabug.setShouldShowSurveysWelcomeScreen = function (shouldShowWelcomeScreen,
     exec(success, error, 'IBGPlugin', 'setShouldShowSurveysWelcomeScreen', [shouldShowWelcomeScreen]);
 };
 
+/**
+ * @deprecated since version 8.0.0.
+ */
+Instabug.setCommentFieldRequired = function(commentRequired, success, error) {
+    exec(success, error, 'IBGPlugin', 'setCommentFieldRequired', [commentRequired])
+} 
+
 module.exports = Instabug;